Rebrand to Bitcoin Corrr #18489

maflcko · 2020-04-01T03:01:25Z

Screenshots:

luke-jr · 2020-04-01T03:04:12Z

The image is a placeholder, right? Kinda pixelated and poor quality as-is...

Concept ACK

jeandudey · 2020-04-01T03:32:50Z

src/qt/splashscreen.cpp

@@ -64,7 +64,7 @@ SplashScreen::SplashScreen(interfaces::Node& node, Qt::WindowFlags f, const Netw
    pixPaint.fillRect(rGradient, gradient);

    // draw the bitcoin icon, expected size of PNG: 1024x1024


Suggested change

// draw the bitcoin icon, expected size of PNG: 1024x1024

// draw the bitcoin corr icon, expected size of PNG: 1024x1024

@jeandudey Please note that the suggested name is "Corrr" (three R) and not "Corr" (two R).

It might not sound important but the third R really underscores that the money printer is running at full capacity.

Somewhat related: "corr" might be misinterpreted as "correlation" and it should be noted that correlation does not imply causation. Correlation is fragile. Causation is robust (like Bitcoin Corrr).

Sorry my mistake, this isn't a blocker for me, of course the correct "Corrr" should fixed ASAP.

Not a strong opinion though.

practicalswift

Concept ACK modulo nits

practicalswift · 2020-04-01T05:33:33Z

src/qt/splashscreen.cpp

@@ -64,7 +64,7 @@ SplashScreen::SplashScreen(interfaces::Node& node, Qt::WindowFlags f, const Netw
    pixPaint.fillRect(rGradient, gradient);

    // draw the bitcoin icon, expected size of PNG: 1024x1024
-    QRect rectIcon(QPoint(-150,-122), QSize(430,430));
+    QRect rectIcon(QPoint(-15,-12), QSize(270,270));


Nit: Please clang-format -i to get proper social distancing between -15 and -12.

Same comment also applies to 270 and 270 (self-quarantine).

And why isn't this variable called rektIcon?

laanwj · 2020-04-01T05:53:14Z

Concept ACK, I think this is really going with the times which is good, but also this only makes sense if it includes a fork to give a trillion BTC in stimulus measures to us.

abrkn · 2020-04-01T05:59:45Z

The image is a placeholder, right? Kinda pixelated and poor quality as-is...

Concept ACK

I think the pixelated logo is a strong statement: "I'm in it for the technology. BRRRRRRRR"

JeremyRubin · 2020-04-01T06:04:17Z

Excuse me, you may not know this but while it's fine to rebrand to Bitcoin Corr, the CNetMessageType Buffer is only allowed to be 12 characters long so I'm worried we might have some network issues with the name Bitcoin Corrr as it's 13 characters. As a suggestion, maybe we can just use the name "Bitcorrrn" which is I think more clear to users about the quality of the software they are receiving.

cryptozeny

LGTM

sidhujag · 2020-04-01T06:40:16Z

Concept ACK, bring back alert messages so we can announce this to all listening peers.

jonasschnelli · 2020-04-01T06:42:15Z

Nice! I waited for this...
Concept ACK.
Gitian Build: https://bitcoin.jonasschnelli.ch/gitian/build/66

mFarghaly · 2020-04-01T07:38:11Z

LGTM.
MERRRRRRRGE.

FelixWeis · 2020-04-01T07:45:09Z

I always support a new logo and rebranding. Not implementing a new, completly arbitrary monetary policy change feels like a wasted oBRRRtunity.
NACK!

laanwj · 2020-04-01T08:08:11Z

I think we should emphasize that bitcoin is magic internet money, so doesn't need something as trivial as a printing press, here's an alternative proposal:

Danny-Scott · 2020-04-01T08:19:28Z

Concept ACK - All though I prefer @laanwj logo

I'm just disappointed it's taken this long to re-brand

JeremyCrookshank · 2020-04-01T08:21:32Z

Concept ACK 👍

dannmat · 2020-04-01T08:21:53Z

Concept NACK. I propse we rename to something more meaningful. Like Bitcoin Cash?

ajtowns · 2020-04-01T08:39:47Z

configure.ac

@@ -7,8 +7,8 @@ define(_CLIENT_VERSION_RC, 0)
 define(_CLIENT_VERSION_IS_RELEASE, false)
 define(_COPYRIGHT_YEAR, 2020)
 define(_COPYRIGHT_HOLDERS,[The %s developers])


"The %s corps" might be a better signal of the strength of our commitment to ensuring there is enough Bitcoin for everyone.

Aleru · 2020-04-01T08:43:57Z

lgtm, I think there should be some more work on the image eventually though.

cvengler · 2020-04-01T09:14:27Z

Concept ACK, but I suggest to switch to a more meaningful release tag like 1.0

theStack

Concept ACK -- this will make the user-adoption skyrocket!

May I suggest a small follow-up PR reflecting the new awesome logo:
Changing the following annoying line

bitcoin/src/validation.cpp

Line 1228 in b97e3a7

nSubsidy >>= halvings;

to

nSubsidy <<= halvings;

With this modern monetary policy, we will fight poverty, and recreate social justice, a.k.a. everyone will be rich. I'm aware that the subsidy could overflow in the long run, but in the long run we will all be dead.

kiminuo · 2020-04-01T10:45:43Z

Concept ACK, thank you for working on this.

kek-coin · 2020-04-01T10:57:49Z

Concept ACK, I think this is really going with the times which is good, but also this only makes sense if it includes a fork to give a trillion BTC in stimulus measures to us.

I think we should let the free market decide which devs to reward - let's implement separate forks for each individual contributor to this repo (1 trillion BTC per dev) that can be individually signalled using version bits.

elichai · 2020-04-01T11:03:58Z

Concept ACK, can this get in time for 0.20?

nopara73

NACK. IMO it's misleading as it suggests Core can create more money out of thin air like central banks do, but that is not true.

promag · 2020-04-01T11:09:29Z

Thanks for working on this, at last something worth from you.

Code review ACK 7777c40. Could split in multiple commits and please add release notes and new test.

Building in XP, I'll let you know how that goes.

promag · 2020-04-01T11:10:50Z

Concept ACK, but I suggest to switch to a more meaningful release tag like 1.0

@emilengler imo we could jump into version 2 ME.

sr-gi · 2020-04-01T11:25:37Z

Concept ACK. However I saw that the project website has not been updated.

I got the new domain to prevent takeovers: https://bitcoincorrr.org/

TheRec · 2020-04-01T13:53:57Z

LGTM... as in Let's Get This Money.

nshCore · 2020-04-01T14:19:53Z

Concept NACK. I propse we rename to something more meaningful. Like Bitcoin Cash?

digital cash was satoshi's original vision, maybe it should even moarrr meaningful and be called bitcoin satoshis original vision? has a ring I think

JosuGZ

Concept ACK

bitbug42 · 2020-04-01T20:24:44Z

Very good improvement!

I'm also suggesting to remove this check:

bitcoin/src/consensus/tx_verify.cpp

Line 187 in 41fa292

if (nValueIn < value_out) {

I hate it when I can't spend the money I don't have, this is currently a major usability issue with Bitcoin. Fixing this will surely bring about mass adoption.

fanquake · 2020-04-02T05:59:00Z

Good to know that the graphic designers the project has long needed have actually been with us all along.

sipa · 2020-04-02T06:23:22Z

Upon further consideration, concept NACK from me also.

This approach is incompatible with the "quantitive hardening"-based relief package coming around May 13th.

nopara73 · 2020-04-02T07:30:47Z

isotopec-org · 2020-04-02T23:03:15Z

BRRRRRR... DERPPPPP... ACK

fad2f68 init: Replace URL_WEBSITE with PACKAGE_URL (MarcoFalke) Pull request description: This is needed for rebranding efforts such as #18489 ACKs for top commit: hebasto: ACK fad2f68, tested on Linux Mint 19.3: fanquake: ACK fad2f68 - clicked a link. Tree-SHA512: c26e18cd328d3dd3fd7e25413e1bab780026687a148f126b8673e5f6cc13249f6c16689e45eba9da1545915c6001f96cd33f4e656c08cda3eae1c3fd88da23ea

fad2f68 init: Replace URL_WEBSITE with PACKAGE_URL (MarcoFalke) Pull request description: This is needed for rebranding efforts such as bitcoin#18489 ACKs for top commit: hebasto: ACK fad2f68, tested on Linux Mint 19.3: fanquake: ACK fad2f68 - clicked a link. Tree-SHA512: c26e18cd328d3dd3fd7e25413e1bab780026687a148f126b8673e5f6cc13249f6c16689e45eba9da1545915c6001f96cd33f4e656c08cda3eae1c3fd88da23ea

giaki3003 · 2020-04-15T17:06:27Z

Does this commit automatically enable the end user to receive his Bitcoin Corrr stimulus package?

Rebrand to Bitcoin Corrr

7777c40

jeandudey reviewed Apr 1, 2020

View reviewed changes

DrahtBot added Build system GUI labels Apr 1, 2020

practicalswift suggested changes Apr 1, 2020

View reviewed changes

cryptozeny approved these changes Apr 1, 2020

View reviewed changes

ajtowns reviewed Apr 1, 2020

View reviewed changes

theStack reviewed Apr 1, 2020

View reviewed changes

nopara73 suggested changes Apr 1, 2020

View reviewed changes

Adjust project website to https://bitcoincorrr.org/

444493e

init: Replace URL_WEBSITE with PACKAGE_URL

aaaabb8

JosuGZ approved these changes Apr 1, 2020

View reviewed changes

benthecarman approved these changes Apr 1, 2020

View reviewed changes

fanquake closed this Apr 2, 2020

maflcko deleted the 2004-rebrandCorrr branch April 2, 2020 12:13

maflcko mentioned this pull request Apr 2, 2020

init: Replace URL_WEBSITE with PACKAGE_URL #18503

Merged

real-or-random mentioned this pull request Apr 10, 2020

Add speck logo bitcoin-core/secp256k1#733

Closed

bitcoin locked as resolved and limited conversation to collaborators Feb 15, 2022

		@@ -64,7 +64,7 @@ SplashScreen::SplashScreen(interfaces::Node& node, Qt::WindowFlags f, const Netw
		pixPaint.fillRect(rGradient, gradient);

		// draw the bitcoin icon, expected size of PNG: 1024x1024

	// draw the bitcoin icon, expected size of PNG: 1024x1024
	// draw the bitcoin corr icon, expected size of PNG: 1024x1024

Rebrand to Bitcoin Corrr #18489

Rebrand to Bitcoin Corrr #18489

Uh oh!

Conversation

maflcko commented Apr 1, 2020

Uh oh!

luke-jr commented Apr 1, 2020

Uh oh!

jeandudey Apr 1, 2020

Choose a reason for hiding this comment

Uh oh!

practicalswift Apr 1, 2020

Choose a reason for hiding this comment

Uh oh!

jeandudey Apr 1, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

practicalswift left a comment

Choose a reason for hiding this comment

Uh oh!

practicalswift Apr 1, 2020

Choose a reason for hiding this comment

Uh oh!

Sjors Apr 1, 2020

Choose a reason for hiding this comment

Uh oh!

laanwj commented Apr 1, 2020

Uh oh!

abrkn commented Apr 1, 2020

Uh oh!

JeremyRubin commented Apr 1, 2020

Uh oh!

cryptozeny left a comment

Choose a reason for hiding this comment

Uh oh!

sidhujag commented Apr 1, 2020

Uh oh!

jonasschnelli commented Apr 1, 2020

Uh oh!

mFarghaly commented Apr 1, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

FelixWeis commented Apr 1, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

laanwj commented Apr 1, 2020

Uh oh!

Danny-Scott commented Apr 1, 2020

Uh oh!

JeremyCrookshank commented Apr 1, 2020

Uh oh!

dannmat commented Apr 1, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ajtowns Apr 1, 2020

Choose a reason for hiding this comment

Uh oh!

Aleru commented Apr 1, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cvengler commented Apr 1, 2020

Uh oh!

theStack left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kiminuo commented Apr 1, 2020

Uh oh!

kek-coin commented Apr 1, 2020

Uh oh!

elichai commented Apr 1, 2020

Uh oh!

nopara73 left a comment

Choose a reason for hiding this comment

Uh oh!

promag commented Apr 1, 2020

Uh oh!

promag commented Apr 1, 2020

Uh oh!

jeandudey Apr 1, 2020 •

edited

Loading

mFarghaly commented Apr 1, 2020 •

edited

Loading

FelixWeis commented Apr 1, 2020 •

edited

Loading

dannmat commented Apr 1, 2020 •

edited

Loading

Aleru commented Apr 1, 2020 •

edited

Loading

theStack left a comment •

edited

Loading

sr-gi commented Apr 1, 2020 •

edited

Loading