build: Fix configure report about qr #17547
Merged
+3
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
32f353d to
651c636
Compare
|
Concept and light code review ACK 651c636 |
|
Concept ACK. |
Gitian builds
|
fanquake
approved these changes
Dec 3, 2019
fanquake
added a commit
that referenced
this pull request
Dec 3, 2019
651c636 build: Fix configure report about qr (Hennadii Stepanov) Pull request description: On master (b7bc9b8): ``` $ apt list libqrencode-dev Listing... Done libqrencode-dev/bionic 3.4.4-1build1 amd64 $ ./configure | grep -i qr checking for QR... no checking whether to build GUI with support for QR codes... no with qr = auto ``` With this PR: ``` $ apt list libqrencode-dev Listing... Done libqrencode-dev/bionic 3.4.4-1build1 amd64 $ ./configure | grep -i qr checking for QR... no checking whether to build GUI with support for QR codes... no with qr = no ``` ACKs for top commit: laanwj: Concept and light code review ACK 651c636 fanquake: ACK 651c636 Tree-SHA512: 8959b1c7da5b28d06affcdd27ff4e455f1f7d9c8363dbde8ef07aaf79139ec8bc7ce25610b28e1d90c7e168573ee90ac9ab359bf10c667d0254507f8a880a935
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Dec 4, 2019
651c636 build: Fix configure report about qr (Hennadii Stepanov) Pull request description: On master (b7bc9b8): ``` $ apt list libqrencode-dev Listing... Done libqrencode-dev/bionic 3.4.4-1build1 amd64 $ ./configure | grep -i qr checking for QR... no checking whether to build GUI with support for QR codes... no with qr = auto ``` With this PR: ``` $ apt list libqrencode-dev Listing... Done libqrencode-dev/bionic 3.4.4-1build1 amd64 $ ./configure | grep -i qr checking for QR... no checking whether to build GUI with support for QR codes... no with qr = no ``` ACKs for top commit: laanwj: Concept and light code review ACK 651c636 fanquake: ACK 651c636 Tree-SHA512: 8959b1c7da5b28d06affcdd27ff4e455f1f7d9c8363dbde8ef07aaf79139ec8bc7ce25610b28e1d90c7e168573ee90ac9ab359bf10c667d0254507f8a880a935
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Dec 4, 2019
651c636 build: Fix configure report about qr (Hennadii Stepanov) Pull request description: On master (b7bc9b8): ``` $ apt list libqrencode-dev Listing... Done libqrencode-dev/bionic 3.4.4-1build1 amd64 $ ./configure | grep -i qr checking for QR... no checking whether to build GUI with support for QR codes... no with qr = auto ``` With this PR: ``` $ apt list libqrencode-dev Listing... Done libqrencode-dev/bionic 3.4.4-1build1 amd64 $ ./configure | grep -i qr checking for QR... no checking whether to build GUI with support for QR codes... no with qr = no ``` ACKs for top commit: laanwj: Concept and light code review ACK 651c636 fanquake: ACK 651c636 Tree-SHA512: 8959b1c7da5b28d06affcdd27ff4e455f1f7d9c8363dbde8ef07aaf79139ec8bc7ce25610b28e1d90c7e168573ee90ac9ab359bf10c667d0254507f8a880a935
MarkLTZ
added a commit
to litecoinz-core/litecoinz
that referenced
this pull request
Apr 7, 2020
- doc: fix git add argument bitcoin#18513 - build: Fix libevent linking for bench_bitcoin binary bitcoin#18397 - script: fix SCRIPT_ERR_SIG_PUSHONLY error string bitcoin#18412 - doc: Comment fix merkle.cpp bitcoin#18379 - log: Fix UB with bench on genesis block bitcoin#15283 - test: Fix mining to an invalid target + ensure that a new block has the correct hash internally bitcoin#18350 - Fix missing header in sync.h bitcoin#18357 - refactor: Fix implicit value conversion in formatPingTime bitcoin#18260 - Fix .gitignore policy in build_msvc directory bitcoin#18108 - build: Fix behavior when ALLOW_HOST_PACKAGES unset bitcoin#18051 - test: Fix p2p_invalid_messages failing in Python 3.8 because of warning bitcoin#17931 - qa: Fix double-negative arg test bitcoin#17893 - build: Fix configure report about qr bitcoin#17547 - log: Fix log message for -par=1 bitcoin#17325 - bench: Fix negative values and zero for -evals flag bitcoin#17267 - depends: fix boost mac cross build with clang 9+ bitcoin#17231 - doc: Fix broken bitcoin-cli examples bitcoin#17119 - doc: fix Makefile target in benchmarking.md bitcoin#17081 - contrib: fix minor typos in makeseeds.py bitcoin#17042 - test: Fix Python Docstring to include all Args. bitcoin#17030 - doc: Fix some misspellings bitcoin#17351 - doc: Doxygen-friendly script/descriptor.h comments bitcoin#16947 - doc: Fix doxygen errors bitcoin#17945 - doc: Doxygen-friendly CuckooCache comments bitcoin#16986 - doc: Add to Doxygen documentation guidelines bitcoin#17873
MarkLTZ
added a commit
to litecoinz-core/litecoinz
that referenced
this pull request
Apr 7, 2020
- doc: fix git add argument bitcoin#18513 - build: Fix libevent linking for bench_bitcoin binary bitcoin#18397 - script: fix SCRIPT_ERR_SIG_PUSHONLY error string bitcoin#18412 - doc: Comment fix merkle.cpp bitcoin#18379 - log: Fix UB with bench on genesis block bitcoin#15283 - test: Fix mining to an invalid target + ensure that a new block has the correct hash internally bitcoin#18350 - Fix missing header in sync.h bitcoin#18357 - refactor: Fix implicit value conversion in formatPingTime bitcoin#18260 - Fix .gitignore policy in build_msvc directory bitcoin#18108 - build: Fix behavior when ALLOW_HOST_PACKAGES unset bitcoin#18051 - test: Fix p2p_invalid_messages failing in Python 3.8 because of warning bitcoin#17931 - qa: Fix double-negative arg test bitcoin#17893 - build: Fix configure report about qr bitcoin#17547 - log: Fix log message for -par=1 bitcoin#17325 - bench: Fix negative values and zero for -evals flag bitcoin#17267 - depends: fix boost mac cross build with clang 9+ bitcoin#17231 - doc: Fix broken bitcoin-cli examples bitcoin#17119 - doc: fix Makefile target in benchmarking.md bitcoin#17081 - contrib: fix minor typos in makeseeds.py bitcoin#17042 - test: Fix Python Docstring to include all Args. bitcoin#17030 - doc: Fix some misspellings bitcoin#17351 - doc: Doxygen-friendly script/descriptor.h comments bitcoin#16947 - doc: Fix doxygen errors bitcoin#17945 - doc: Doxygen-friendly CuckooCache comments bitcoin#16986 - doc: Add to Doxygen documentation guidelines bitcoin#17873 - depends: Consistent use of package variable bitcoin#17928 - init: Replace URL_WEBSITE with PACKAGE_URL bitcoin#18503 - doc: Add missed copyright headers bitcoin#17691
sidhujag
pushed a commit
to syscoin-core/syscoin
that referenced
this pull request
Nov 10, 2020
651c636 build: Fix configure report about qr (Hennadii Stepanov) Pull request description: On master (b7bc9b8): ``` $ apt list libqrencode-dev Listing... Done libqrencode-dev/bionic 3.4.4-1build1 amd64 $ ./configure | grep -i qr checking for QR... no checking whether to build GUI with support for QR codes... no with qr = auto ``` With this PR: ``` $ apt list libqrencode-dev Listing... Done libqrencode-dev/bionic 3.4.4-1build1 amd64 $ ./configure | grep -i qr checking for QR... no checking whether to build GUI with support for QR codes... no with qr = no ``` ACKs for top commit: laanwj: Concept and light code review ACK 651c636 fanquake: ACK 651c636 Tree-SHA512: 8959b1c7da5b28d06affcdd27ff4e455f1f7d9c8363dbde8ef07aaf79139ec8bc7ce25610b28e1d90c7e168573ee90ac9ab359bf10c667d0254507f8a880a935
sidhujag
pushed a commit
to syscoin-core/syscoin
that referenced
this pull request
Nov 10, 2020
651c636 build: Fix configure report about qr (Hennadii Stepanov) Pull request description: On master (b7bc9b8): ``` $ apt list libqrencode-dev Listing... Done libqrencode-dev/bionic 3.4.4-1build1 amd64 $ ./configure | grep -i qr checking for QR... no checking whether to build GUI with support for QR codes... no with qr = auto ``` With this PR: ``` $ apt list libqrencode-dev Listing... Done libqrencode-dev/bionic 3.4.4-1build1 amd64 $ ./configure | grep -i qr checking for QR... no checking whether to build GUI with support for QR codes... no with qr = no ``` ACKs for top commit: laanwj: Concept and light code review ACK 651c636 fanquake: ACK 651c636 Tree-SHA512: 8959b1c7da5b28d06affcdd27ff4e455f1f7d9c8363dbde8ef07aaf79139ec8bc7ce25610b28e1d90c7e168573ee90ac9ab359bf10c667d0254507f8a880a935
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jun 27, 2021
651c636 build: Fix configure report about qr (Hennadii Stepanov) Pull request description: On master (b7bc9b8): ``` $ apt list libqrencode-dev Listing... Done libqrencode-dev/bionic 3.4.4-1build1 amd64 $ ./configure | grep -i qr checking for QR... no checking whether to build GUI with support for QR codes... no with qr = auto ``` With this PR: ``` $ apt list libqrencode-dev Listing... Done libqrencode-dev/bionic 3.4.4-1build1 amd64 $ ./configure | grep -i qr checking for QR... no checking whether to build GUI with support for QR codes... no with qr = no ``` ACKs for top commit: laanwj: Concept and light code review ACK 651c636 fanquake: ACK 651c636 Tree-SHA512: 8959b1c7da5b28d06affcdd27ff4e455f1f7d9c8363dbde8ef07aaf79139ec8bc7ce25610b28e1d90c7e168573ee90ac9ab359bf10c667d0254507f8a880a935
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jun 28, 2021
651c636 build: Fix configure report about qr (Hennadii Stepanov) Pull request description: On master (b7bc9b8): ``` $ apt list libqrencode-dev Listing... Done libqrencode-dev/bionic 3.4.4-1build1 amd64 $ ./configure | grep -i qr checking for QR... no checking whether to build GUI with support for QR codes... no with qr = auto ``` With this PR: ``` $ apt list libqrencode-dev Listing... Done libqrencode-dev/bionic 3.4.4-1build1 amd64 $ ./configure | grep -i qr checking for QR... no checking whether to build GUI with support for QR codes... no with qr = no ``` ACKs for top commit: laanwj: Concept and light code review ACK 651c636 fanquake: ACK 651c636 Tree-SHA512: 8959b1c7da5b28d06affcdd27ff4e455f1f7d9c8363dbde8ef07aaf79139ec8bc7ce25610b28e1d90c7e168573ee90ac9ab359bf10c667d0254507f8a880a935
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jun 29, 2021
651c636 build: Fix configure report about qr (Hennadii Stepanov) Pull request description: On master (b7bc9b8): ``` $ apt list libqrencode-dev Listing... Done libqrencode-dev/bionic 3.4.4-1build1 amd64 $ ./configure | grep -i qr checking for QR... no checking whether to build GUI with support for QR codes... no with qr = auto ``` With this PR: ``` $ apt list libqrencode-dev Listing... Done libqrencode-dev/bionic 3.4.4-1build1 amd64 $ ./configure | grep -i qr checking for QR... no checking whether to build GUI with support for QR codes... no with qr = no ``` ACKs for top commit: laanwj: Concept and light code review ACK 651c636 fanquake: ACK 651c636 Tree-SHA512: 8959b1c7da5b28d06affcdd27ff4e455f1f7d9c8363dbde8ef07aaf79139ec8bc7ce25610b28e1d90c7e168573ee90ac9ab359bf10c667d0254507f8a880a935
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jul 1, 2021
651c636 build: Fix configure report about qr (Hennadii Stepanov) Pull request description: On master (b7bc9b8): ``` $ apt list libqrencode-dev Listing... Done libqrencode-dev/bionic 3.4.4-1build1 amd64 $ ./configure | grep -i qr checking for QR... no checking whether to build GUI with support for QR codes... no with qr = auto ``` With this PR: ``` $ apt list libqrencode-dev Listing... Done libqrencode-dev/bionic 3.4.4-1build1 amd64 $ ./configure | grep -i qr checking for QR... no checking whether to build GUI with support for QR codes... no with qr = no ``` ACKs for top commit: laanwj: Concept and light code review ACK 651c636 fanquake: ACK 651c636 Tree-SHA512: 8959b1c7da5b28d06affcdd27ff4e455f1f7d9c8363dbde8ef07aaf79139ec8bc7ce25610b28e1d90c7e168573ee90ac9ab359bf10c667d0254507f8a880a935
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jul 1, 2021
651c636 build: Fix configure report about qr (Hennadii Stepanov) Pull request description: On master (b7bc9b8): ``` $ apt list libqrencode-dev Listing... Done libqrencode-dev/bionic 3.4.4-1build1 amd64 $ ./configure | grep -i qr checking for QR... no checking whether to build GUI with support for QR codes... no with qr = auto ``` With this PR: ``` $ apt list libqrencode-dev Listing... Done libqrencode-dev/bionic 3.4.4-1build1 amd64 $ ./configure | grep -i qr checking for QR... no checking whether to build GUI with support for QR codes... no with qr = no ``` ACKs for top commit: laanwj: Concept and light code review ACK 651c636 fanquake: ACK 651c636 Tree-SHA512: 8959b1c7da5b28d06affcdd27ff4e455f1f7d9c8363dbde8ef07aaf79139ec8bc7ce25610b28e1d90c7e168573ee90ac9ab359bf10c667d0254507f8a880a935
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jul 14, 2021
651c636 build: Fix configure report about qr (Hennadii Stepanov) Pull request description: On master (b7bc9b8): ``` $ apt list libqrencode-dev Listing... Done libqrencode-dev/bionic 3.4.4-1build1 amd64 $ ./configure | grep -i qr checking for QR... no checking whether to build GUI with support for QR codes... no with qr = auto ``` With this PR: ``` $ apt list libqrencode-dev Listing... Done libqrencode-dev/bionic 3.4.4-1build1 amd64 $ ./configure | grep -i qr checking for QR... no checking whether to build GUI with support for QR codes... no with qr = no ``` ACKs for top commit: laanwj: Concept and light code review ACK 651c636 fanquake: ACK 651c636 Tree-SHA512: 8959b1c7da5b28d06affcdd27ff4e455f1f7d9c8363dbde8ef07aaf79139ec8bc7ce25610b28e1d90c7e168573ee90ac9ab359bf10c667d0254507f8a880a935
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On master (b7bc9b8):
With this PR: