Update msvc build for Visual Studio 2019 v16.4 #17736
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msvc warning C4834 for the Bitcoin Core build was introduced by Visual Studio 16.4.0. This PR adds an ignore rule for the warning (it's related to the nodiscard attribute and is not considered relevant). An additional side effect of the msvc compiler update is the prebuilt Qt5.9.8 libraries cannot be linked due to being built with an earlier version of the compiler. To fix this a new Qt5.9.8 version has been compiled and the appveyor job updated to use them. The GitHub Actions job needs to continue to use the original Qt5.9.8 libraries until the latest GitHub Windows image also updates to >= Visual Studio 2019 v16.4.
|
My suggestion from IRC for dealing with windows compiler and package upgrades was to change appveyor check for pull requests from a simple pass/fail check to something more like: (git checkout pr && make check) || (git checkout master && ! make check)http://www.erisian.com.au/bitcoin-core-dev/log-2019-12-12.html#l-287
|
|
@ryanofsky problem is with a 90 minute cap on the job (and that's with @MarcoFalke intervening to get it from 60 to 90) there's not enough time for two builds. If you look at the appveyor history most builds are between 50 and 60 minutes. |
|
Job failed due to the old Qt libraries being used. I'll need to add a step to invalidate the Qt cache directory if the SHA256 has changed. |
|
Deleted the cache on appveyor with |
maflcko
pushed a commit
that referenced
this pull request
Dec 12, 2019
75d9317 Update msvc build for Visual Studio 2019 v16.4 (Aaron Clauson) Pull request description: msvc warning C4834 for the Bitcoin Core build was introduced by Visual Studio 16.4.0. This PR adds an ignore rule for the warning (it's related to the nodiscard attribute and is not considered relevant). An additional side effect of the msvc compiler update is the prebuilt Qt5.9.8 libraries cannot be linked due to being built with an earlier version of the compiler. To fix this a new Qt5.9.8 version has been compiled and the appveyor job updated to use them. The GitHub Actions job needs to continue to use the original Qt5.9.8 libraries until the latest GitHub Windows image also updates to >= Visual Studio 2019 v16.4. Top commit has no ACKs. Tree-SHA512: c28d64d78a968eb0bd614932b2d42d762d68853120c345970072b473e2c43fb34e99865062ae1517b10e76f269de6b8f4eed119cf05d59aa883a3553d6a76812
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Dec 13, 2019
75d9317 Update msvc build for Visual Studio 2019 v16.4 (Aaron Clauson) Pull request description: msvc warning C4834 for the Bitcoin Core build was introduced by Visual Studio 16.4.0. This PR adds an ignore rule for the warning (it's related to the nodiscard attribute and is not considered relevant). An additional side effect of the msvc compiler update is the prebuilt Qt5.9.8 libraries cannot be linked due to being built with an earlier version of the compiler. To fix this a new Qt5.9.8 version has been compiled and the appveyor job updated to use them. The GitHub Actions job needs to continue to use the original Qt5.9.8 libraries until the latest GitHub Windows image also updates to >= Visual Studio 2019 v16.4. Top commit has no ACKs. Tree-SHA512: c28d64d78a968eb0bd614932b2d42d762d68853120c345970072b473e2c43fb34e99865062ae1517b10e76f269de6b8f4eed119cf05d59aa883a3553d6a76812
This was referenced Dec 22, 2019
sipsorcery
added a commit
to sipsorcery/bitcoin
that referenced
this pull request
Jan 5, 2020
fanquake
pushed a commit
to fanquake/bitcoin
that referenced
this pull request
Jan 5, 2020
msvc warning C4834 for the Bitcoin Core build was introduced by Visual Studio 16.4.0. This PR adds an ignore rule for the warning (it's related to the nodiscard attribute and is not considered relevant). An additional side effect of the msvc compiler update is the prebuilt Qt5.9.8 libraries cannot be linked due to being built with an earlier version of the compiler. To fix this a new Qt5.9.8 version has been compiled and the appveyor job updated to use them. The GitHub Actions job needs to continue to use the original Qt5.9.8 libraries until the latest GitHub Windows image also updates to >= Visual Studio 2019 v16.4. Github-Pull: bitcoin#17736 Rebased-From: 75d9317
Merged
laanwj
added a commit
that referenced
this pull request
Jan 8, 2020
99b5407 scripts: fix check-symbols & check-security argument passing (fanquake) 4330a1e Update msvc build for Visual Studio 2019 v16.4 (Aaron Clauson) b0f9b8e Moves vcpkg list to a text file and updates the appveyor job and readme to use it. (Aaron Clauson) cd7b3b2 Updated appveyor config: - Update build image from Visual Studio 2017 to Visual Studio 2019. - Updated Qt static library from Qt5.9.7 to Qt5.9.8. - Added commands to update vcpkg port files (this does not update already installed packages). - Updated vcpkg package list as per #17309. - Removed commands setting common project file options. Now done via common.init.vcxproj include. - Changed msbuild verbosity from normal to quiet. Normal rights a LOT of logs and impacts appveyor job duration. Updated msvc project configs: - Updated platform toolset from v141 to v142. - Updated Qt static library from Qt5.9.7 to Qt5.9.8. - Added ignore for linker warning building bitcoin-qt program. - Added missing util/str.cpp class file to test_bitcoin project file. (Aaron Clauson) 112144d Add missing typeinfo includes (Wladimir J. van der Laan) 1a6a534 net: Log to net category for exceptions in ProcessMessages (Wladimir J. van der Laan) c0dc728 test: fix bitcoind already running warnings on macOS (fanquake) 5276b0e util: Add missing headers to util/fees.cpp (Hennadii Stepanov) 4d7875c rpc: require second argument only for scantxoutset start action (Andrew Chow) bda2f5b cli: fix Fatal LevelDB error when specifying -blockfilterindex=basic twice (Harris) d14ab7c gui: disable File->CreateWallet during startup (fanquake) b9f1bc0 wallet: unbreak with boost 1.72 (Jan Beich) Pull request description: Backports the following PRs to the 0.19 branch: * #17654 - Unbreak build with Boost 1.72.0 * #17695 - gui: disable File->CreateWallet during startup * #17687 - cli: fix Fatal LevelDB error when specifying -blockfilterindex=basic twice * #17728 - rpc: require second argument only for scantxoutset start action * #17450 - util: Add missing headers to util/fees.cpp * #17488 - test: fix "bitcoind already running" warnings on macOS * #17762 - Log to net category for exceptions in ProcessMessages * #17364 - Updates to appveyor config for VS2019 and Qt5.9.8 + msvc project fixes * #17416 - Appveyor improvement - text file for vcpkg package list * #17736 - Update msvc build for Visual Studio 2019 v16.4 * #17857 - scripts: fix symbol-check & security-check argument passing Fixes #17856. ACKs for top commit: sipsorcery: ACK (tested: Windows 10 & msvc build) 99b5407. Tree-SHA512: 91313de56fb0825e70a4be30ba0bf561b8c26d7dcf60549185df4f5e3524099398c828bb46faae807b631634d1afd5a1d397fb41e61ecfa0d746e4bf10b923cb
MarkLTZ
added a commit
to litecoinz-core/litecoinz
that referenced
this pull request
Mar 13, 2020
[0.19] Backports bitcoin#17858 Unbreak build with Boost 1.72.0 bitcoin#17654 cli: fix Fatal LevelDB error when specifying -blockfilterindex=basic twice bitcoin#17687 rpc: require second argument only for scantxoutset start action bitcoin#17728 wallet: Fix origfee return for bumpfee with feerate arg bitcoin#17643 test: fix "bitcoind already running" warnings on macOS bitcoin#17488 net: Log to net category for exceptions in ProcessMessages bitcoin#17762 Updates to appveyor config for VS2019 and Qt5.9.8 + msvc project fixes bitcoin#17364 Appveyor improvement - text file for vcpkg package list bitcoin#17416 Update msvc build for Visual Studio 2019 v16.4 bitcoin#17736 scripts: fix symbol-check & security-check argument passing bitcoin#17857 qt: Periodic translations update for 0.19 branch IsUsedDestination should count any known single-key address bitcoin#17621 init: Stop indexes on shutdown after ChainStateFlushed callback. bitcoin#17897 qt: Translations update pre-rc1 wallet: Reset reused transactions cache bitcoin#17843 Squashed 'src/univalue/' changes from 7890db9..98261b1 0.19: Update univalue subtree bitcoin#18100 qt: Pre-rc2 translations update
MarkLTZ
added a commit
to litecoinz-core/litecoinz
that referenced
this pull request
Mar 13, 2020
[0.19] Backports bitcoin#17858 Unbreak build with Boost 1.72.0 bitcoin#17654 cli: fix Fatal LevelDB error when specifying -blockfilterindex=basic twice bitcoin#17687 rpc: require second argument only for scantxoutset start action bitcoin#17728 wallet: Fix origfee return for bumpfee with feerate arg bitcoin#17643 test: fix "bitcoind already running" warnings on macOS bitcoin#17488 net: Log to net category for exceptions in ProcessMessages bitcoin#17762 Updates to appveyor config for VS2019 and Qt5.9.8 + msvc project fixes bitcoin#17364 Appveyor improvement - text file for vcpkg package list bitcoin#17416 Update msvc build for Visual Studio 2019 v16.4 bitcoin#17736 scripts: fix symbol-check & security-check argument passing bitcoin#17857 qt: Periodic translations update for 0.19 branch IsUsedDestination should count any known single-key address bitcoin#17621 init: Stop indexes on shutdown after ChainStateFlushed callback. bitcoin#17897 qt: Translations update pre-rc1 wallet: Reset reused transactions cache bitcoin#17843 Squashed 'src/univalue/' changes from 7890db9..98261b1 0.19: Update univalue subtree bitcoin#18100 qt: Pre-rc2 translations update [0.19] Further 0.19 backports bitcoin#18218 build: don't embed a build-id when building libdmg-hfsplus bitcoin#18004
sidhujag
pushed a commit
to syscoin-core/syscoin
that referenced
this pull request
Nov 10, 2020
75d9317 Update msvc build for Visual Studio 2019 v16.4 (Aaron Clauson) Pull request description: msvc warning C4834 for the Bitcoin Core build was introduced by Visual Studio 16.4.0. This PR adds an ignore rule for the warning (it's related to the nodiscard attribute and is not considered relevant). An additional side effect of the msvc compiler update is the prebuilt Qt5.9.8 libraries cannot be linked due to being built with an earlier version of the compiler. To fix this a new Qt5.9.8 version has been compiled and the appveyor job updated to use them. The GitHub Actions job needs to continue to use the original Qt5.9.8 libraries until the latest GitHub Windows image also updates to >= Visual Studio 2019 v16.4. Top commit has no ACKs. Tree-SHA512: c28d64d78a968eb0bd614932b2d42d762d68853120c345970072b473e2c43fb34e99865062ae1517b10e76f269de6b8f4eed119cf05d59aa883a3553d6a76812
|
Hmm not sure what's going on there. Visual Studio 2019 v16.8.1 came out a couple of days ago and Appveyor pushed the new VS2019 image a few hours ago so it's likely to be the cause. But it was only a minor Visual Studio release which means C++ ABI compatibility should be maintained. I'm building locally now to see if I get the same issue. |
|
Do we need rollback to the previous image (#19839)? |
Munkybooty
pushed a commit
to Munkybooty/dash
that referenced
this pull request
Dec 9, 2021
99b5407 scripts: fix check-symbols & check-security argument passing (fanquake) 4330a1e Update msvc build for Visual Studio 2019 v16.4 (Aaron Clauson) b0f9b8e Moves vcpkg list to a text file and updates the appveyor job and readme to use it. (Aaron Clauson) cd7b3b2 Updated appveyor config: - Update build image from Visual Studio 2017 to Visual Studio 2019. - Updated Qt static library from Qt5.9.7 to Qt5.9.8. - Added commands to update vcpkg port files (this does not update already installed packages). - Updated vcpkg package list as per bitcoin#17309. - Removed commands setting common project file options. Now done via common.init.vcxproj include. - Changed msbuild verbosity from normal to quiet. Normal rights a LOT of logs and impacts appveyor job duration. Updated msvc project configs: - Updated platform toolset from v141 to v142. - Updated Qt static library from Qt5.9.7 to Qt5.9.8. - Added ignore for linker warning building bitcoin-qt program. - Added missing util/str.cpp class file to test_bitcoin project file. (Aaron Clauson) 112144d Add missing typeinfo includes (Wladimir J. van der Laan) 1a6a534 net: Log to net category for exceptions in ProcessMessages (Wladimir J. van der Laan) c0dc728 test: fix bitcoind already running warnings on macOS (fanquake) 5276b0e util: Add missing headers to util/fees.cpp (Hennadii Stepanov) 4d7875c rpc: require second argument only for scantxoutset start action (Andrew Chow) bda2f5b cli: fix Fatal LevelDB error when specifying -blockfilterindex=basic twice (Harris) d14ab7c gui: disable File->CreateWallet during startup (fanquake) b9f1bc0 wallet: unbreak with boost 1.72 (Jan Beich) Pull request description: Backports the following PRs to the 0.19 branch: * bitcoin#17654 - Unbreak build with Boost 1.72.0 * bitcoin#17695 - gui: disable File->CreateWallet during startup * bitcoin#17687 - cli: fix Fatal LevelDB error when specifying -blockfilterindex=basic twice * bitcoin#17728 - rpc: require second argument only for scantxoutset start action * bitcoin#17450 - util: Add missing headers to util/fees.cpp * bitcoin#17488 - test: fix "bitcoind already running" warnings on macOS * bitcoin#17762 - Log to net category for exceptions in ProcessMessages * bitcoin#17364 - Updates to appveyor config for VS2019 and Qt5.9.8 + msvc project fixes * bitcoin#17416 - Appveyor improvement - text file for vcpkg package list * bitcoin#17736 - Update msvc build for Visual Studio 2019 v16.4 * bitcoin#17857 - scripts: fix symbol-check & security-check argument passing Fixes bitcoin#17856. ACKs for top commit: sipsorcery: ACK (tested: Windows 10 & msvc build) 99b5407. Tree-SHA512: 91313de56fb0825e70a4be30ba0bf561b8c26d7dcf60549185df4f5e3524099398c828bb46faae807b631634d1afd5a1d397fb41e61ecfa0d746e4bf10b923cb
Munkybooty
pushed a commit
to Munkybooty/dash
that referenced
this pull request
Dec 9, 2021
99b5407 scripts: fix check-symbols & check-security argument passing (fanquake) 4330a1e Update msvc build for Visual Studio 2019 v16.4 (Aaron Clauson) b0f9b8e Moves vcpkg list to a text file and updates the appveyor job and readme to use it. (Aaron Clauson) cd7b3b2 Updated appveyor config: - Update build image from Visual Studio 2017 to Visual Studio 2019. - Updated Qt static library from Qt5.9.7 to Qt5.9.8. - Added commands to update vcpkg port files (this does not update already installed packages). - Updated vcpkg package list as per bitcoin#17309. - Removed commands setting common project file options. Now done via common.init.vcxproj include. - Changed msbuild verbosity from normal to quiet. Normal rights a LOT of logs and impacts appveyor job duration. Updated msvc project configs: - Updated platform toolset from v141 to v142. - Updated Qt static library from Qt5.9.7 to Qt5.9.8. - Added ignore for linker warning building bitcoin-qt program. - Added missing util/str.cpp class file to test_bitcoin project file. (Aaron Clauson) 112144d Add missing typeinfo includes (Wladimir J. van der Laan) 1a6a534 net: Log to net category for exceptions in ProcessMessages (Wladimir J. van der Laan) c0dc728 test: fix bitcoind already running warnings on macOS (fanquake) 5276b0e util: Add missing headers to util/fees.cpp (Hennadii Stepanov) 4d7875c rpc: require second argument only for scantxoutset start action (Andrew Chow) bda2f5b cli: fix Fatal LevelDB error when specifying -blockfilterindex=basic twice (Harris) d14ab7c gui: disable File->CreateWallet during startup (fanquake) b9f1bc0 wallet: unbreak with boost 1.72 (Jan Beich) Pull request description: Backports the following PRs to the 0.19 branch: * bitcoin#17654 - Unbreak build with Boost 1.72.0 * bitcoin#17695 - gui: disable File->CreateWallet during startup * bitcoin#17687 - cli: fix Fatal LevelDB error when specifying -blockfilterindex=basic twice * bitcoin#17728 - rpc: require second argument only for scantxoutset start action * bitcoin#17450 - util: Add missing headers to util/fees.cpp * bitcoin#17488 - test: fix "bitcoind already running" warnings on macOS * bitcoin#17762 - Log to net category for exceptions in ProcessMessages * bitcoin#17364 - Updates to appveyor config for VS2019 and Qt5.9.8 + msvc project fixes * bitcoin#17416 - Appveyor improvement - text file for vcpkg package list * bitcoin#17736 - Update msvc build for Visual Studio 2019 v16.4 * bitcoin#17857 - scripts: fix symbol-check & security-check argument passing Fixes bitcoin#17856. ACKs for top commit: sipsorcery: ACK (tested: Windows 10 & msvc build) 99b5407. Tree-SHA512: 91313de56fb0825e70a4be30ba0bf561b8c26d7dcf60549185df4f5e3524099398c828bb46faae807b631634d1afd5a1d397fb41e61ecfa0d746e4bf10b923cb
Munkybooty
pushed a commit
to Munkybooty/dash
that referenced
this pull request
Dec 9, 2021
99b5407 scripts: fix check-symbols & check-security argument passing (fanquake) 4330a1e Update msvc build for Visual Studio 2019 v16.4 (Aaron Clauson) b0f9b8e Moves vcpkg list to a text file and updates the appveyor job and readme to use it. (Aaron Clauson) cd7b3b2 Updated appveyor config: - Update build image from Visual Studio 2017 to Visual Studio 2019. - Updated Qt static library from Qt5.9.7 to Qt5.9.8. - Added commands to update vcpkg port files (this does not update already installed packages). - Updated vcpkg package list as per bitcoin#17309. - Removed commands setting common project file options. Now done via common.init.vcxproj include. - Changed msbuild verbosity from normal to quiet. Normal rights a LOT of logs and impacts appveyor job duration. Updated msvc project configs: - Updated platform toolset from v141 to v142. - Updated Qt static library from Qt5.9.7 to Qt5.9.8. - Added ignore for linker warning building bitcoin-qt program. - Added missing util/str.cpp class file to test_bitcoin project file. (Aaron Clauson) 112144d Add missing typeinfo includes (Wladimir J. van der Laan) 1a6a534 net: Log to net category for exceptions in ProcessMessages (Wladimir J. van der Laan) c0dc728 test: fix bitcoind already running warnings on macOS (fanquake) 5276b0e util: Add missing headers to util/fees.cpp (Hennadii Stepanov) 4d7875c rpc: require second argument only for scantxoutset start action (Andrew Chow) bda2f5b cli: fix Fatal LevelDB error when specifying -blockfilterindex=basic twice (Harris) d14ab7c gui: disable File->CreateWallet during startup (fanquake) b9f1bc0 wallet: unbreak with boost 1.72 (Jan Beich) Pull request description: Backports the following PRs to the 0.19 branch: * bitcoin#17654 - Unbreak build with Boost 1.72.0 * bitcoin#17695 - gui: disable File->CreateWallet during startup * bitcoin#17687 - cli: fix Fatal LevelDB error when specifying -blockfilterindex=basic twice * bitcoin#17728 - rpc: require second argument only for scantxoutset start action * bitcoin#17450 - util: Add missing headers to util/fees.cpp * bitcoin#17488 - test: fix "bitcoind already running" warnings on macOS * bitcoin#17762 - Log to net category for exceptions in ProcessMessages * bitcoin#17364 - Updates to appveyor config for VS2019 and Qt5.9.8 + msvc project fixes * bitcoin#17416 - Appveyor improvement - text file for vcpkg package list * bitcoin#17736 - Update msvc build for Visual Studio 2019 v16.4 * bitcoin#17857 - scripts: fix symbol-check & security-check argument passing Fixes bitcoin#17856. ACKs for top commit: sipsorcery: ACK (tested: Windows 10 & msvc build) 99b5407. Tree-SHA512: 91313de56fb0825e70a4be30ba0bf561b8c26d7dcf60549185df4f5e3524099398c828bb46faae807b631634d1afd5a1d397fb41e61ecfa0d746e4bf10b923cb
Munkybooty
pushed a commit
to Munkybooty/dash
that referenced
this pull request
Dec 23, 2021
99b5407 scripts: fix check-symbols & check-security argument passing (fanquake) 4330a1e Update msvc build for Visual Studio 2019 v16.4 (Aaron Clauson) b0f9b8e Moves vcpkg list to a text file and updates the appveyor job and readme to use it. (Aaron Clauson) cd7b3b2 Updated appveyor config: - Update build image from Visual Studio 2017 to Visual Studio 2019. - Updated Qt static library from Qt5.9.7 to Qt5.9.8. - Added commands to update vcpkg port files (this does not update already installed packages). - Updated vcpkg package list as per bitcoin#17309. - Removed commands setting common project file options. Now done via common.init.vcxproj include. - Changed msbuild verbosity from normal to quiet. Normal rights a LOT of logs and impacts appveyor job duration. Updated msvc project configs: - Updated platform toolset from v141 to v142. - Updated Qt static library from Qt5.9.7 to Qt5.9.8. - Added ignore for linker warning building bitcoin-qt program. - Added missing util/str.cpp class file to test_bitcoin project file. (Aaron Clauson) 112144d Add missing typeinfo includes (Wladimir J. van der Laan) 1a6a534 net: Log to net category for exceptions in ProcessMessages (Wladimir J. van der Laan) c0dc728 test: fix bitcoind already running warnings on macOS (fanquake) 5276b0e util: Add missing headers to util/fees.cpp (Hennadii Stepanov) 4d7875c rpc: require second argument only for scantxoutset start action (Andrew Chow) bda2f5b cli: fix Fatal LevelDB error when specifying -blockfilterindex=basic twice (Harris) d14ab7c gui: disable File->CreateWallet during startup (fanquake) b9f1bc0 wallet: unbreak with boost 1.72 (Jan Beich) Pull request description: Backports the following PRs to the 0.19 branch: * bitcoin#17654 - Unbreak build with Boost 1.72.0 * bitcoin#17695 - gui: disable File->CreateWallet during startup * bitcoin#17687 - cli: fix Fatal LevelDB error when specifying -blockfilterindex=basic twice * bitcoin#17728 - rpc: require second argument only for scantxoutset start action * bitcoin#17450 - util: Add missing headers to util/fees.cpp * bitcoin#17488 - test: fix "bitcoind already running" warnings on macOS * bitcoin#17762 - Log to net category for exceptions in ProcessMessages * bitcoin#17364 - Updates to appveyor config for VS2019 and Qt5.9.8 + msvc project fixes * bitcoin#17416 - Appveyor improvement - text file for vcpkg package list * bitcoin#17736 - Update msvc build for Visual Studio 2019 v16.4 * bitcoin#17857 - scripts: fix symbol-check & security-check argument passing Fixes bitcoin#17856. ACKs for top commit: sipsorcery: ACK (tested: Windows 10 & msvc build) 99b5407. Tree-SHA512: 91313de56fb0825e70a4be30ba0bf561b8c26d7dcf60549185df4f5e3524099398c828bb46faae807b631634d1afd5a1d397fb41e61ecfa0d746e4bf10b923cb
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
msvc warning C4834 for the Bitcoin Core build was introduced by Visual Studio 16.4.0. This PR adds an ignore rule for the warning (it's related to the nodiscard attribute and is not considered relevant).
An additional side effect of the msvc compiler update is the prebuilt Qt5.9.8 libraries cannot be linked due to being built with an earlier version of the compiler. To fix this a new Qt5.9.8 version has been compiled and the appveyor job updated to use them.
The GitHub Actions job needs to continue to use the original Qt5.9.8 libraries until the latest GitHub Windows image also updates to >= Visual Studio 2019 v16.4.