Skip to content

Conversation

hebasto
Copy link
Member

@hebasto hebasto commented Nov 15, 2020

This is a workaround as the recent Visual Studio 2019 image update breaks our builds.

This PR is alternative to #20392 due to its build failure.

This is a workaround as the recent Visual Studio 2019 image update
breaks our builds.
@maflcko
Copy link
Member

maflcko commented Nov 15, 2020

review ACK 406097c also seems to pass

@maflcko maflcko merged commit fb7726e into bitcoin:master Nov 15, 2020
@hebasto hebasto deleted the 201115-appveyor branch November 15, 2020 09:08
@sipsorcery
Copy link
Contributor

Post merge ACK.

This will buy some time until the next Appveyor Visual Studio 2019 image bump. When that happens #20392 or another alternative will be required.

@hebasto
Copy link
Member Author

hebasto commented Nov 15, 2020

This will buy some time until the next Appveyor Visual Studio 2019 image bump. When that happens #20392 or another alternative will be required.

Is there a way to make #20392 build successfully? If so, I'd prefer it.

sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Nov 15, 2020
406097c ci: Use the previous build worker image in AppVeyor (Hennadii Stepanov)

Pull request description:

  This is a workaround as the [recent](https://www.appveyor.com/updates/2020/11/14/) Visual Studio 2019 image update breaks our builds.

  This PR is alternative to bitcoin#20392 due to its build [failure](https://ci.appveyor.com/project/DrahtBot/bitcoin/builds/36314660).

ACKs for top commit:
  MarcoFalke:
    review ACK 406097c also seems to pass

Tree-SHA512: f9b722d8e67dd7f0745de6da385064630adb27ecbc0a919be47f62217a2bb7a27a6fa00a7536a24bf17500a77160ca3b92b3c8619047171a6f5198b434015221
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Feb 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants