Set appveyor VM version to previous Visual Studio 2019 release #19839
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Latest vm version has updated cmake and the berkeleydb vcpkg now fails to build.
hebasto
approved these changes
Aug 30, 2020
There was a problem hiding this comment.
ACK 3ec8f4c, AppVeyor build is ok now.
Travis build fail is unrelated to this PR change.
Setting the Appveyor VM back to the previous version should fix the immediate issue while a solution is identified for updating the
berkeleydbbuild configuration.
Will you take care of this?
Yes. |
|
I assume this also needs to be backported to the 0.19 and 0.20 branches? Or, given they issue is less pressing there, will you backport the long-term fix to them instead? |
maflcko
pushed a commit
that referenced
this pull request
Aug 31, 2020
a104cae Update the vcpkg checkout commit ID in appveyor config. (Aaron Clauson) Pull request description: A recent appveyor vm update broke the build of the `berkeleydb` vcpkg dependency, see #19839. The temporary resolution was to switch back to the previous appveyor vm. This PR updates the pegged vcpkg commit ID to the most recent commit as of 31 Aug 2020. That commit ID has been tested against the latest appveyor vm and is able to build Bitcoin Core successfully. The vcpkg bump includes a [patch](microsoft/vcpkg#12870) to the `berkeleydb` build config which allows it to be built on the latest appveyor vm. ACKs for top commit: MarcoFalke: Concept ACK a104cae Tree-SHA512: 6d363d1615c51bb3d4b324eb96d53950648fc97fc81ffaef91ee6e92f1336776d150d89f6e859f354ee75ce66afcef07aa19ed39b725dbb3f47ba67d26e111db
laanwj
added a commit
that referenced
this pull request
Sep 24, 2020
498b7cb Update the vcpkg checkout commit ID in appveyor config. (Aaron Clauson) ad99777 Set appveyor vm version to previous Visual Studio 2019 release. (Aaron Clauson) Pull request description: Required for appveyor builds to succeed for other v0.20 backports. For example #19606 fails to build on appveyor without these commits, and succeeds with them. The first commit is actually reversed by the second commit (which also changes `VCPKG_COMMIT_ID`), but I'm backporting them both so that they're clean cherrypicks. ACKs for top commit: laanwj: ACK 498b7cb Tree-SHA512: 723a834fd86c8b5f58e71b9f1abfa8b3ad67376fab8e7d3699330142a6fde98547209b2b5fa6fdf9b934a447b29bf866e2258d0c303cec1062401e924e83f297
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Visual Studio 2019 Appveyor update includes a bump of
cmaketo3.18.2.The
berkeleydbdependency from the peggedvcpkgcommit now fails to build with thecmakeupdate.Setting the Appveyor VM back to the previous version should fix the immediate issue while a solution is identified for updating the
berkeleydbbuild configuration.