Updates to appveyor config for VS2019 and Qt5.9.8 + msvc project fixes #17364

sipsorcery · 2019-11-04T14:23:04Z

Updates to appveyor config:

Update build image from Visual Studio 2017 to Visual Studio 2019.
Updated Qt static library from Qt5.9.7 to Qt5.9.8.
Added commands to update vcpkg port files (this does not update already installed packages).
Updated vcpkg package list as per doc: update MSVC instructions to remove Qt OpenSSL linking #17309.
Removed commands setting common project file options. Now done via common.init.vcxproj include.
Changed msbuild verbosity from normal to quiet. Normal writes a LOT of logs and impacts appveyor job duration.

Updates to msvc project configs:

Updated platform toolset from v141 to v142.
Updated Qt static library from Qt5.9.7 to Qt5.9.8.
Added ignore for linker warning building bitcoin-qt program.
Added missing util/str.cpp class file to test_bitcoin project file.

In order for an existing appveyor job based on the new config to work the cache must be purged. The steps to do this are shown below. The specific appveyor project path will need to be adjusted.

export APPVEYOR_TOKEN="<your-api-token>"
curl -H "Authorization: Bearer $APPVEYOR_TOKEN" -X DELETE https://ci.appveyor.com/api/projects/bitcoin/bitcoin-9ql6k/buildcache

laanwj · 2019-11-04T14:25:32Z

Concept ACK

fanquake

Concept ACK - There's some related discussion in #17309 and these changes reflect that. i.e no longer needing OpenSSL as part of the Qt build and adding missing vcpkg packages.

.appveyor.yml

Sjors · 2019-11-04T16:17:40Z

Concept ACK. Works for me if it works for AppVeyor :-)

DrahtBot · 2019-11-04T17:46:08Z

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

#15382 (util: add runCommandParseJSON by Sjors)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

fanquake · 2019-11-04T20:07:13Z

.appveyor.yml

 # Disable zmq test for now since python zmq library on Windows would cause Access violation sometimes.
 # - cmd: pip install zmq
 - cmd: echo set(VCPKG_BUILD_TYPE release) >> C:\tools\vcpkg\triplets\%PLATFORM%-windows-static.cmake
+- cmd: cd c:\tools\vcpkg


You mentioned here that updating vcpkg for each build would likely be infeasible. Is that no-longer the case, or am I mis-understanding what this does?

I checked my statement by running the appveyor job with a pull of the vcpkg repo as mentioned in the articles you referenced and I was incorrect about the time it would take.

The reason being that updating and rebuilding the vcpkg program does not affect already installed packages. In my testing it only added about 2 minutes onto the build time. I wrongly assumed that updating vcpkg would invalidate the existing packages and force them to be re-installed.

For this PR the vcpkg source does have to be updated to get the latest port files otherwise the build fails (didn't track down why). After the first successful build thevcpkg update steps can be disabled to save the 2 minutes. It would need to be some kind of conditional disable so that anyone forking the repo still gets a working appveyor config. I can look into it if consensus is the small additional complexity justifies saving 2 minutes.

maflcko · 2019-11-04T21:19:54Z

This build took 1h14m. Other builds take typically between 33 min and 49 min. Are you sure caching has no effect on the run time?

sipsorcery · 2019-11-04T22:05:08Z

This build took 1h14m. Other builds take typically between 33 min and 49 min. Are you sure caching has no effect on the run time?

That does warrant some further investigation. I'll look into it further.

My build times performed sequentially were as below. They seemed fairly consistent even with appveyor's unpredictability. But given your results I'll see if maybe I missed something with clcache. It would certainly be nice to speed things up.

Disabled clcache
51 min 49 sec
53 min 46 sec
52 min 23 sec
53 min 16 sec
Failed after 47 min 38 sec
44 min 4 sec
44 min 2 sec

Enabled clcache
53 min 13 sec
52 min 26 sec
53 min 5 sec
54 min 45 sec
Failed after 46 min 26 sec
53 min 15 sec
52 min 34 sec
53 min 9 sec
53 min 54 sec

Disabled clcache
57 min 9 sec
Failed after 1 hr
59 min 25 sec
56 min 33 sec
54 min 55 sec

maflcko · 2019-11-05T23:19:08Z

Maybe clcache can be removed in a follow-up? Splitting the change into two commits would also help with review.

sipsorcery · 2019-11-06T10:21:13Z

@MarcoFalke D'accord. Have put back the clcache steps. Now the changes in this PR are focused on getting the msvc build working with VS2019 and Qt5.9.8.

- Update build image from Visual Studio 2017 to Visual Studio 2019. - Updated Qt static library from Qt5.9.7 to Qt5.9.8. - Added commands to update vcpkg port files (this does not update already installed packages). - Updated vcpkg package list as per bitcoin#17309. - Removed commands setting common project file options. Now done via common.init.vcxproj include. - Changed msbuild verbosity from normal to quiet. Normal rights a LOT of logs and impacts appveyor job duration. Updated msvc project configs: - Updated platform toolset from v141 to v142. - Updated Qt static library from Qt5.9.7 to Qt5.9.8. - Added ignore for linker warning building bitcoin-qt program. - Added missing util/str.cpp class file to test_bitcoin project file.

sipsorcery · 2019-11-07T08:21:08Z

@MarcoFalke the appveyor job will need to have the cache cleared before this PR will build successfully. The Curl command below shows how to do it. You'll need to replace the project URL.

All the appveyor builds are failing at the moment due to a new utility class being added to the test_bitcoin program. This PR fixes that.

export APPVEYOR_TOKEN="<your-api-token>"
curl -H "Authorization: Bearer $APPVEYOR_TOKEN" -X DELETE https://ci.appveyor.com/api/projects/sipsorcery/bitcoin-72c17/buildcache

ryanofsky

Non-expert code review ACK 3c84dee.

Options changes look as expected and few lines of shell code added seem to do what's described in comments. I haven't looked into details of how appveyor build works, so I probably wouldn't notice any bugs, but the configuration looks reasonable and is very well commented

@MarcoFalke the appveyor job will need to have the cache cleared before this PR will build successfully. The Curl command below shows how to do it. You'll need to replace the project URL.

Maybe we should have some permanent documentation that says how and when to run this command, if we don't already

maflcko · 2019-11-07T13:32:20Z

.appveyor.yml

+  QT_DOWNLOAD_URL: 'https://github.com/sipsorcery/qt_win_binary/releases/download/v1.4/Qt5.9.8_x64_static_vs2019.zip'
+  QT_DOWNLOAD_HASH: 'f285cbb02bec3b3f3cc2621e3fa7d5edf0d6a66fa30c57859e583acda954ea80'
+  QT_LOCAL_PATH: 'C:\Qt5.9.8_x64_static_vs2019'
+  VCPKG_INSTALL_PATH: 'C:\tools\vcpkg\installed'
 cache:
 - C:\tools\vcpkg\installed
 - C:\Users\appveyor\clcache -> .appveyor.yml, build_msvc\**, **\Makefile.am, **\*.vcxproj.in


Why is this cache not cleared?

https://www.appveyor.com/docs/build-cache/#cleaning-up-cache

maflcko · 2019-11-07T13:32:27Z

$ curl -H "Authorization: Bearer $APPVEYOR_TOKEN" -X DELETE https://ci.appveyor.com/api/projects/bitcoin/bitcoin-9ql6k/buildcache
{"message":"Account not found or access denied."}

DrahtBot · 2019-11-07T13:33:46Z

$ curl -H "Authorization: Bearer $APPVEYOR_TOKEN" -X DELETE https://ci.appveyor.com/api/projects/DrahtBot/bitcoin/buildcache && echo 'Done?'
Done?

sipsorcery · 2019-11-07T13:46:05Z

The cache purge worked. The appveyor job is now installing the vcpkg's from scratch. The first job will probably fail due to hitting the 1hr time limit. Installing the vcpkg's (~20mins) + build (~40mins) + test (~15mins) is now too long to do all at once. After the first attempt the vcpkg packages should be cached and subsequent job runs should work.

maflcko · 2019-11-07T13:54:01Z

Ok. Could you please update the OP to reflect the current state of this pull request?

sipsorcery · 2019-11-07T14:00:01Z

OP and title updated.

maflcko · 2019-11-07T14:55:46Z

Just wanted to note that this reverts 0646ca5, which now needs to be applied manually on failing builds

fanquake · 2019-11-07T15:44:32Z

post-merge ACK 3c84dee

I've just completed a qt build on Windows 10 with these changes:

Sjors · 2019-11-07T16:42:56Z

The commit message was incorrectly formatted:

commit 3c84deebaa311155ccc7565d09525041eed9747c
Author: Aaron Clauson <aaron@sipsorcery.com>
Date:   Wed Nov 6 22:02:16 2019 +0000

    Updated appveyor config:
     - Update build image from Visual Studio 2017 to Visual Studio 2019.

There should be a blank line after the description. Otherwise things like git rebase -i get confused (though not broken), e.g.:

pick 037f2405f2 Updated appveyor config:  - Update build image from Visual Studio 2017 to Visual Studio 2019.  - Updated Qt static library from Qt5.9.7 to Qt5.9.8.  - Added commands to update vcpkg port files (this does not update already installed packages).  - Updated vcpkg package list as per #17309.  - Removed commands setting common project file options. Now done via common.init.vcxproj include.  - Changed msbuild verbosity from normal to quiet. Normal rights a LOT of logs and impacts appveyor job duration. Updated msvc project configs:  - Updated platform toolset from v141 to v142.  - Updated Qt static library from Qt5.9.7 to Qt5.9.8.  - Added ignore for linker warning building bitcoin-qt program.  - Added missing util/str.cpp class file to test_bitcoin project file.
pick 8a5d0954a3 configure: add ax_boost_process
pick 25405cc429 [build] msvc: add boost::process

maflcko · 2019-11-07T17:14:03Z

A linter makes sense to catch these

maflcko · 2019-11-07T19:54:10Z

It looks like compile time is back at about 50 minutes (like before): https://ci.appveyor.com/project/DrahtBot/bitcoin/builds/28694137

Ok, this one is 57 minutes, but close enough.

…svc project b80f7db Remove redundant class file includes from test_bitcoin project. (Aaron Clauson) Pull request description: #17364 & #17384 overlapped and both added the same line of `..\..\src\test\util\*.cpp` to `test_bitcoin.vcxproj`. This didn't break the build but does result in duplicate symbol warnings. This PR cleans it up and removes the additional redundant line of `..\..\src\test\util\setup_common.cpp` which will also be covered by the wildcard include. ACKs for top commit: MarcoFalke: ACK b80f7db 🔅 fanquake: ACK b80f7db - tested a build on a Windows machine. No longer see the warnings shown below: Tree-SHA512: 55960821480483c517b475f2a6871cd7d4033d086db3fd679aa0de362e4f7e2c3ac7967ca278cc3728cc765ba23d4441ec769d83d7a47e7a3fa2f09de2bbc145

29eb039 Moves vcpkg list to a text file and updates the appveyor job and readme to use it. (Aaron Clauson) Pull request description: #17364 attempted to save a couple of minutes by skipping the `vcpkg` steps if the vcpkg install directory was already cached. The discussion in #15382 highlights the approach used in #17364 does not accommodate adding a new package. ~~This PR improves the approach to individually check whether each vcpg package is installed rather than checking for the existence of the vcpkg install directory.~~ This PR moves the list of required vcpkg packages into a separate file and uses changes to that file to invalidate the appveyor cache. Whenever the cache is invalidated the vcpkg sources will be updated, the vcpkg binary built and the required packages installed from the latest port files. ACKs for top commit: MarcoFalke: ACK 29eb039 Tree-SHA512: 0c2a170f4e4b47ca0f9cef14f1e3892001b441a6d84f50bf5fd8a26bc4cdbd9358dfce7ef180d37150262e849650e9857d6b2bcd686964b963c3de6cd708a2f3

- Update build image from Visual Studio 2017 to Visual Studio 2019. - Updated Qt static library from Qt5.9.7 to Qt5.9.8. - Added commands to update vcpkg port files (this does not update already installed packages). - Updated vcpkg package list as per bitcoin#17309. - Removed commands setting common project file options. Now done via common.init.vcxproj include. - Changed msbuild verbosity from normal to quiet. Normal rights a LOT of logs and impacts appveyor job duration. Updated msvc project configs: - Updated platform toolset from v141 to v142. - Updated Qt static library from Qt5.9.7 to Qt5.9.8. - Added ignore for linker warning building bitcoin-qt program. - Added missing util/str.cpp class file to test_bitcoin project file. Github-Pull: bitcoin#17364 Rebased-From: 3c84dee

99b5407 scripts: fix check-symbols & check-security argument passing (fanquake) 4330a1e Update msvc build for Visual Studio 2019 v16.4 (Aaron Clauson) b0f9b8e Moves vcpkg list to a text file and updates the appveyor job and readme to use it. (Aaron Clauson) cd7b3b2 Updated appveyor config: - Update build image from Visual Studio 2017 to Visual Studio 2019. - Updated Qt static library from Qt5.9.7 to Qt5.9.8. - Added commands to update vcpkg port files (this does not update already installed packages). - Updated vcpkg package list as per #17309. - Removed commands setting common project file options. Now done via common.init.vcxproj include. - Changed msbuild verbosity from normal to quiet. Normal rights a LOT of logs and impacts appveyor job duration. Updated msvc project configs: - Updated platform toolset from v141 to v142. - Updated Qt static library from Qt5.9.7 to Qt5.9.8. - Added ignore for linker warning building bitcoin-qt program. - Added missing util/str.cpp class file to test_bitcoin project file. (Aaron Clauson) 112144d Add missing typeinfo includes (Wladimir J. van der Laan) 1a6a534 net: Log to net category for exceptions in ProcessMessages (Wladimir J. van der Laan) c0dc728 test: fix bitcoind already running warnings on macOS (fanquake) 5276b0e util: Add missing headers to util/fees.cpp (Hennadii Stepanov) 4d7875c rpc: require second argument only for scantxoutset start action (Andrew Chow) bda2f5b cli: fix Fatal LevelDB error when specifying -blockfilterindex=basic twice (Harris) d14ab7c gui: disable File->CreateWallet during startup (fanquake) b9f1bc0 wallet: unbreak with boost 1.72 (Jan Beich) Pull request description: Backports the following PRs to the 0.19 branch: * #17654 - Unbreak build with Boost 1.72.0 * #17695 - gui: disable File->CreateWallet during startup * #17687 - cli: fix Fatal LevelDB error when specifying -blockfilterindex=basic twice * #17728 - rpc: require second argument only for scantxoutset start action * #17450 - util: Add missing headers to util/fees.cpp * #17488 - test: fix "bitcoind already running" warnings on macOS * #17762 - Log to net category for exceptions in ProcessMessages * #17364 - Updates to appveyor config for VS2019 and Qt5.9.8 + msvc project fixes * #17416 - Appveyor improvement - text file for vcpkg package list * #17736 - Update msvc build for Visual Studio 2019 v16.4 * #17857 - scripts: fix symbol-check & security-check argument passing Fixes #17856. ACKs for top commit: sipsorcery: ACK (tested: Windows 10 & msvc build) 99b5407. Tree-SHA512: 91313de56fb0825e70a4be30ba0bf561b8c26d7dcf60549185df4f5e3524099398c828bb46faae807b631634d1afd5a1d397fb41e61ecfa0d746e4bf10b923cb

[0.19] Backports bitcoin#17858 Unbreak build with Boost 1.72.0 bitcoin#17654 cli: fix Fatal LevelDB error when specifying -blockfilterindex=basic twice bitcoin#17687 rpc: require second argument only for scantxoutset start action bitcoin#17728 wallet: Fix origfee return for bumpfee with feerate arg bitcoin#17643 test: fix "bitcoind already running" warnings on macOS bitcoin#17488 net: Log to net category for exceptions in ProcessMessages bitcoin#17762 Updates to appveyor config for VS2019 and Qt5.9.8 + msvc project fixes bitcoin#17364 Appveyor improvement - text file for vcpkg package list bitcoin#17416 Update msvc build for Visual Studio 2019 v16.4 bitcoin#17736 scripts: fix symbol-check & security-check argument passing bitcoin#17857 qt: Periodic translations update for 0.19 branch IsUsedDestination should count any known single-key address bitcoin#17621 init: Stop indexes on shutdown after ChainStateFlushed callback. bitcoin#17897 qt: Translations update pre-rc1 wallet: Reset reused transactions cache bitcoin#17843 Squashed 'src/univalue/' changes from 7890db9..98261b1 0.19: Update univalue subtree bitcoin#18100 qt: Pre-rc2 translations update

[0.19] Backports bitcoin#17858 Unbreak build with Boost 1.72.0 bitcoin#17654 cli: fix Fatal LevelDB error when specifying -blockfilterindex=basic twice bitcoin#17687 rpc: require second argument only for scantxoutset start action bitcoin#17728 wallet: Fix origfee return for bumpfee with feerate arg bitcoin#17643 test: fix "bitcoind already running" warnings on macOS bitcoin#17488 net: Log to net category for exceptions in ProcessMessages bitcoin#17762 Updates to appveyor config for VS2019 and Qt5.9.8 + msvc project fixes bitcoin#17364 Appveyor improvement - text file for vcpkg package list bitcoin#17416 Update msvc build for Visual Studio 2019 v16.4 bitcoin#17736 scripts: fix symbol-check & security-check argument passing bitcoin#17857 qt: Periodic translations update for 0.19 branch IsUsedDestination should count any known single-key address bitcoin#17621 init: Stop indexes on shutdown after ChainStateFlushed callback. bitcoin#17897 qt: Translations update pre-rc1 wallet: Reset reused transactions cache bitcoin#17843 Squashed 'src/univalue/' changes from 7890db9..98261b1 0.19: Update univalue subtree bitcoin#18100 qt: Pre-rc2 translations update [0.19] Further 0.19 backports bitcoin#18218 build: don't embed a build-id when building libdmg-hfsplus bitcoin#18004

Summary: > This commit fixes build on CentOS 7 with GCC 4.8.5 > Also for std::swap() header <algorithm> is replaced with <utility> one. This is a backport of Core [[bitcoin/bitcoin#17364 | PR17364]] [1/2] bitcoin/bitcoin@b66861e Test Plan: `ninja` Reviewers: O1 Bitcoin ABC, #bitcoin_abc, Fabien Reviewed By: O1 Bitcoin ABC, #bitcoin_abc, Fabien Differential Revision: https://reviews.bitcoinabc.org/D8281

The platform toolset was updated from v141 to v142 in bitcoin#17364.

…utogen.py d1267fd build: Update default platform toolset in msvc-autogen.py (Hennadii Stepanov) Pull request description: The platform toolset was updated from v141 to v142 in bitcoin#17364. ACKs for top commit: sipsorcery: ACK d1267fd. Tree-SHA512: 390dc4876948af7f6b9f26eb1e64262f6386c2541a4647a6cb7abd8f1283c63ffbf5efba5e67a8075f0085a0557fc3f1b41e70f3ede0e8cef60d0fe2d6bf3be8

The platform toolset was updated from v141 to v142 in bitcoin#17364.

…utogen.py d1267fd build: Update default platform toolset in msvc-autogen.py (Hennadii Stepanov) Pull request description: The platform toolset was updated from v141 to v142 in bitcoin#17364. ACKs for top commit: sipsorcery: ACK d1267fd. Tree-SHA512: 390dc4876948af7f6b9f26eb1e64262f6386c2541a4647a6cb7abd8f1283c63ffbf5efba5e67a8075f0085a0557fc3f1b41e70f3ede0e8cef60d0fe2d6bf3be8

…ge list 29eb039 Moves vcpkg list to a text file and updates the appveyor job and readme to use it. (Aaron Clauson) Pull request description: bitcoin#17364 attempted to save a couple of minutes by skipping the `vcpkg` steps if the vcpkg install directory was already cached. The discussion in bitcoin#15382 highlights the approach used in bitcoin#17364 does not accommodate adding a new package. ~~This PR improves the approach to individually check whether each vcpg package is installed rather than checking for the existence of the vcpkg install directory.~~ This PR moves the list of required vcpkg packages into a separate file and uses changes to that file to invalidate the appveyor cache. Whenever the cache is invalidated the vcpkg sources will be updated, the vcpkg binary built and the required packages installed from the latest port files. ACKs for top commit: MarcoFalke: ACK 29eb039 Tree-SHA512: 0c2a170f4e4b47ca0f9cef14f1e3892001b441a6d84f50bf5fd8a26bc4cdbd9358dfce7ef180d37150262e849650e9857d6b2bcd686964b963c3de6cd708a2f3

99b5407 scripts: fix check-symbols & check-security argument passing (fanquake) 4330a1e Update msvc build for Visual Studio 2019 v16.4 (Aaron Clauson) b0f9b8e Moves vcpkg list to a text file and updates the appveyor job and readme to use it. (Aaron Clauson) cd7b3b2 Updated appveyor config: - Update build image from Visual Studio 2017 to Visual Studio 2019. - Updated Qt static library from Qt5.9.7 to Qt5.9.8. - Added commands to update vcpkg port files (this does not update already installed packages). - Updated vcpkg package list as per bitcoin#17309. - Removed commands setting common project file options. Now done via common.init.vcxproj include. - Changed msbuild verbosity from normal to quiet. Normal rights a LOT of logs and impacts appveyor job duration. Updated msvc project configs: - Updated platform toolset from v141 to v142. - Updated Qt static library from Qt5.9.7 to Qt5.9.8. - Added ignore for linker warning building bitcoin-qt program. - Added missing util/str.cpp class file to test_bitcoin project file. (Aaron Clauson) 112144d Add missing typeinfo includes (Wladimir J. van der Laan) 1a6a534 net: Log to net category for exceptions in ProcessMessages (Wladimir J. van der Laan) c0dc728 test: fix bitcoind already running warnings on macOS (fanquake) 5276b0e util: Add missing headers to util/fees.cpp (Hennadii Stepanov) 4d7875c rpc: require second argument only for scantxoutset start action (Andrew Chow) bda2f5b cli: fix Fatal LevelDB error when specifying -blockfilterindex=basic twice (Harris) d14ab7c gui: disable File->CreateWallet during startup (fanquake) b9f1bc0 wallet: unbreak with boost 1.72 (Jan Beich) Pull request description: Backports the following PRs to the 0.19 branch: * bitcoin#17654 - Unbreak build with Boost 1.72.0 * bitcoin#17695 - gui: disable File->CreateWallet during startup * bitcoin#17687 - cli: fix Fatal LevelDB error when specifying -blockfilterindex=basic twice * bitcoin#17728 - rpc: require second argument only for scantxoutset start action * bitcoin#17450 - util: Add missing headers to util/fees.cpp * bitcoin#17488 - test: fix "bitcoind already running" warnings on macOS * bitcoin#17762 - Log to net category for exceptions in ProcessMessages * bitcoin#17364 - Updates to appveyor config for VS2019 and Qt5.9.8 + msvc project fixes * bitcoin#17416 - Appveyor improvement - text file for vcpkg package list * bitcoin#17736 - Update msvc build for Visual Studio 2019 v16.4 * bitcoin#17857 - scripts: fix symbol-check & security-check argument passing Fixes bitcoin#17856. ACKs for top commit: sipsorcery: ACK (tested: Windows 10 & msvc build) 99b5407. Tree-SHA512: 91313de56fb0825e70a4be30ba0bf561b8c26d7dcf60549185df4f5e3524099398c828bb46faae807b631634d1afd5a1d397fb41e61ecfa0d746e4bf10b923cb

fanquake added the Windows label Nov 4, 2019

fanquake reviewed Nov 4, 2019

View reviewed changes

.appveyor.yml Outdated Show resolved Hide resolved

sipsorcery force-pushed the vs2019_oct31 branch from 4a8ecf1 to 394d674 Compare November 4, 2019 15:20

fanquake reviewed Nov 4, 2019

View reviewed changes

sipsorcery force-pushed the vs2019_oct31 branch 2 times, most recently from 961cc69 to 394d674 Compare November 5, 2019 16:01

sipsorcery closed this Nov 6, 2019

sipsorcery force-pushed the vs2019_oct31 branch from 394d674 to 7967104 Compare November 6, 2019 10:11

sipsorcery reopened this Nov 6, 2019

sipsorcery force-pushed the vs2019_oct31 branch 3 times, most recently from c9d6f40 to 11836a8 Compare November 6, 2019 21:39

sipsorcery force-pushed the vs2019_oct31 branch from 11836a8 to 3c84dee Compare November 6, 2019 22:03

ryanofsky approved these changes Nov 7, 2019

View reviewed changes

maflcko reviewed Nov 7, 2019

View reviewed changes

sipsorcery changed the title ~~Updated appveyor config for VS2019 and Qt5.9.8~~ Updates to appveyor config for VS2019 and Qt5.9.8 + msvc project fixes Nov 7, 2019

maflcko merged commit 3c84dee into bitcoin:master Nov 7, 2019

sipsorcery mentioned this pull request Nov 7, 2019

Remove redundant class file include from test_bitcoin msvc project #17404

Merged

sipsorcery deleted the vs2019_oct31 branch November 7, 2019 20:00

Sjors mentioned this pull request Nov 8, 2019

util: add RunCommandParseJSON #15382

Merged

1 task

sipsorcery mentioned this pull request Nov 8, 2019

Appveyor improvement - text file for vcpkg package list #17416

Merged

sipsorcery added a commit to sipsorcery/bitcoin that referenced this pull request Jan 5, 2020

Applied bitcoin#17364.

c214c70

fanquake mentioned this pull request Jan 6, 2020

[0.19] Backports #17858

Merged

MarkLTZ mentioned this pull request Apr 4, 2020

Bitcoin PR tracking litecoinz-core/litecoinz#14

Closed

hebasto added a commit to hebasto/bitcoin that referenced this pull request Sep 4, 2021

build: Update default platform toolset in msvc-autogen.py

d1267fd

The platform toolset was updated from v141 to v142 in bitcoin#17364.

hebasto mentioned this pull request Sep 4, 2021

build: Update default platform toolset in msvc-autogen.py #22888

Merged

arnabsen1729 pushed a commit to arnabsen1729/bitcoin that referenced this pull request Sep 6, 2021

build: Update default platform toolset in msvc-autogen.py

3741085

The platform toolset was updated from v141 to v142 in bitcoin#17364.

bitcoin locked as resolved and limited conversation to collaborators Dec 16, 2021

Updates to appveyor config for VS2019 and Qt5.9.8 + msvc project fixes #17364

Updates to appveyor config for VS2019 and Qt5.9.8 + msvc project fixes #17364

Uh oh!

Conversation

sipsorcery commented Nov 4, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

laanwj commented Nov 4, 2019

Uh oh!

fanquake left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Sjors commented Nov 4, 2019

Uh oh!

DrahtBot commented Nov 4, 2019

Conflicts

Uh oh!

fanquake Nov 4, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sipsorcery Nov 4, 2019

Choose a reason for hiding this comment

Uh oh!

maflcko commented Nov 4, 2019

Uh oh!

sipsorcery commented Nov 4, 2019

Uh oh!

maflcko commented Nov 5, 2019

Uh oh!

sipsorcery commented Nov 6, 2019

Uh oh!

sipsorcery commented Nov 7, 2019

Uh oh!

ryanofsky left a comment

Choose a reason for hiding this comment

Uh oh!

maflcko Nov 7, 2019

Choose a reason for hiding this comment

Uh oh!

maflcko commented Nov 7, 2019

Uh oh!

DrahtBot commented Nov 7, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sipsorcery commented Nov 7, 2019

Uh oh!

maflcko commented Nov 7, 2019

Uh oh!

sipsorcery commented Nov 7, 2019

Uh oh!

maflcko commented Nov 7, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fanquake commented Nov 7, 2019

Uh oh!

Sjors commented Nov 7, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

maflcko commented Nov 7, 2019

Uh oh!

maflcko commented Nov 7, 2019

Uh oh!

Uh oh!

sipsorcery commented Nov 4, 2019 •

edited

Loading

fanquake Nov 4, 2019 •

edited

Loading

DrahtBot commented Nov 7, 2019 •

edited

Loading

maflcko commented Nov 7, 2019 •

edited

Loading

Sjors commented Nov 7, 2019 •

edited

Loading