Skip to content

[only for test]*: Before/After #8582 #9131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 148 commits into from
Closed

[only for test]*: Before/After #8582 #9131

wants to merge 148 commits into from

Conversation

okJiang
Copy link
Member

@okJiang okJiang commented Mar 10, 2025

What problem does this PR solve?

Issue Number: Close #xxx

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

Release note

None.

rleungx and others added 30 commits November 1, 2024 10:21
@rleungx @ti-chi-bot
tests: add ms cluster case (tikv#8752)
60b960a 
ref tikv#8683

Signed-off-by: Ryan Leung <rleungx@gmail.com>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
@JmPotato
client/tso: add a TSO wait failed duration observer (tikv#8763)
5d32653 
ref tikv#8281

Add a TSO wait failed duration observer.

Signed-off-by: JmPotato <ghzpotato@gmail.com>
@baurine
chore(dashboard): update TiDB Dashboard to v8.5.0-bce95733 [master] (t…
cfd8f34 
…ikv#8764)

ref tikv#4257

Signed-off-by: baurine <2008.hbl@gmail.com>
@rleungx @ti-chi-bot
*: support configuring tso switch (tikv#8755)
b27f021 
close tikv#8477

Signed-off-by: Ryan Leung <rleungx@gmail.com>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
@lhy1024
cluster: fix tso fallback when pd leader switch (tikv#8783)
b19cec5 
close tikv#8781

Signed-off-by: lhy1024 <admin@liudos.us>
@okJiang @ti-chi-bot
test: add ut to test the input when creating evict-leader scheduler (t…
39575d2 
…ikv#8768)

ref tikv#4399

Signed-off-by: okJiang <819421878@qq.com>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
@rleungx @ti-chi-bot
tools: support setting float for qps (tikv#8787)
c9e532c 
ref tikv#5739

Signed-off-by: Ryan Leung <rleungx@gmail.com>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
@lhy1024
cluster: avoid unexpect scheduling job start (tikv#8794)
49307e2 
ref tikv#8781

Signed-off-by: lhy1024 <admin@liudos.us>
@lhy1024 @ti-chi-bot
scheduler: replace pauseLeader with two flags and add source filter t…
8bc9749 
…o transferIn (tikv#8623)

close tikv#8621

Signed-off-by: lhy1024 <admin@liudos.us>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
@okJiang @ti-chi-bot
*: remove unused code from participant.go (tikv#8782)
238d4d7 
ref tikv#4399

Signed-off-by: okJiang <819421878@qq.com>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
@JmPotato
client: genericize the batch controller (tikv#8793)
1265c8c 
ref tikv#8690

Genericize the batch controller for the later reuse.

Signed-off-by: JmPotato <ghzpotato@gmail.com>
@JmPotato
*: aggregate the utils package within the client (tikv#8799)
2637331 
ref tikv#8690

Aggregate the utils package within the client.

Signed-off-by: JmPotato <ghzpotato@gmail.com>
@Jackl9u @ti-chi-bot
store_command: propagate the error code to the root command (tikv#8798)
bb4c437 
ref tikv#8762

Signed-off-by: Boyang Lyu <boyangly@gmail.com>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
@rleungx
mcs: remove resource manager service (tikv#8804)
9415fdc 
close tikv#8805

Signed-off-by: Ryan Leung <rleungx@gmail.com>
@rleungx
tests: fix local id panic (tikv#8807)
f941078 
close tikv#8642

Signed-off-by: Ryan Leung <rleungx@gmail.com>
@JmPotato
*: remove the code of Local TSO from PD client (tikv#8803)
ac133d8 
ref tikv#8802

Remove the code of Local TSO from PD client.

Signed-off-by: JmPotato <ghzpotato@gmail.com>
@rleungx @ti-chi-bot
tests: fix TestRaftClusterMultipleRestart (tikv#8809)
2f9bf48 
close tikv#8801

Signed-off-by: Ryan Leung <rleungx@gmail.com>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
@rleungx @ti-chi-bot
tests: fix TestPreparingProgress (tikv#8808)
9e86404 
close tikv#8693

Signed-off-by: Ryan Leung <rleungx@gmail.com>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
@JmPotato
*: remove the Local TSO test cases (tikv#8810)
40ae26c 
ref tikv#8802

Remove the Local TSO test cases.

Signed-off-by: JmPotato <ghzpotato@gmail.com>
@JmPotato
*: independent the client option (tikv#8813)
71745a1 
ref tikv#8690

Independent the client option to reduce the number of files under the client root directory.

Signed-off-by: JmPotato <ghzpotato@gmail.com>
@JmPotato @ti-chi-bot
readme: remove the TSO consistency test status badge (tikv#8815)
c8c7551 
ref tikv#8802

Remove the TSO consistency test status badge.

Signed-off-by: JmPotato <ghzpotato@gmail.com>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
@lhy1024 @ti-chi-bot
*: reduce raft cluster lock and replace some place with atomic (tikv#…
1b4b21a 
…8786)

close tikv#8785

Signed-off-by: lhy1024 <admin@liudos.us>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
@lhy1024
*: remove store limit scene code (tikv#8819)
b6826c2 
close tikv#8818

Signed-off-by: lhy1024 <admin@liudos.us>
@rleungx @ti-chi-bot
*: fix TestWatcher (tikv#8812)
40fe83e 
close tikv#8549

Signed-off-by: Ryan Leung <rleungx@gmail.com>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
@JmPotato
client: split the meta storage client (tikv#8822)
36cc3f4 
ref tikv#8690

Split the meta storage client from the client definitions.

Signed-off-by: JmPotato <ghzpotato@gmail.com>
@okJiang @ti-chi-bot
test: remove duplicated code (tikv#8820)
76e3b43 
ref tikv#4399

Signed-off-by: okJiang <819421878@qq.com>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
@rleungx
syncer: exit watch leader immediately (tikv#8824)
41ec8dc 
close tikv#8823

Signed-off-by: Ryan Leung <rleungx@gmail.com>
@okJiang @ti-chi-bot
grpc: add caller info to client and wrap innerClient (tikv#8704)
0da1b11 
ref tikv#8593

Signed-off-by: okJiang <819421878@qq.com>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
@lhy1024
cluster: fix tso fallback due raft cluster did not stop tso service (t…
cdfdd52 
…ikv#8837)

close tikv#8836

Signed-off-by: lhy1024 <admin@liudos.us>
@okJiang @ti-chi-bot
scheduler: add test for creating evict-leader-scheduler twice (tikv#8757
90cc61b 
)

close tikv#8756

Signed-off-by: okJiang <819421878@qq.com>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
okJiang added 9 commits March 7, 2025 20:06
@okJiang
add testdata
a5b7e40 
Signed-off-by: okJiang <819421878@qq.com>
@okJiang
fix group 8
30b14df 
Signed-off-by: okJiang <819421878@qq.com>
@okJiang
fix group 1
ab9dbcf 
Signed-off-by: okJiang <819421878@qq.com>
@okJiang
add group3
035e7f9 
Signed-off-by: okJiang <819421878@qq.com>
@okJiang
remove empty line
3d78578 
Signed-off-by: okJiang <819421878@qq.com>
@okJiang
add group5
27fdca9 
Signed-off-by: okJiang <819421878@qq.com>
@okJiang
add group4
b432211 
Signed-off-by: okJiang <819421878@qq.com>
@okJiang
update etcdkey file name
3550697 
Signed-off-by: okJiang <819421878@qq.com>
@okJiang
Merge branch '8.5-etcd-test' into before-tikv#8582
af0c504
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Mar 10, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Mar 10, 2025

This cherry pick PR is for a release branch and has not yet been approved by triage owners.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick:

  1. It must be approved by the approvers firstly.
  2. AFTER it has been approved by approvers, please wait for the cherry-pick merging approval from triage owners.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/cherry-pick-not-approved dco-signoff: yes Indicates the PR's author has signed the dco. labels Mar 10, 2025
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Mar 10, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign niubell, rleungx for approval, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Mar 10, 2025
@okJiang
fix conflict
8626b21 
Signed-off-by: okJiang <819421878@qq.com>
@okJiang
Copy link
Member Author

okJiang commented Mar 10, 2025

/retest

@codecov Codecov
Copy link

codecov bot commented Mar 10, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 81.20325% with 578 lines in your changes missing coverage. Please review.

Project coverage is 76.32%. Comparing base (2da8160) to head (91314f7).

Additional details and impacted files 
@@               Coverage Diff               @@
##           release-8.5    #9131      +/-   ##
===============================================
+ Coverage        75.58%   76.32%   +0.73%     
===============================================
  Files              462      473      +11     
  Lines            72389    71706     -683     
===============================================
+ Hits             54715    54729      +14     
+ Misses           14176    13557     -619     
+ Partials          3498     3420      -78
Flag Coverage Δ
unittests 76.32% <81.20%> (+0.73%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

okJiang and others added 2 commits March 10, 2025 18:32
@okJiang
add before testdata
898e55e 
Signed-off-by: okJiang <819421878@qq.com>
@okJiang @ti-chi-bot
keypath: remove rootPath from storage and change all paths to absolut…
ca7abaa 
…e path (tikv#8919)

close tikv#8582

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Signed-off-by: okJiang <819421878@qq.com>
@okJiang okJiang changed the title [only for test]*: Before #8582 [only for test]*: Before/After #8582 Mar 10, 2025
okJiang added 3 commits March 11, 2025 14:30
@okJiang
fix registry/prefix/safe_point/scheduler_config key
91314f7 
Signed-off-by: okJiang <819421878@qq.com>
@okJiang
add testdata after-8582
0d669c0 
Signed-off-by: okJiang <819421878@qq.com>
@okJiang
add testdata after fix 8582
8f88fc6 
Signed-off-by: okJiang <819421878@qq.com>
This was referenced Mar 11, 2025
Closed
Merged
@ti-chi-bot ti-chi-bot mentioned this pull request Mar 12, 2025
Merged
@okJiang okJiang closed this Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dco-signoff: yes Indicates the PR's author has signed the dco. do-not-merge/cherry-pick-not-approved do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.