Skip to content

cluster: fix tso fallback due raft cluster did not stop tso service #8837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 21, 2024
Merged

cluster: fix tso fallback due raft cluster did not stop tso service #8837

merged 2 commits into from
Nov 21, 2024

Conversation

lhy1024
Copy link
Contributor

@lhy1024 lhy1024 commented Nov 21, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: Close #8836 ref #8477

What is changed and how does it work?

Check List

Tests

  • Unit test

Release note

None.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 21, 2024
@lhy1024
Copy link
Contributor Author

lhy1024 commented Nov 21, 2024

/check-issue-triage-complete

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 21, 2024
@lhy1024
make test stable
8d87f83 
Signed-off-by: lhy1024 <admin@liudos.us>
@codecov Codecov
Copy link

codecov bot commented Nov 21, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 72.72727% with 3 lines in your changes missing coverage. Please review.

Project coverage is 75.21%. Comparing base (76e3b43) to head (8d87f83).
Report is 3 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #8837      +/-   ##
==========================================
- Coverage   75.24%   75.21%   -0.03%     
==========================================
  Files         456      458       +2     
  Lines       71608    71690      +82     
==========================================
+ Hits        53884    53925      +41     
- Misses      14295    14323      +28     
- Partials     3429     3442      +13
Flag Coverage Δ
unittests 75.21% <72.72%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

---- 🚨 Try these New Features:

@ti-chi-bot ti-chi-bot bot added the lgtm label Nov 21, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: okJiang, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 21, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 21, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-21 07:30:09.916441826 +0000 UTC m=+103197.536096327: ☑️ agreed by okJiang.
  • 2024-11-21 07:59:25.18968469 +0000 UTC m=+104952.809339206: ☑️ agreed by rleungx.

@ti-chi-bot ti-chi-bot bot merged commit cdfdd52 into tikv:master Nov 21, 2024
24 of 25 checks passed
@lhy1024 lhy1024 deleted the fix-tso-job2 branch November 21, 2024 08:03
@lhy1024 lhy1024 added the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Nov 21, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #8838.

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 21, 2024
Merged
ti-chi-bot bot pushed a commit that referenced this pull request Nov 21, 2024
@ti-chi-bot @lhy1024
cluster: fix tso fallback due raft cluster did not stop tso service (#…
3994172 
…8837) (#8838)

close #8836

Signed-off-by: lhy1024 <admin@liudos.us>

Co-authored-by: lhy1024 <admin@liudos.us>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rleungx rleungx rleungx approved these changes

+1 more reviewer

@okJiang okJiang okJiang approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pd client panics with "[tso] timestamp fallback"
4 participants
@lhy1024 @ti-chi-bot @okJiang @rleungx