Skip to content

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Nov 12, 2024

What problem does this PR solve?

Issue Number: Close #8805

What is changed and how does it work?

Check List

Tests

  • Unit test

Release note

None.

Signed-off-by: Ryan Leung <rleungx@gmail.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue dco-signoff: yes Indicates the PR's author has signed the dco. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed do-not-merge/needs-linked-issue labels Nov 12, 2024
@rleungx rleungx requested review from JmPotato and lhy1024 November 12, 2024 08:47
Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.71%. Comparing base (2637331) to head (b48ab5e).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8804      +/-   ##
==========================================
- Coverage   75.80%   75.71%   -0.10%     
==========================================
  Files         461      459       -2     
  Lines       72315    72004     -311     
==========================================
- Hits        54817    54515     -302     
- Misses      14000    14001       +1     
+ Partials     3498     3488      -10     
Flag Coverage Δ
unittests 75.71% <100.00%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Nov 12, 2024
@ti-chi-bot ti-chi-bot bot added the lgtm label Nov 12, 2024
Copy link
Contributor

ti-chi-bot bot commented Nov 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lhy1024, nolouch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 12, 2024
Copy link
Contributor

ti-chi-bot bot commented Nov 12, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-12 09:02:39.842731161 +0000 UTC m=+346922.033600157: ☑️ agreed by lhy1024.
  • 2024-11-12 09:30:06.150439748 +0000 UTC m=+348568.341308745: ☑️ agreed by nolouch.

@ti-chi-bot ti-chi-bot bot merged commit 9415fdc into tikv:master Nov 12, 2024
26 checks passed
@rleungx rleungx deleted the remove-resource-manager-service branch November 12, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove all resource manager service code
3 participants