Skip to content

Conversation

okJiang
Copy link
Member

@okJiang okJiang commented Nov 7, 2024

What problem does this PR solve?

Issue Number: Ref #4399

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test

Release note

None.

Signed-off-by: okJiang <819421878@qq.com>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 7, 2024
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.62%. Comparing base (8bc9749) to head (6c6ebd4).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8782      +/-   ##
==========================================
- Coverage   75.62%   75.62%   -0.01%     
==========================================
  Files         461      461              
  Lines       72351    72300      -51     
==========================================
- Hits        54719    54679      -40     
+ Misses      14134    14117      -17     
- Partials     3498     3504       +6     
Flag Coverage Δ
unittests 75.62% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@okJiang
Copy link
Member Author

okJiang commented Nov 7, 2024

/retest

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Nov 7, 2024
@okJiang okJiang changed the title *: remove unused code from participant.go *: remove unused code from participant.go Nov 7, 2024
@ti-chi-bot ti-chi-bot bot added the lgtm label Nov 11, 2024
Copy link
Contributor

ti-chi-bot bot commented Nov 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JmPotato, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 11, 2024
Copy link
Contributor

ti-chi-bot bot commented Nov 11, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-07 05:50:11.742427682 +0000 UTC m=+1106524.581583234: ☑️ agreed by rleungx.
  • 2024-11-11 07:22:35.639399687 +0000 UTC m=+254517.830268683: ☑️ agreed by JmPotato.

@ti-chi-bot ti-chi-bot bot merged commit 238d4d7 into tikv:master Nov 11, 2024
25 checks passed
@okJiang okJiang deleted the remove-unused-code branch November 11, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants