Skip to content

Conversation

LykxSassinator
Copy link
Contributor

@LykxSassinator LykxSassinator commented Jan 13, 2025

What problem does this PR solve?

Issue Number: Close #9001, Ref tikv/tikv#18107, Ref tikv/tikv#18042

What is changed and how does it work?

This PR mainly contains the cooperative works on mitigating the performance impacts when scaling.

In this PR, it returns the NodeState in StoreHeartbeatResponse to store nodes,
to notify the corresponsive store to handle it if necessary.

In this PR, it returns the `NodeState` in `StoreHeartbeatResponse` to store nodes,
to notify the corresponsive store to handle it if necessary.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

Release note

None.

Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
Copy link
Contributor

ti-chi-bot bot commented Jan 13, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates the PR's author has signed the dco. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 13, 2025
Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
@LykxSassinator LykxSassinator marked this pull request as ready for review January 16, 2025 03:25
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 16, 2025
@LykxSassinator
Copy link
Contributor Author

/retest

Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
@ti-chi-bot ti-chi-bot bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 16, 2025
Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 16, 2025
@LykxSassinator
Copy link
Contributor Author

/cc @bufferflies @rleungx

@ti-chi-bot ti-chi-bot bot requested review from bufferflies and rleungx January 16, 2025 03:40
Copy link
Contributor

@lhy1024 lhy1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But we also need to update go mod before merge PR

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jan 16, 2025
Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
@ti-chi-bot ti-chi-bot bot removed the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 16, 2025
@ti-chi-bot ti-chi-bot bot requested a review from rleungx January 17, 2025 02:55
@rleungx
Copy link
Member

rleungx commented Jan 17, 2025

/hold cancel

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 17, 2025
@ti-chi-bot ti-chi-bot bot merged commit 9805a95 into tikv:master Jan 17, 2025
25 checks passed
@LykxSassinator
Copy link
Contributor Author

/type cherry-pick-for-release-7.5

@ti-chi-bot ti-chi-bot bot added the type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. label May 26, 2025
@LykxSassinator
Copy link
Contributor Author

/label needs-cherry-pick-release-7.5

@ti-chi-bot ti-chi-bot bot added the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label May 26, 2025
@LykxSassinator
Copy link
Contributor Author

/unlabel type/cherry-pick-for-release-7.5

@LykxSassinator
Copy link
Contributor Author

/untype cherry-pick-for-release-7.5

@LykxSassinator
Copy link
Contributor Author

/remove cherry-pick-for-release-7.5

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request May 26, 2025
close tikv#9001, ref tikv/tikv#18042, ref tikv/tikv#18107

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #9349.
But this PR has conflicts, please resolve them!

@LykxSassinator
Copy link
Contributor Author

/remove label cherry-pick-for-release-7.5

LykxSassinator added a commit to LykxSassinator/pd that referenced this pull request May 26, 2025
…at. (tikv#8991)

Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
@ti-chi-bot ti-chi-bot bot added the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Jul 2, 2025
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Jul 2, 2025
close tikv#9001, ref tikv/tikv#18042, ref tikv/tikv#18107

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #9476.
But this PR has conflicts, please resolve them!

ti-chi-bot bot pushed a commit that referenced this pull request Jul 4, 2025
…at. (#8991) (#9353)

close #9001, ref tikv/tikv#18042, ref tikv/tikv#18107

In this PR, it returns the `NodeState` in `StoreHeartbeatResponse` to store nodes,
to notify the corresponsive store to handle it if necessary.

Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
LykxSassinator added a commit to LykxSassinator/pd that referenced this pull request Jul 7, 2025
…at. (tikv#8991)

Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
ti-chi-bot bot pushed a commit that referenced this pull request Jul 7, 2025
…at. (#8991) (#9498)

close #9001, ref tikv/tikv#18042, ref tikv/tikv#18107

In this PR, it returns the `NodeState` in `StoreHeartbeatResponse` to store nodes,
to notify the corresponsive store to handle it if necessary.

Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
@ti-chi-bot ti-chi-bot bot added the needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. label Jul 8, 2025
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #9502.
But this PR has conflicts, please resolve them!

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Jul 8, 2025
close tikv#9001, ref tikv/tikv#18042, ref tikv/tikv#18107

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

store_heartbeat: returns NodeState in the response to store.
5 participants