Skip to content

[CP-to-7.5] cluster: return NodeState in the response of StoreHeartbeat. (#8991) #9353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 4, 2025
Merged

[CP-to-7.5] cluster: return NodeState in the response of StoreHeartbeat. (#8991) #9353

merged 3 commits into from
Jul 4, 2025

Conversation

LykxSassinator
Copy link
Contributor

This is a manual cherry-pick of #8991

What problem does this PR solve?

Issue Number: Close #9001, Ref tikv/tikv#18107, Ref tikv/tikv#18042

What is changed and how does it work?

This PR mainly contains the cooperative works on mitigating the performance impacts when scaling.

In this PR, it returns the `NodeState` in `StoreHeartbeatResponse` to store nodes,
to notify the corresponsive store to handle it if necessary.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

Release note

None.

@LykxSassinator
[CP-to-7.5] cluster: return NodeState in the response of StoreHeartbe…
d8e817f 
…at. (tikv#8991)

Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. labels May 26, 2025
@LykxSassinator LykxSassinator mentioned this pull request May 26, 2025
Closed
@ti-chi-bot ti-chi-bot bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 26, 2025
@LykxSassinator
Copy link
Contributor Author

/type cherry-pick-for-release-7.5

@ti-chi-bot ti-chi-bot bot added the type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. label May 26, 2025
@LykxSassinator
Fix lint errs.
c8326b0 
Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 26, 2025
@LykxSassinator
Copy link
Contributor Author

/retest

@LykxSassinator
Fix lint.
e663d41 
Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 26, 2025
@LykxSassinator
Copy link
Contributor Author

/retest

1 similar comment
@LykxSassinator
Copy link
Contributor Author

/retest

@LykxSassinator
Copy link
Contributor Author

/test

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 6, 2025

@LykxSassinator: The /test command needs one or more targets.
The following commands are available to trigger required jobs:

/test build

/test integration-copr-test

Use /test all to run the following jobs that were automatically triggered:

tikv/pd/release-7.5/ghpr_build

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@LykxSassinator
Copy link
Contributor Author

/retest

@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Jul 3, 2025
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jul 4, 2025
@ti-chi-bot ti-chi-bot bot added the lgtm label Jul 4, 2025
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 4, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bufferflies, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [bufferflies,rleungx]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jul 4, 2025
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 4, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-07-04 03:18:54.841884858 +0000 UTC m=+1624187.565063832: ☑️ agreed by rleungx.
  • 2025-07-04 03:59:39.792774662 +0000 UTC m=+1626632.515953669: ☑️ agreed by bufferflies.

@ti-chi-bot ti-chi-bot bot merged commit 79fa2e8 into tikv:release-7.5 Jul 4, 2025
44 of 64 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bufferflies bufferflies bufferflies approved these changes

@rleungx rleungx rleungx approved these changes

Assignees
No one assigned
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LykxSassinator @bufferflies @rleungx