[cp-to-8.5] cluster: return NodeState in the response of StoreHeartbeat. (#8991) #9498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…at. (tikv#8991) Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
|
/cc @rleungx @bufferflies PTAL, thx |
rleungx
approved these changes
Jul 7, 2025
bufferflies
approved these changes
Jul 7, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bufferflies, rleungx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-8.5 #9498 +/- ##
===============================================
- Coverage 75.62% 75.54% -0.08%
===============================================
Files 463 463
Lines 72470 72471 +1
===============================================
- Hits 54806 54751 -55
- Misses 14166 14210 +44
- Partials 3498 3510 +12
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
/check-cherry-pick-approved |
|
/cherry-pick-approved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a manual cherry-pick of #8991
What problem does this PR solve?
Issue Number: Close #9001, Ref tikv/tikv#18107, Ref tikv/tikv#18042
What is changed and how does it work?
This PR mainly contains the cooperative works on mitigating the performance impacts when scaling.
In this PR, it returns the NodeState in StoreHeartbeatResponse to store nodes,
to notify the corresponsive store to handle it if necessary.
Check List
Tests
Code changes
Side effects
Related changes
pingcap/docs/pingcap/docs-cn:pingcap/tiup:Release note