Fix `no-invalid-position-declaration` false positives for embedded styles #8701

sw1tch3roo · 2025-08-01T18:39:06Z

Which issue, if any, is this issue related to?

Closes #8695

Is there anything in the PR that needs further explanation?

No, it's self-explanatory.

…yles

changeset-bot · 2025-08-01T18:39:09Z

🦋 Changeset detected

Latest commit: fc67a96

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
stylelint	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

sw1tch3roo · 2025-08-01T18:40:16Z

inspired by #8697.
@reduckted @jeddy3 guys, what do you think about this?

github-actions · 2025-08-01T18:41:02Z

This PR is packaged and the instant preview is available (fc67a96). View the demo website.

Install it locally:

npm i -D https://pkg.pr.new/stylelint@fc67a96

reduckted · 2025-08-02T07:05:23Z

Is it worth adding an accept test case for <style>--custom-property: blue;</style> to show that the rule will produce a false negative for check style elements?

sw1tch3roo · 2025-08-02T07:48:52Z

@reduckted Thank you for your suggestion, IMO it would be worth.

<style>--custom-property: blue;</style>

this way we ensure that the fix won't be repeated in future changes.

jeddy3

@sw1tch3roo Thank you for continuing to work on a fix.

I've requested some changes and asked a question.

.changeset/yummy-streets-cheat.md

lib/rules/no-invalid-position-declaration/__tests__/index.mjs

lib/utils/typeGuards.mjs

package.json

jeddy3

Thank you for making the changes. LGTM.

romainmenke

Overal change looks good! Thank you
I've left a few suggestions, please take a look when you have time 🙇

lib/rules/no-invalid-position-declaration/index.mjs

romainmenke

(this comment went missing in the first review)

lib/utils/typeGuards.mjs

lib/rules/no-invalid-position-declaration/__tests__/index.mjs

lib/utils/typeGuards.mjs

…-attribute

…nt property

ybiquitous

@sw1tch3roo Thanks for addressing my reviews.

Overall LGTM, but let me suggest the last refactoring in isInDocument(). I believe using instanceof Node is a bit safer and straightforward than type casting with @type.

lib/utils/isInDocument.mjs

sw1tch3roo · 2025-08-06T09:49:43Z

@sw1tch3roo Thanks for addressing my reviews.

Overall LGTM, but let me suggest the last refactoring in isInDocument(). I believe using instanceof Node is a bit safer and straightforward than type casting with @type.

it's a good catch, thanks

ybiquitous

Thank you, LGTM 👍🏼

ybiquitous · 2025-08-06T13:17:20Z

@jeddy3 may want one more review since commits were added after his approval.

jeddy3

LGTM, thank you!

(And thanks for catching all the things I missed in my first review 😅)

@sw1tch3roo

| datasource | package | from | to | | ---------- | --------- | ------- | ------- | | npm | stylelint | 16.20.0 | 16.23.1 | ## [v16.23.1](https://github.com/stylelint/stylelint/blob/HEAD/CHANGELOG.md#16231---2025-08-07) It fixes 7 bugs. - Fixed: `no-invalid-position-declaration` false positives for embedded styles ([#8701](stylelint/stylelint#8701)) ([@sw1tch3roo](https://github.com/sw1tch3roo)). - Fixed: `property-no-deprecated` erroneously autofixing `clip` ([#8699](stylelint/stylelint#8699)) ([@immitsu](https://github.com/immitsu)). - Fixed: `property-no-deprecated` false positives for `-webkit-box-orient: vertical;` ([#8699](stylelint/stylelint#8699)) ([@immitsu](https://github.com/immitsu)). - Fixed: `selector-pseudo-*-no-unknown` false positives for some meter pseudo classes/elements ([#8708](stylelint/stylelint#8708)) ([@Mouvedia](https://github.com/Mouvedia)). - Fixed: `selector-pseudo-class-no-unknown` false positives for `:unchecked` ([#8705](stylelint/stylelint#8705)) ([@Mouvedia](https://github.com/Mouvedia)). - Fixed: `selector-pseudo-element-no-unknown` false positives for `::search-text` ([#8707](stylelint/stylelint#8707)) ([@Mouvedia](https://github.com/Mouvedia)). - Fixed: `selector-type-no-unknown` false positives for `selectedcontent` ([#8716](stylelint/stylelint#8716)) ([@Mouvedia](https://github.com/Mouvedia)). ## [v16.23.0](https://github.com/stylelint/stylelint/blob/HEAD/CHANGELOG.md#16230---2025-07-29) It adds 5 new rules, 1 option to a rule and fixes 3 bugs. We've turned on the new rules in our [standard config](https://www.npmjs.com/package/stylelint-config-standard). - Added: `block-no-redundant-nested-style-rules` rule ([#8684](stylelint/stylelint#8684)) ([@sw1tch3roo](https://github.com/sw1tch3roo)). - Added: `media-type-no-deprecated` rule ([#8668](stylelint/stylelint#8668)) ([@immitsu](https://github.com/immitsu)). - Added: `nesting-selector-no-missing-scoping-root` rule ([#8674](stylelint/stylelint#8674)) ([@sw1tch3roo](https://github.com/sw1tch3roo)). - Added: `no-invalid-position-declaration` rule ([#8669](stylelint/stylelint#8669)) ([@sw1tch3roo](https://github.com/sw1tch3roo)). - Added: `property-no-deprecated` rule ([#8682](stylelint/stylelint#8682)) ([@immitsu](https://github.com/immitsu)). - Added: `except: ["exact-value"]` to `media-feature-range-notation` ([#8675](stylelint/stylelint#8675)) ([@immitsu](https://github.com/immitsu)). - Fixed: `declaration-block-no-duplicate-properties` false negatives for named colors with `ignore: ['consecutive-duplicates-with-different-syntaxes']` ([#8665](stylelint/stylelint#8665)) ([@sw1tch3roo](https://github.com/sw1tch3roo)). - Fixed: `function-no-unknown` false positives ([#8677](stylelint/stylelint#8677)) ([@Mouvedia](https://github.com/Mouvedia)). - Fixed: `no-irregular-whitespace` false positives for strings ([#8667](stylelint/stylelint#8667)) ([@immitsu](https://github.com/immitsu)). ## [v16.22.0](https://github.com/stylelint/stylelint/blob/HEAD/CHANGELOG.md#16220---2025-07-18) It adds 3 rule features and fixes 2 bugs. - Added: `messageArgs` to `color-named` ([#8663](stylelint/stylelint#8663)) ([@Mouvedia](https://github.com/Mouvedia)). - Added: `messageArgs` to `declaration-property-value-keyword-no-deprecated` ([#8654](stylelint/stylelint#8654)) ([@Mouvedia](https://github.com/Mouvedia)). - Added: `no-descending-specificity` report message includes line number of the anchoring selector ([#8666](stylelint/stylelint#8666)) ([@immitsu](https://github.com/immitsu)). - Fixed: `at-rule-no-deprecated` false positives for `@apply` ([#8630](stylelint/stylelint#8630)) ([@Mouvedia](https://github.com/Mouvedia)). - Fixed: `lightness-notation` crash with `"number"` option and single-digit percentage ([#8661](stylelint/stylelint#8661)) ([@ybiquitous](https://github.com/ybiquitous)). ## [v16.21.1](https://github.com/stylelint/stylelint/blob/HEAD/CHANGELOG.md#16211---2025-07-03) It fixes 3 bugs. - Fixed: unexpected change of syntax in computed `EditInfo` ([#8638](stylelint/stylelint#8638)) ([@romainmenke](https://github.com/romainmenke)). - Fixed: `function-linear-gradient-no-nonstandard-direction` false positives for CSS variables' names containing a direction substring ([#8643](stylelint/stylelint#8643)) ([@Solomon-mithra](https://github.com/Solomon-mithra)). - Fixed: `media-feature-range-notation` autofix for exact values ([#8651](stylelint/stylelint#8651)) ([@romainmenke](https://github.com/romainmenke)). ## [v16.21.0](https://github.com/stylelint/stylelint/blob/HEAD/CHANGELOG.md#16210---2025-06-19) It rounds out the `message` secondary option and marks it as stable, adds 1 new option to a rule, and fixes 4 bugs. - Added: non-experimental support for functional `message` secondary option ([#8595](stylelint/stylelint#8595)) ([@ybiquitous](https://github.com/ybiquitous)). - Added: `ignore: ["after-custom-property"]` to `custom-property-empty-line-before` ([#8627](stylelint/stylelint#8627)) ([@imkesin](https://github.com/imkesin)). - Fixed: `cache` configuration property not being respected ([#8599](stylelint/stylelint#8599)) ([@ybiquitous](https://github.com/ybiquitous)). - Fixed: `fastest-levenshtein` import when bundling ([#8621](stylelint/stylelint#8621)) ([@onigoetz](https://github.com/onigoetz)). - Fixed: `named-grid-areas-no-invalid` false positives for interpolated grid-template-areas in CSS-in-JS ([#8606](stylelint/stylelint#8606)) ([@shahana308](https://github.com/shahana308)). - Fixed: `selector-pseudo-*-no-unknown` false positives for the missing form control styling selectors ([#8623](stylelint/stylelint#8623)) ([@tyrann0us](https://github.com/tyrann0us)).

fix no-invalid-position-declaration false positives for embedded st…

d04247d

…yles

Add accept test case for <style>--custom-property: blue;</style>

556584f

reduckted mentioned this pull request Aug 2, 2025

Fix no-invalid-position-declaration false positives for embedded styles #8697

Closed

jeddy3 requested changes Aug 3, 2025

View reviewed changes

jeddy3 changed the title ~~fix no-invalid-position-declaration false positives for embedded styles~~ Fix no-invalid-position-declaration false positives for embedded styles Aug 3, 2025

jeddy3 mentioned this pull request Aug 3, 2025

Unexpected invalid position declaration false positive for Vue template #8703

Closed

changes after review

1da579e

sw1tch3roo requested a review from jeddy3 August 3, 2025 22:04

jeddy3 approved these changes Aug 4, 2025

View reviewed changes

jeddy3 mentioned this pull request Aug 4, 2025

Release 16.23.1 #8714

Closed

6 tasks

romainmenke reviewed Aug 4, 2025

View reviewed changes

lib/rules/no-invalid-position-declaration/index.mjs Outdated Show resolved Hide resolved

romainmenke reviewed Aug 4, 2025

View reviewed changes

lib/utils/typeGuards.mjs Outdated Show resolved Hide resolved

ybiquitous reviewed Aug 4, 2025

View reviewed changes

lib/rules/no-invalid-position-declaration/__tests__/index.mjs Outdated Show resolved Hide resolved

lib/utils/typeGuards.mjs Outdated Show resolved Hide resolved

ybiquitous mentioned this pull request Aug 4, 2025

Improve postcss-naive-css-in-js test fixture #8715

Merged

sw1tch3roo and others added 7 commits August 4, 2025 16:28

Merge branch 'main' into fix/no-invalid-position-declaration-in-style…

a623517

…-attribute

changes after review

4a9e6dc

Restore original isInDocument to handle CSS-in-JS ASTs correctly

e947322

add test for isInDocument util

80a203a

Merge branch 'main' into fix/no-invalid-position-declaration-in-style…

5379f6a

…-attribute

Merge branch 'main' into fix/no-invalid-position-declaration-in-style…

48c4bd9

…-attribute

add a comment that describes the code relies on the unofficial docume…

ce24f1c

…nt property

sw1tch3roo requested a review from ybiquitous August 5, 2025 13:36

ybiquitous reviewed Aug 5, 2025

View reviewed changes

lib/utils/isInDocument.mjs Show resolved Hide resolved

lib/utils/isInDocument.mjs Outdated Show resolved Hide resolved

lib/utils/isInDocument.mjs Outdated Show resolved Hide resolved

add instanceof Node to document node

fc67a96

sw1tch3roo requested a review from ybiquitous August 6, 2025 09:54

ybiquitous approved these changes Aug 6, 2025

View reviewed changes

jeddy3 approved these changes Aug 7, 2025

View reviewed changes

jeddy3 merged commit 2811636 into stylelint:main Aug 7, 2025
17 checks passed

jeddy3 mentioned this pull request Aug 13, 2025

Fix nesting-selector-no-missing-scoping-root false positives for CSS-in-JS #8727

Open

Uh oh!

Fix no-invalid-position-declaration false positives for embedded styles #8701

Fix no-invalid-position-declaration false positives for embedded styles #8701

Conversation

sw1tch3roo commented Aug 1, 2025

Uh oh!

changeset-bot bot commented Aug 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

sw1tch3roo commented Aug 1, 2025

Uh oh!

github-actions bot commented Aug 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

reduckted commented Aug 2, 2025

Uh oh!

sw1tch3roo commented Aug 2, 2025

Uh oh!

jeddy3 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jeddy3 left a comment

Choose a reason for hiding this comment

Uh oh!

romainmenke left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

romainmenke left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ybiquitous left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sw1tch3roo commented Aug 6, 2025

Uh oh!

ybiquitous left a comment

Choose a reason for hiding this comment

Uh oh!

ybiquitous commented Aug 6, 2025

Uh oh!

jeddy3 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Fix `no-invalid-position-declaration` false positives for embedded styles #8701

Fix `no-invalid-position-declaration` false positives for embedded styles #8701

changeset-bot bot commented Aug 1, 2025 •

edited

Loading

github-actions bot commented Aug 1, 2025 •

edited

Loading