Skip to content

[CI] Remove create tag step from release #3249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

MortalHappiness
Copy link
Member

Why are these changes needed?

Address #3117 (comment)

Related issue number

N/A

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

Signed-off-by: Chi-Sheng Liu <chishengliu@chishengliu.com>
@MortalHappiness MortalHappiness force-pushed the feature/remove-create-tag-ci-step branch from f49ea64 to e851c37 Compare March 29, 2025 03:52
@andrewsykim andrewsykim enabled auto-merge (squash) April 1, 2025 22:55
@andrewsykim andrewsykim merged commit 0e9d177 into ray-project:master Apr 1, 2025
21 checks passed
andrewsykim pushed a commit to andrewsykim/kuberay that referenced this pull request Apr 2, 2025
Signed-off-by: Chi-Sheng Liu <chishengliu@chishengliu.com>
@andrewsykim andrewsykim mentioned this pull request Apr 2, 2025
4 tasks
andrewsykim pushed a commit to andrewsykim/kuberay that referenced this pull request Apr 2, 2025
Signed-off-by: Chi-Sheng Liu <chishengliu@chishengliu.com>
andrewsykim pushed a commit to andrewsykim/kuberay that referenced this pull request Apr 2, 2025
Signed-off-by: Chi-Sheng Liu <chishengliu@chishengliu.com>
andrewsykim added a commit that referenced this pull request Apr 2, 2025
* [RayJob][Fix] Use --no-wait for job submission to avoid carrying the error return code to the log tailing (#3216)

* [RayJob][Fix] Use --no-wait for job submission to avoid carrying the error return code to the log tailing

Signed-off-by: Rueian <rueiancsie@gmail.com>

* [RayJob][Fix] Use --no-wait for job submission to avoid carrying the error return code to the log tailing

Signed-off-by: Rueian <rueiancsie@gmail.com>

* chore: update comments

Signed-off-by: Rueian <rueiancsie@gmail.com>

* chore: add a comment about bash -e

Signed-off-by: Rueian <rueiancsie@gmail.com>

---------

Signed-off-by: Rueian <rueiancsie@gmail.com>

* kubectl ray job submit: provide entrypoint (#3186)

* [kubectl-plugin] Add head/worker node selector option (#3228)

* add node selector option for kubectl plugin create cluster

Signed-off-by: Troy Chiu <y.troychiu@gmail.com>

* nit

Signed-off-by: Troy Chiu <y.troychiu@gmail.com>

---------

Signed-off-by: Troy Chiu <y.troychiu@gmail.com>

* add node selector option for kubectl plugin create worker group (#3235)

* add node selector option for kubectl plugin create work group

Signed-off-by: Troy Chiu <y.troychiu@gmail.com>

* nit

Signed-off-by: Troy Chiu <y.troychiu@gmail.com>

* code review: fix usage

Signed-off-by: Troy Chiu <y.troychiu@gmail.com>

---------

Signed-off-by: Troy Chiu <y.troychiu@gmail.com>

* [kubectl-plugin] remove CPU limits by default (#3243)

Signed-off-by: Andrew Sy Kim <andrewsy@google.com>

* [Chore][CI] Limit the release-image-build github workflow to only take tag as input (#3117)

* remove all inputs from workflow_dispatch

Signed-off-by: Tina Wu <j6vupz97@gmail.com>

* use tag only

Signed-off-by: Tina Wu <j6vupz97@gmail.com>

* align case

Signed-off-by: Tina Wu <j6vupz97@gmail.com>

* change sha

Signed-off-by: Tina Wu <j6vupz97@gmail.com>

* extract tag

* lint fix

Signed-off-by: Tina Wu <j6vupz97@gmail.com>

* update github_env

Signed-off-by: Tina Wu <j6vupz97@gmail.com>

* directly take tag

Signed-off-by: Tina Wu <j6vupz97@gmail.com>

* add env,

Signed-off-by: Tina Wu <j6vupz97@gmail.com>

* directly use tag

Signed-off-by: Tina Wu <j6vupz97@gmail.com>

* use env. when in script

Signed-off-by: Tina Wu <j6vupz97@gmail.com>

* env.tag when with

Signed-off-by: Tina Wu <j6vupz97@gmail.com>

* use env.tag for all

Signed-off-by: Tina Wu <j6vupz97@gmail.com>

---------

Signed-off-by: Tina Wu <j6vupz97@gmail.com>
Co-authored-by: tinaxfwu <twu@synchron.com>

* [CI] Remove create tag step from release (#3249)

Signed-off-by: Chi-Sheng Liu <chishengliu@chishengliu.com>

---------

Signed-off-by: Rueian <rueiancsie@gmail.com>
Signed-off-by: Troy Chiu <y.troychiu@gmail.com>
Signed-off-by: Andrew Sy Kim <andrewsy@google.com>
Signed-off-by: Tina Wu <j6vupz97@gmail.com>
Signed-off-by: Chi-Sheng Liu <chishengliu@chishengliu.com>
Co-authored-by: Rueian <rueiancsie@gmail.com>
Co-authored-by: Spencer Peterson <spencerjp@google.com>
Co-authored-by: Troy Chiu <114708546+troychiu@users.noreply.github.com>
Co-authored-by: Tina Wu <j6vupz97@gmail.com>
Co-authored-by: tinaxfwu <twu@synchron.com>
Co-authored-by: Chi-Sheng Liu <chishengliu@chishengliu.com>
win5923 pushed a commit to win5923/kuberay that referenced this pull request Apr 27, 2025
Signed-off-by: Chi-Sheng Liu <chishengliu@chishengliu.com>
davidxia added a commit to davidxia/kuberay that referenced this pull request May 20, 2025
We need to push a git tag named `ray-operator/vX.Y.Z` to publish Go modules to
https://pkg.go.dev/github.com/ray-project/kuberay/ray-operator?tab=versions

This reverts ray-project#3249.

Signed-off-by: David Xia <david@davidxia.com>
andrewsykim pushed a commit that referenced this pull request May 20, 2025
We need to push a git tag named `ray-operator/vX.Y.Z` to publish Go modules to
https://pkg.go.dev/github.com/ray-project/kuberay/ray-operator?tab=versions

This reverts #3249.

Signed-off-by: David Xia <david@davidxia.com>
pawelpaszki pushed a commit to opendatahub-io/kuberay that referenced this pull request May 26, 2025
We need to push a git tag named `ray-operator/vX.Y.Z` to publish Go modules to
https://pkg.go.dev/github.com/ray-project/kuberay/ray-operator?tab=versions

This reverts ray-project#3249.

Signed-off-by: David Xia <david@davidxia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants