[Chore][CI] Limit the release-image-build github workflow to only take tag as input #3117

tinaxfwu · 2025-02-26T19:29:31Z

Why are these changes needed?

This Merge Request uses #3015 as a reference to make the release-image-build github workflow to take only the tag as input since krew-release-bot requires it.

The workflow-dispatch step is now empty (i.e., no manual inputs)

An error checking step enforces the workflow fails if it's not running on a tag.
Extract the tag for other steps to use.

Related issue number

Resolve #3016

Checks

I've made sure the tests are passing.
Testing Strategy
- Unit tests
- Manual tests
- This PR is not tested :(

Signed-off-by: Tina Wu <j6vupz97@gmail.com>

.github/workflows/image-release.yaml

Signed-off-by: Tina Wu <j6vupz97@gmail.com>

.github/workflows/image-release.yaml

Signed-off-by: Tina Wu <j6vupz97@gmail.com>

.github/workflows/image-release.yaml

Signed-off-by: Tina Wu <j6vupz97@gmail.com>

MortalHappiness

LGTM

andrewsykim · 2025-03-29T01:07:06Z

.github/workflows/image-release.yaml

@@ -160,7 +173,7 @@ jobs:
        provenance: false
        tags: |
          quay.io/${{env.REPO_ORG}}/${{env.REPO_NAME}}:${{ steps.vars.outputs.sha_short }}
-          quay.io/${{env.REPO_ORG}}/${{env.REPO_NAME}}:${{ github.event.inputs.tag }}
+          quay.io/${{env.REPO_ORG}}/${{env.REPO_NAME}}:${{ env.tag }}

    - name: Create tag


I don't think we need to create tag anymore since we should expect the tag to already exist?

Okay. I'll open another PR to address this.

…e tag as input (ray-project#3117) * remove all inputs from workflow_dispatch Signed-off-by: Tina Wu <j6vupz97@gmail.com> * use tag only Signed-off-by: Tina Wu <j6vupz97@gmail.com> * align case Signed-off-by: Tina Wu <j6vupz97@gmail.com> * change sha Signed-off-by: Tina Wu <j6vupz97@gmail.com> * extract tag * lint fix Signed-off-by: Tina Wu <j6vupz97@gmail.com> * update github_env Signed-off-by: Tina Wu <j6vupz97@gmail.com> * directly take tag Signed-off-by: Tina Wu <j6vupz97@gmail.com> * add env, Signed-off-by: Tina Wu <j6vupz97@gmail.com> * directly use tag Signed-off-by: Tina Wu <j6vupz97@gmail.com> * use env. when in script Signed-off-by: Tina Wu <j6vupz97@gmail.com> * env.tag when with Signed-off-by: Tina Wu <j6vupz97@gmail.com> * use env.tag for all Signed-off-by: Tina Wu <j6vupz97@gmail.com> --------- Signed-off-by: Tina Wu <j6vupz97@gmail.com> Co-authored-by: tinaxfwu <twu@synchron.com>

* [RayJob][Fix] Use --no-wait for job submission to avoid carrying the error return code to the log tailing (#3216) * [RayJob][Fix] Use --no-wait for job submission to avoid carrying the error return code to the log tailing Signed-off-by: Rueian <rueiancsie@gmail.com> * [RayJob][Fix] Use --no-wait for job submission to avoid carrying the error return code to the log tailing Signed-off-by: Rueian <rueiancsie@gmail.com> * chore: update comments Signed-off-by: Rueian <rueiancsie@gmail.com> * chore: add a comment about bash -e Signed-off-by: Rueian <rueiancsie@gmail.com> --------- Signed-off-by: Rueian <rueiancsie@gmail.com> * kubectl ray job submit: provide entrypoint (#3186) * [kubectl-plugin] Add head/worker node selector option (#3228) * add node selector option for kubectl plugin create cluster Signed-off-by: Troy Chiu <y.troychiu@gmail.com> * nit Signed-off-by: Troy Chiu <y.troychiu@gmail.com> --------- Signed-off-by: Troy Chiu <y.troychiu@gmail.com> * add node selector option for kubectl plugin create worker group (#3235) * add node selector option for kubectl plugin create work group Signed-off-by: Troy Chiu <y.troychiu@gmail.com> * nit Signed-off-by: Troy Chiu <y.troychiu@gmail.com> * code review: fix usage Signed-off-by: Troy Chiu <y.troychiu@gmail.com> --------- Signed-off-by: Troy Chiu <y.troychiu@gmail.com> * [kubectl-plugin] remove CPU limits by default (#3243) Signed-off-by: Andrew Sy Kim <andrewsy@google.com> * [Chore][CI] Limit the release-image-build github workflow to only take tag as input (#3117) * remove all inputs from workflow_dispatch Signed-off-by: Tina Wu <j6vupz97@gmail.com> * use tag only Signed-off-by: Tina Wu <j6vupz97@gmail.com> * align case Signed-off-by: Tina Wu <j6vupz97@gmail.com> * change sha Signed-off-by: Tina Wu <j6vupz97@gmail.com> * extract tag * lint fix Signed-off-by: Tina Wu <j6vupz97@gmail.com> * update github_env Signed-off-by: Tina Wu <j6vupz97@gmail.com> * directly take tag Signed-off-by: Tina Wu <j6vupz97@gmail.com> * add env, Signed-off-by: Tina Wu <j6vupz97@gmail.com> * directly use tag Signed-off-by: Tina Wu <j6vupz97@gmail.com> * use env. when in script Signed-off-by: Tina Wu <j6vupz97@gmail.com> * env.tag when with Signed-off-by: Tina Wu <j6vupz97@gmail.com> * use env.tag for all Signed-off-by: Tina Wu <j6vupz97@gmail.com> --------- Signed-off-by: Tina Wu <j6vupz97@gmail.com> Co-authored-by: tinaxfwu <twu@synchron.com> * [CI] Remove create tag step from release (#3249) Signed-off-by: Chi-Sheng Liu <chishengliu@chishengliu.com> --------- Signed-off-by: Rueian <rueiancsie@gmail.com> Signed-off-by: Troy Chiu <y.troychiu@gmail.com> Signed-off-by: Andrew Sy Kim <andrewsy@google.com> Signed-off-by: Tina Wu <j6vupz97@gmail.com> Signed-off-by: Chi-Sheng Liu <chishengliu@chishengliu.com> Co-authored-by: Rueian <rueiancsie@gmail.com> Co-authored-by: Spencer Peterson <spencerjp@google.com> Co-authored-by: Troy Chiu <114708546+troychiu@users.noreply.github.com> Co-authored-by: Tina Wu <j6vupz97@gmail.com> Co-authored-by: tinaxfwu <twu@synchron.com> Co-authored-by: Chi-Sheng Liu <chishengliu@chishengliu.com>

…e tag as input (ray-project#3117) * remove all inputs from workflow_dispatch Signed-off-by: Tina Wu <j6vupz97@gmail.com> * use tag only Signed-off-by: Tina Wu <j6vupz97@gmail.com> * align case Signed-off-by: Tina Wu <j6vupz97@gmail.com> * change sha Signed-off-by: Tina Wu <j6vupz97@gmail.com> * extract tag * lint fix Signed-off-by: Tina Wu <j6vupz97@gmail.com> * update github_env Signed-off-by: Tina Wu <j6vupz97@gmail.com> * directly take tag Signed-off-by: Tina Wu <j6vupz97@gmail.com> * add env, Signed-off-by: Tina Wu <j6vupz97@gmail.com> * directly use tag Signed-off-by: Tina Wu <j6vupz97@gmail.com> * use env. when in script Signed-off-by: Tina Wu <j6vupz97@gmail.com> * env.tag when with Signed-off-by: Tina Wu <j6vupz97@gmail.com> * use env.tag for all Signed-off-by: Tina Wu <j6vupz97@gmail.com> --------- Signed-off-by: Tina Wu <j6vupz97@gmail.com> Co-authored-by: tinaxfwu <twu@synchron.com>

tinaxfwu changed the title ~~Fix/limit workflow input~~ [Chore][CI] Limit the release-image-build github workflow to only take tag as input Feb 27, 2025

tinaxfwu force-pushed the fix/limit-workflow-input branch from 4e8650c to 625fcb2 Compare March 1, 2025 01:09

tinaxfwu closed this Mar 2, 2025

tinaxfwu deleted the fix/limit-workflow-input branch March 2, 2025 22:36

tinaxfwu restored the fix/limit-workflow-input branch March 2, 2025 22:37

tinaxfwu reopened this Mar 2, 2025

tinaxfwu force-pushed the fix/limit-workflow-input branch from e610caa to f2d32cb Compare March 2, 2025 22:43

tinaxfwu and others added 5 commits March 2, 2025 18:00

remove all inputs from workflow_dispatch

bdc53df

Signed-off-by: Tina Wu <j6vupz97@gmail.com>

use tag only

9f74b48

Signed-off-by: Tina Wu <j6vupz97@gmail.com>

align case

7e786ed

Signed-off-by: Tina Wu <j6vupz97@gmail.com>

change sha

962f3d9

Signed-off-by: Tina Wu <j6vupz97@gmail.com>

extract tag

8976353

tinaxfwu force-pushed the fix/limit-workflow-input branch from bed16d4 to 8976353 Compare March 2, 2025 23:02

lint fix

379a9a4

Signed-off-by: Tina Wu <j6vupz97@gmail.com>

tinaxfwu marked this pull request as ready for review March 3, 2025 20:47

kevin85421 assigned MortalHappiness Mar 5, 2025

MortalHappiness requested changes Mar 12, 2025

View reviewed changes

.github/workflows/image-release.yaml Outdated Show resolved Hide resolved

.github/workflows/image-release.yaml Outdated Show resolved Hide resolved

update github_env

75d910d

Signed-off-by: Tina Wu <j6vupz97@gmail.com>

kevin85421 requested a review from MortalHappiness March 17, 2025 16:32

MortalHappiness reviewed Mar 18, 2025

View reviewed changes

.github/workflows/image-release.yaml Outdated Show resolved Hide resolved

tinaxfwu added 2 commits March 19, 2025 23:14

directly take tag

90a770e

Signed-off-by: Tina Wu <j6vupz97@gmail.com>

add env,

96135f0

Signed-off-by: Tina Wu <j6vupz97@gmail.com>

MortalHappiness reviewed Mar 20, 2025

View reviewed changes

.github/workflows/image-release.yaml Show resolved Hide resolved

tinaxfwu added 3 commits March 20, 2025 19:30

directly use tag

8b00657

Signed-off-by: Tina Wu <j6vupz97@gmail.com>

use env. when in script

0d70a2c

Signed-off-by: Tina Wu <j6vupz97@gmail.com>

env.tag when with

38f1606

Signed-off-by: Tina Wu <j6vupz97@gmail.com>

tinaxfwu force-pushed the fix/limit-workflow-input branch from 8e4ce74 to 38f1606 Compare March 21, 2025 05:12

use env.tag for all

7e9c9e0

Signed-off-by: Tina Wu <j6vupz97@gmail.com>

MortalHappiness approved these changes Mar 24, 2025

View reviewed changes

MortalHappiness assigned kevin85421 Mar 24, 2025

MortalHappiness assigned andrewsykim Mar 26, 2025

MortalHappiness mentioned this pull request Mar 26, 2025

Update KubeRay release documentation #3226

Merged

4 tasks

andrewsykim reviewed Mar 29, 2025

View reviewed changes

andrewsykim merged commit d97e37a into ray-project:master Mar 29, 2025
21 checks passed

MortalHappiness mentioned this pull request Mar 29, 2025

[CI] Remove create tag step from release #3249

Merged

4 tasks

andrewsykim mentioned this pull request Apr 2, 2025

[release-1.3] v1.3.2 backports #3264

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Chore][CI] Limit the release-image-build github workflow to only take tag as input #3117

[Chore][CI] Limit the release-image-build github workflow to only take tag as input #3117

Uh oh!

tinaxfwu commented Feb 26, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MortalHappiness left a comment

Uh oh!

andrewsykim Mar 29, 2025

Uh oh!

MortalHappiness Mar 29, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

[Chore][CI] Limit the release-image-build github workflow to only take tag as input #3117

[Chore][CI] Limit the release-image-build github workflow to only take tag as input #3117

Uh oh!

Conversation

tinaxfwu commented Feb 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Why are these changes needed?

Related issue number

Checks

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MortalHappiness left a comment

Choose a reason for hiding this comment

Uh oh!

andrewsykim Mar 29, 2025

Choose a reason for hiding this comment

Uh oh!

MortalHappiness Mar 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

tinaxfwu commented Feb 26, 2025 •

edited

Loading

MortalHappiness Mar 29, 2025 •

edited

Loading