add node selector option for kubectl plugin create worker group #3235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Troy Chiu <y.troychiu@gmail.com>
MortalHappiness
approved these changes
Mar 27, 2025
|
cc @davidxia |
andrewsykim
reviewed
Mar 27, 2025
| @@ -89,6 +90,7 @@ func NewCreateWorkerGroupCommand(cmdFactory cmdutil.Factory, streams genericclio | |||
| cmd.Flags().StringVar(&options.workerGPU, "worker-gpu", "0", "number of GPUs in each replica") | |||
| cmd.Flags().StringVar(&options.workerMemory, "worker-memory", "4Gi", "amount of memory in each replica") | |||
| cmd.Flags().StringToStringVar(&options.rayStartParams, "worker-ray-start-params", options.rayStartParams, "a map of arguments to the Ray workers' 'ray start' entrypoint, e.g. '--worker-ray-start-params metrics-export-port=8080,num-cpus=2'") | |||
| cmd.Flags().StringToStringVar(&options.workerNodeSelectors, "worker-node-selectors", nil, "Node selectors to apply to all worker pods in the cluster (e.g. --worker-node-selectors cloud.google.com/gke-accelerator=nvidia-l4,cloud.google.com/gke-nodepool=my-node-pool)") | |||
There was a problem hiding this comment.
Node selectors to apply to all worker pods in this worker group
Signed-off-by: Troy Chiu <y.troychiu@gmail.com>
davidxia
approved these changes
Mar 27, 2025
andrewsykim
approved these changes
Mar 27, 2025
andrewsykim
pushed a commit
to andrewsykim/kuberay
that referenced
this pull request
Apr 2, 2025
…project#3235) * add node selector option for kubectl plugin create work group Signed-off-by: Troy Chiu <y.troychiu@gmail.com> * nit Signed-off-by: Troy Chiu <y.troychiu@gmail.com> * code review: fix usage Signed-off-by: Troy Chiu <y.troychiu@gmail.com> --------- Signed-off-by: Troy Chiu <y.troychiu@gmail.com>
4 tasks
andrewsykim
pushed a commit
to andrewsykim/kuberay
that referenced
this pull request
Apr 2, 2025
…project#3235) * add node selector option for kubectl plugin create work group Signed-off-by: Troy Chiu <y.troychiu@gmail.com> * nit Signed-off-by: Troy Chiu <y.troychiu@gmail.com> * code review: fix usage Signed-off-by: Troy Chiu <y.troychiu@gmail.com> --------- Signed-off-by: Troy Chiu <y.troychiu@gmail.com>
andrewsykim
pushed a commit
to andrewsykim/kuberay
that referenced
this pull request
Apr 2, 2025
…project#3235) * add node selector option for kubectl plugin create work group Signed-off-by: Troy Chiu <y.troychiu@gmail.com> * nit Signed-off-by: Troy Chiu <y.troychiu@gmail.com> * code review: fix usage Signed-off-by: Troy Chiu <y.troychiu@gmail.com> --------- Signed-off-by: Troy Chiu <y.troychiu@gmail.com>
andrewsykim
added a commit
that referenced
this pull request
Apr 2, 2025
* [RayJob][Fix] Use --no-wait for job submission to avoid carrying the error return code to the log tailing (#3216) * [RayJob][Fix] Use --no-wait for job submission to avoid carrying the error return code to the log tailing Signed-off-by: Rueian <rueiancsie@gmail.com> * [RayJob][Fix] Use --no-wait for job submission to avoid carrying the error return code to the log tailing Signed-off-by: Rueian <rueiancsie@gmail.com> * chore: update comments Signed-off-by: Rueian <rueiancsie@gmail.com> * chore: add a comment about bash -e Signed-off-by: Rueian <rueiancsie@gmail.com> --------- Signed-off-by: Rueian <rueiancsie@gmail.com> * kubectl ray job submit: provide entrypoint (#3186) * [kubectl-plugin] Add head/worker node selector option (#3228) * add node selector option for kubectl plugin create cluster Signed-off-by: Troy Chiu <y.troychiu@gmail.com> * nit Signed-off-by: Troy Chiu <y.troychiu@gmail.com> --------- Signed-off-by: Troy Chiu <y.troychiu@gmail.com> * add node selector option for kubectl plugin create worker group (#3235) * add node selector option for kubectl plugin create work group Signed-off-by: Troy Chiu <y.troychiu@gmail.com> * nit Signed-off-by: Troy Chiu <y.troychiu@gmail.com> * code review: fix usage Signed-off-by: Troy Chiu <y.troychiu@gmail.com> --------- Signed-off-by: Troy Chiu <y.troychiu@gmail.com> * [kubectl-plugin] remove CPU limits by default (#3243) Signed-off-by: Andrew Sy Kim <andrewsy@google.com> * [Chore][CI] Limit the release-image-build github workflow to only take tag as input (#3117) * remove all inputs from workflow_dispatch Signed-off-by: Tina Wu <j6vupz97@gmail.com> * use tag only Signed-off-by: Tina Wu <j6vupz97@gmail.com> * align case Signed-off-by: Tina Wu <j6vupz97@gmail.com> * change sha Signed-off-by: Tina Wu <j6vupz97@gmail.com> * extract tag * lint fix Signed-off-by: Tina Wu <j6vupz97@gmail.com> * update github_env Signed-off-by: Tina Wu <j6vupz97@gmail.com> * directly take tag Signed-off-by: Tina Wu <j6vupz97@gmail.com> * add env, Signed-off-by: Tina Wu <j6vupz97@gmail.com> * directly use tag Signed-off-by: Tina Wu <j6vupz97@gmail.com> * use env. when in script Signed-off-by: Tina Wu <j6vupz97@gmail.com> * env.tag when with Signed-off-by: Tina Wu <j6vupz97@gmail.com> * use env.tag for all Signed-off-by: Tina Wu <j6vupz97@gmail.com> --------- Signed-off-by: Tina Wu <j6vupz97@gmail.com> Co-authored-by: tinaxfwu <twu@synchron.com> * [CI] Remove create tag step from release (#3249) Signed-off-by: Chi-Sheng Liu <chishengliu@chishengliu.com> --------- Signed-off-by: Rueian <rueiancsie@gmail.com> Signed-off-by: Troy Chiu <y.troychiu@gmail.com> Signed-off-by: Andrew Sy Kim <andrewsy@google.com> Signed-off-by: Tina Wu <j6vupz97@gmail.com> Signed-off-by: Chi-Sheng Liu <chishengliu@chishengliu.com> Co-authored-by: Rueian <rueiancsie@gmail.com> Co-authored-by: Spencer Peterson <spencerjp@google.com> Co-authored-by: Troy Chiu <114708546+troychiu@users.noreply.github.com> Co-authored-by: Tina Wu <j6vupz97@gmail.com> Co-authored-by: tinaxfwu <twu@synchron.com> Co-authored-by: Chi-Sheng Liu <chishengliu@chishengliu.com>
win5923
pushed a commit
to win5923/kuberay
that referenced
this pull request
Apr 27, 2025
…project#3235) * add node selector option for kubectl plugin create work group Signed-off-by: Troy Chiu <y.troychiu@gmail.com> * nit Signed-off-by: Troy Chiu <y.troychiu@gmail.com> * code review: fix usage Signed-off-by: Troy Chiu <y.troychiu@gmail.com> --------- Signed-off-by: Troy Chiu <y.troychiu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add options for create workergroup
--worker-node-selectors
Fix minor comment issue in [kubectl-plugin] Add head/worker node selector option #3228
Why are these changes needed?
#3228 follow-up
Related issue number
N/A
Checks