Make out-of-order native histograms flag a no-op and always enable #16207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This feature has been available in Prometheus since September 2024, and has no known issues. Therefore proposing to remove the flag entirely and always have it on. Note that there are still two settings that need to be configured (out-of-order time window > 0 and native histograms enabled) for this feature to work. Signed-off-by: Fiona Liao <fiona.liao@grafana.com>
Signed-off-by: Fiona Liao <fiona.liao@grafana.com>
beorn7
requested changes
Mar 12, 2025
There was a problem hiding this comment.
Generally looks good (but maybe @krajorama should verify). Just a nit about a special warning for formerly existing feature flags.
3 tasks
Signed-off-by: Fiona Liao <fiona.liao@grafana.com>
Signed-off-by: Fiona Liao <fiona.liao@grafana.com>
krajorama
reviewed
Mar 17, 2025
Co-authored-by: George Krajcsovits <krajorama@users.noreply.github.com> Signed-off-by: Fiona Liao <fiona.y.liao@gmail.com>
Co-authored-by: George Krajcsovits <krajorama@users.noreply.github.com> Signed-off-by: Fiona Liao <fiona.y.liao@gmail.com>
Co-authored-by: George Krajcsovits <krajorama@users.noreply.github.com> Signed-off-by: Fiona Liao <fiona.y.liao@gmail.com>
b3970ad to
372f95a
Compare
Signed-off-by: Fiona Liao <fiona.liao@grafana.com>
372f95a to
a12e38f
Compare
beorn7
approved these changes
Mar 18, 2025
charleskorn
added a commit
to grafana/mimir
that referenced
this pull request
Mar 21, 2025
charleskorn
added a commit
to grafana/mimir
that referenced
this pull request
Mar 21, 2025
zenador
pushed a commit
to grafana/mimir
that referenced
this pull request
Mar 21, 2025
* Upgrade mimir-prometheus * Adjust tests to match new pretty printing format in prometheus/prometheus#16083 * Fix breaking change from prometheus/prometheus#16156 * Upgrade to github.com/oklog/ulid/v2 (prometheus/prometheus#16168) * Bring in changes from prometheus/prometheus#16199 * Remove OOO native histograms flag (prometheus/prometheus#16207) * Add changelog entries * Ignore deprecation warning for `model.NameValidationScheme` * Remove outdated native histogram OOO integration test
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Out-of-order native histograms has been available in Prometheus since September 2024, and has no known issues. We have enabled it by default in Grafana Labs for a while (with Mimir which uses a fork of Prometheus), and that doesn't have known issues either.
Therefore proposing to remove the flag entirely and always have it on(edit: now keeping the flag but making it a no-op as per #16207 (comment)).Always having OOO NH on removes some of the complexity from the code and for users configuring Prometheus - there are still two settings that need to be configured (out-of-order time window > 0 and native histograms enabled) for this feature to be enabled.