Upgrade to github.com/oklog/ulid/v2 #16168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
1fa2545 to
4536f4d
Compare
charleskorn
added a commit
to grafana/mimir
that referenced
this pull request
Mar 21, 2025
charleskorn
added a commit
to grafana/mimir
that referenced
this pull request
Mar 21, 2025
zenador
pushed a commit
to grafana/mimir
that referenced
this pull request
Mar 21, 2025
* Upgrade mimir-prometheus * Adjust tests to match new pretty printing format in prometheus/prometheus#16083 * Fix breaking change from prometheus/prometheus#16156 * Upgrade to github.com/oklog/ulid/v2 (prometheus/prometheus#16168) * Bring in changes from prometheus/prometheus#16199 * Remove OOO native histograms flag (prometheus/prometheus#16207) * Add changelog entries * Ignore deprecation warning for `model.NameValidationScheme` * Remove outdated native histogram OOO integration test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade github.com/oklog/ulid to v2.1.0. Having compared v2 to v1, I don't see any significant changes. The motivation is to unblock an automated upgrade of github.com/oklog/ulid to v2 in Grafana Mimir.