Add util/compression package to consolidate snappy/zstd use in Prometheus. #16156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6c48d3a to
ca21aa2
Compare
This comment was marked as resolved.
This comment was marked as resolved.
e954941 to
5755960
Compare
This comment was marked as resolved.
This comment was marked as resolved.
ArthurSens
reviewed
Mar 6, 2025
There was a problem hiding this comment.
Looks great! I tried my best to do a very deep review, and things look correct in general :)
I noticed some extra changes unrelated to "consolidate compression in a single package", i.e., changes on wlog metrics. That was a bit too much for me today; I am not sure if you want to keep it in this same PR or do a follow-up to keep PRs with a single scope. Either way, I'll try to look at the metric changes at another moment
7c60b21 to
9470c33
Compare
ArthurSens
reviewed
Mar 7, 2025
ArthurSens
approved these changes
Mar 7, 2025
ee621e2 to
231a188
Compare
…heus. Signed-off-by: bwplotka <bwplotka@gmail.com> Apply suggestions from code review Co-authored-by: Arthur Silva Sens <arthursens2005@gmail.com> Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com> tmp Signed-off-by: bwplotka <bwplotka@gmail.com> Addressed comments. Signed-off-by: bwplotka <bwplotka@gmail.com> Update util/compression/buffers.go Co-authored-by: Arthur Silva Sens <arthursens2005@gmail.com> Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com> Fix lint? Signed-off-by: bwplotka <bwplotka@gmail.com>
charleskorn
added a commit
to grafana/mimir
that referenced
this pull request
Mar 21, 2025
charleskorn
added a commit
to grafana/mimir
that referenced
this pull request
Mar 21, 2025
zenador
pushed a commit
to grafana/mimir
that referenced
this pull request
Mar 21, 2025
* Upgrade mimir-prometheus * Adjust tests to match new pretty printing format in prometheus/prometheus#16083 * Fix breaking change from prometheus/prometheus#16156 * Upgrade to github.com/oklog/ulid/v2 (prometheus/prometheus#16168) * Bring in changes from prometheus/prometheus#16199 * Remove OOO native histograms flag (prometheus/prometheus#16207) * Add changelog entries * Ignore deprecation warning for `model.NameValidationScheme` * Remove outdated native histogram OOO integration test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a bit mess on our compression uses, trying to consolidate all compressions we use in one package.
At some point we can add gzip, and potentially replace all snappy uses with this util pkg. I noticed this and kind of needed in #16046 (e.g. for my micro-benchmarks that use compressions as well).