Update images for Pilot & Unary #361

sebastienvas · 2017-06-06T02:20:19Z

No description provided.

ldemailly

thx!

sebastienvas · 2017-06-06T05:02:55Z

@douglas-reid The TestDenials keeps failing
--- FAIL: TestDenials (159.34s)
mixer_test.go:301: Bad metric value: got 0.000000, want at least 1
Do you know why that would be ?

douglas-reid · 2017-06-06T15:57:35Z

I'll take a look. Naively, it would seem that denials is no longer working.

douglas-reid · 2017-06-06T16:07:17Z

@qiwzhang @geeknoid when I look at the reported results for this test, I see no 4xx responses when a denial rule is in place. Is this related to the change in error reporting (are we still forwarding rpc statuses to mixer, rather than the internal status messages)?

ldemailly · 2017-06-06T16:26:47Z

let's push this and file a hi pri issue to fix the test failure separately ?

sebastienvas · 2017-06-06T16:29:28Z

THat s a good Idea, that way Mixer can know directly if there fix works.

douglas-reid · 2017-06-06T16:40:17Z

fwiw, this appears to represent a regression in functionality. If we don't want to treat that as blocking, that is up to us, but the typical warnings apply.

ldemailly · 2017-06-06T16:51:45Z

the regression is there whether we push this or not - this just unearthed it - let's push this pr

geeknoid · 2017-06-06T16:53:40Z

In the new world, the Check RPC no longer returns 4xx results. Instead, the RPC itself succeeds, and the check yes/no indication is contained in the CheckResponse.status field instead.

douglas-reid · 2017-06-06T16:58:19Z

@geeknoid mixerclient should be pulling out the yes/no from the CheckResponse.status field and forwarding that to mixer in this new world, right? this is particularly odd, because we see 429s for the rate-limit test, so perhaps there is something else going on.

ldemailly · 2017-06-06T16:58:57Z

please move talking about the test failure in #365

This reverts commit 2b210ac.

* Rbac ingress (#320) * Add ingresses/status to rbac * fix bash'ism (#325) * fix bash'ism we tell people to `curl -L https://git.io/getIstio | sh -` so we can't use bash extentions I was getting [[ unknown command on line 12, fixing this * also updating comment * updateVersion.sh to not modify templates (#229) * istio install templates * fix copy * fix temp var * []byte values * fix linter errors * comment out unused ca vars * gofmt kubernetes.go * fix macros * fix kubeTest.sh * move istio-auth-with-cluster-ca.yaml out of templates dir (#334) * fix broken link (#335) * fixing #321 (#336) fixing broken links * Getting master ready for beta (#322) 0.1.x -> 0.2.x * Add v1/stable version (#351) * Add v1/stable version * Start of a local development directory (#337) * initial skeleton notes for local dev * tweaks * adding the rules.yaml for local dev and updating the scripts * Fixing English typo * Also start to address dev getting started Issue #348 * incorporated most of my noogler notes * Adding the sample quota * adding note about -v=5 for debug/verbose output * Code review comments * typo fix will follow up with moving most of mixer/dev/development.md into this * Moving most of mixer/doc/dev/development.md here (#352) * Moving most of mixer/doc/dev/development.md here https://github.com/istio/mixer/blob/master/doc/dev/development.md to here with updates to make it a bit more generic than just mixer * Also move conventions.md and performance.md here * Review comments And linking the conventions and perf docs * minor update * Manager -> pilot rename (#359) * Manager -> Pilot git ls-files | grep -v tests/e2e|grep -v bookinfo| xargs -n 1 sed -i .bak -e 's/Manager/Pilot/g' As tests/e2e and bookinfo have other Manager unrelated to pilot * manager -> pilot git ls-files | grep -v tests/e2e|grep -v bookinfo| xargs -n 1 sed -i .bak -e 's/manager/pilot/g' * Manual changes in e2e * MANAGER to PILOT git ls-files | xargs -n 1 sed -i .bak -e 's/MANAGER/PILOT/g' and manually excluding some * Rename yaml file too * Last few selective renames Last piece, only remaining ‘manager’ are: ``` ldemailly-macbookpro:istio ldemailly$ git grep -i manager samples/apps/bookinfo/src/reviews/reviews-wlpcfg/servers/LibertyProjectS erver/server.xml: <featureManager> samples/apps/bookinfo/src/reviews/reviews-wlpcfg/servers/LibertyProjectS erver/server.xml: </featureManager> tests/e2e/README.md:### appManager.go tests/e2e/README.md:`appManager` gather apps required for test into a array and deploy them while setup() tests/e2e/framework/BUILD: "appManager.go", tests/e2e/framework/appManager.go:// AppManager organize and deploy apps tests/e2e/framework/appManager.go:type AppManager struct { tests/e2e/framework/appManager.go:// NewAppManager create a new AppManager tests/e2e/framework/appManager.go:func NewAppManager(tmpDir, namespace string, istioctl *Istioctl) *AppManager { tests/e2e/framework/appManager.go: return &AppManager{ tests/e2e/framework/appManager.go:func (am *AppManager) generateAppYaml(a *App) error { tests/e2e/framework/appManager.go:func (am *AppManager) deploy(a *App) error { tests/e2e/framework/appManager.go:func (am *AppManager) Setup() error { tests/e2e/framework/appManager.go:func (am *AppManager) Teardown() error { tests/e2e/framework/appManager.go:func (am *AppManager) AddApp(a *App) { tests/e2e/framework/framework.go: c.Cleanup.RegisterCleanable(c.Kube.AppManager) tests/e2e/framework/kubernetes.go: pilotHub = flag.String("pilot_hub", os.Getenv(pilotHubEnvVar), "Manager hub") tests/e2e/framework/kubernetes.go: pilotTag = flag.String("pilot_tag", os.Getenv(pilotTagEnvVar), "Manager tag") tests/e2e/framework/kubernetes.go: "manager", tests/e2e/framework/kubernetes.go: // App Manager tests/e2e/framework/kubernetes.go: AppManager *AppManager tests/e2e/framework/kubernetes.go: a := NewAppManager(tmpDir, *namespace, i) tests/e2e/framework/kubernetes.go: AppManager: a, tests/e2e/framework/kubernetes.go: case "manager": tests/e2e/tests/bookinfo/demo_test.go: tc.Kube.AppManager.AddApp(demoApp) tests/e2e/tests/mixer/mixer_test.go: tc.Kube.AppManager.AddApp(demoApp) ``` * Review comment changed flag from m to p * make linter happy bin/fmt.sh + review updates * show in logs url being used (#360) A bit more info in logs for when download fails * Update images for Pilot & Unary (#361) * Update image for Unary * Fix forgotten renames * Disabling failing test until #365 is fixed (#366) * Skip TestDenials * Update format and linter to skip git files * Using git ls-files instead of find * Remove extra buildifier call * missed manager->pilot rename and use lowercase -c for ca image (#363) * Make shell utility functions variadic (#377) This simplifies usage a bit by not requiring user to call fmt.Sprintf themselves. * Re-enable TestDenials * Revert "Update images for Pilot & Unary (#361)" This reverts commit 2b210ac. * Revert "Getting master ready for beta (#322)" This reverts commit 910a025. * Update to latest version of manager

* Update image for Unary * Fix forgotten renames Former-commit-id: 2b210ac

* Rbac ingress (#320) * Add ingresses/status to rbac * fix bash'ism (#325) * fix bash'ism we tell people to `curl -L https://git.io/getIstio | sh -` so we can't use bash extentions I was getting [[ unknown command on line 12, fixing this * also updating comment * updateVersion.sh to not modify templates (#229) * istio install templates * fix copy * fix temp var * []byte values * fix linter errors * comment out unused ca vars * gofmt kubernetes.go * fix macros * fix kubeTest.sh * move istio-auth-with-cluster-ca.yaml out of templates dir (#334) * fix broken link (#335) * fixing #321 (#336) fixing broken links * Getting master ready for beta (#322) 0.1.x -> 0.2.x * Add v1/stable version (#351) * Add v1/stable version * Start of a local development directory (#337) * initial skeleton notes for local dev * tweaks * adding the rules.yaml for local dev and updating the scripts * Fixing English typo * Also start to address dev getting started Issue #348 * incorporated most of my noogler notes * Adding the sample quota * adding note about -v=5 for debug/verbose output * Code review comments * typo fix will follow up with moving most of mixer/dev/development.md into this * Moving most of mixer/doc/dev/development.md here (#352) * Moving most of mixer/doc/dev/development.md here https://github.com/istio/mixer/blob/master/doc/dev/development.md to here with updates to make it a bit more generic than just mixer * Also move conventions.md and performance.md here * Review comments And linking the conventions and perf docs * minor update * Manager -> pilot rename (#359) * Manager -> Pilot git ls-files | grep -v tests/e2e|grep -v bookinfo| xargs -n 1 sed -i .bak -e 's/Manager/Pilot/g' As tests/e2e and bookinfo have other Manager unrelated to pilot * manager -> pilot git ls-files | grep -v tests/e2e|grep -v bookinfo| xargs -n 1 sed -i .bak -e 's/manager/pilot/g' * Manual changes in e2e * MANAGER to PILOT git ls-files | xargs -n 1 sed -i .bak -e 's/MANAGER/PILOT/g' and manually excluding some * Rename yaml file too * Last few selective renames Last piece, only remaining ‘manager’ are: ``` ldemailly-macbookpro:istio ldemailly$ git grep -i manager samples/apps/bookinfo/src/reviews/reviews-wlpcfg/servers/LibertyProjectS erver/server.xml: <featureManager> samples/apps/bookinfo/src/reviews/reviews-wlpcfg/servers/LibertyProjectS erver/server.xml: </featureManager> tests/e2e/README.md:### appManager.go tests/e2e/README.md:`appManager` gather apps required for test into a array and deploy them while setup() tests/e2e/framework/BUILD: "appManager.go", tests/e2e/framework/appManager.go:// AppManager organize and deploy apps tests/e2e/framework/appManager.go:type AppManager struct { tests/e2e/framework/appManager.go:// NewAppManager create a new AppManager tests/e2e/framework/appManager.go:func NewAppManager(tmpDir, namespace string, istioctl *Istioctl) *AppManager { tests/e2e/framework/appManager.go: return &AppManager{ tests/e2e/framework/appManager.go:func (am *AppManager) generateAppYaml(a *App) error { tests/e2e/framework/appManager.go:func (am *AppManager) deploy(a *App) error { tests/e2e/framework/appManager.go:func (am *AppManager) Setup() error { tests/e2e/framework/appManager.go:func (am *AppManager) Teardown() error { tests/e2e/framework/appManager.go:func (am *AppManager) AddApp(a *App) { tests/e2e/framework/framework.go: c.Cleanup.RegisterCleanable(c.Kube.AppManager) tests/e2e/framework/kubernetes.go: pilotHub = flag.String("pilot_hub", os.Getenv(pilotHubEnvVar), "Manager hub") tests/e2e/framework/kubernetes.go: pilotTag = flag.String("pilot_tag", os.Getenv(pilotTagEnvVar), "Manager tag") tests/e2e/framework/kubernetes.go: "manager", tests/e2e/framework/kubernetes.go: // App Manager tests/e2e/framework/kubernetes.go: AppManager *AppManager tests/e2e/framework/kubernetes.go: a := NewAppManager(tmpDir, *namespace, i) tests/e2e/framework/kubernetes.go: AppManager: a, tests/e2e/framework/kubernetes.go: case "manager": tests/e2e/tests/bookinfo/demo_test.go: tc.Kube.AppManager.AddApp(demoApp) tests/e2e/tests/mixer/mixer_test.go: tc.Kube.AppManager.AddApp(demoApp) ``` * Review comment changed flag from m to p * make linter happy bin/fmt.sh + review updates * show in logs url being used (#360) A bit more info in logs for when download fails * Update images for Pilot & Unary (#361) * Update image for Unary * Fix forgotten renames * Disabling failing test until #365 is fixed (#366) * Skip TestDenials * Update format and linter to skip git files * Using git ls-files instead of find * Remove extra buildifier call * missed manager->pilot rename and use lowercase -c for ca image (#363) * Make shell utility functions variadic (#377) This simplifies usage a bit by not requiring user to call fmt.Sprintf themselves. * Re-enable TestDenials * Revert "Update images for Pilot & Unary (#361)" This reverts commit 6362d37 [formerly 2b210ac]. * Revert "Getting master ready for beta (#322)" This reverts commit 52e8937 [formerly 910a025]. * Update to latest version of manager Former-commit-id: 6a65da1

* Add init script parameters * Fix golden artifacts

* Update image for Unary * Fix forgotten renames Former-commit-id: 2b210ac

Automatic merge from submit-queue. [DO NOT MERGE] Auto PR to update dependencies of mixerclient This PR will be merged automatically once checks are successful. ```release-note none ```

* Update CoreDNS version to a more recent one * Revert Chart version back

This is not an issue anymore. With the new podman shipped in our base images (ubi8, based on rhel 8.4), this command (`podman image ls -nq`) works fine. This is also valid for 2.0, because both use the same ubi8 base image.

* Add gRPC port to query deployment and service Signed-off-by: Roee Landesman <roee.landesman@envoy.com> * Bump chart version Signed-off-by: Roee Landesman <roee.landesman@envoy.com> * Bump chart patch version Signed-off-by: Roee Landesman <roee.landesman@envoy.com>

googlebot added the cla: yes label Jun 6, 2017

sebastienvas requested a review from ldemailly June 6, 2017 02:20

ldemailly approved these changes Jun 6, 2017

View reviewed changes

sebastienvas added 2 commits June 5, 2017 21:21

Update image for Unary

c56652c

Fix forgotten renames

53fc19a

sebastienvas force-pushed the unary branch from 1566fdd to 53fc19a Compare June 6, 2017 04:24

ldemailly changed the title ~~Update images for Unary~~ Update images for Pilot & Unary Jun 6, 2017

ldemailly mentioned this pull request Jun 6, 2017

FAIL: TestDenials (159.34s) mixer_test.go:301: Bad metric value: got 0.000000, want at least 1 #365

Closed

ldemailly merged commit 2b210ac into istio:master Jun 6, 2017

sebastienvas added a commit to sebastienvas/istio that referenced this pull request Jun 8, 2017

Revert "Update images for Pilot & Unary (istio#361)"

703d8b6

This reverts commit 2b210ac.

rshriram pushed a commit that referenced this pull request Oct 30, 2017

Update images for Pilot & Unary (#361)

6362d37

* Update image for Unary * Fix forgotten renames Former-commit-id: 2b210ac

mandarjog pushed a commit that referenced this pull request Oct 31, 2017

Add init script parameters (#361)

4d4a73e

* Add init script parameters * Fix golden artifacts

mandarjog pushed a commit that referenced this pull request Nov 2, 2017

Update images for Pilot & Unary (#361)

32e4064

* Update image for Unary * Fix forgotten renames Former-commit-id: 2b210ac

guptasu pushed a commit to guptasu/istio that referenced this pull request Jun 11, 2018

Add proto for authentication policy. (istio#361)

ffa742d

howardjohn pushed a commit to howardjohn/istio that referenced this pull request Jan 12, 2020

Update CoreDNS version to a more recent one (istio#361)

d5af31c

* Update CoreDNS version to a more recent one * Revert Chart version back

howardjohn pushed a commit to howardjohn/istio that referenced this pull request Jan 12, 2020

Update common files. (istio#361)

e27c7dd

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Update images for Pilot & Unary #361

Update images for Pilot & Unary #361

Uh oh!

sebastienvas commented Jun 6, 2017

Uh oh!

ldemailly left a comment

Uh oh!

sebastienvas commented Jun 6, 2017 •

edited

Loading

Uh oh!

douglas-reid commented Jun 6, 2017

Uh oh!

douglas-reid commented Jun 6, 2017

Uh oh!

ldemailly commented Jun 6, 2017

Uh oh!

sebastienvas commented Jun 6, 2017

Uh oh!

douglas-reid commented Jun 6, 2017

Uh oh!

ldemailly commented Jun 6, 2017

Uh oh!

geeknoid commented Jun 6, 2017

Uh oh!

douglas-reid commented Jun 6, 2017

Uh oh!

ldemailly commented Jun 6, 2017

Uh oh!

Uh oh!

Update images for Pilot & Unary #361

Update images for Pilot & Unary #361

Uh oh!

Conversation

sebastienvas commented Jun 6, 2017

Uh oh!

ldemailly left a comment

Choose a reason for hiding this comment

Uh oh!

sebastienvas commented Jun 6, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

douglas-reid commented Jun 6, 2017

Uh oh!

douglas-reid commented Jun 6, 2017

Uh oh!

ldemailly commented Jun 6, 2017

Uh oh!

sebastienvas commented Jun 6, 2017

Uh oh!

douglas-reid commented Jun 6, 2017

Uh oh!

ldemailly commented Jun 6, 2017

Uh oh!

geeknoid commented Jun 6, 2017

Uh oh!

douglas-reid commented Jun 6, 2017

Uh oh!

ldemailly commented Jun 6, 2017

Uh oh!

Uh oh!

sebastienvas commented Jun 6, 2017 •

edited

Loading