Skip to content

fix broken link #335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 26, 2017
Merged

fix broken link #335

merged 1 commit into from
May 26, 2017

Conversation

frankbu
Copy link
Contributor

@frankbu frankbu commented May 26, 2017

No description provided.

@istio-testing
Copy link
Collaborator

Jenkins job istio/presubmit passed

Copy link
Member

@ldemailly ldemailly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty

@ldemailly ldemailly merged commit 9a37c6c into master May 26, 2017
@ldemailly ldemailly deleted the frankb-broken-link branch May 26, 2017 22:30
ldemailly pushed a commit that referenced this pull request Jun 8, 2017
* Rbac ingress (#320)

* Add ingresses/status to rbac

* fix bash'ism (#325)

* fix bash'ism

we tell people to `curl -L https://git.io/getIstio | sh -` so we can't use bash extentions
I was getting [[ unknown command on line 12, fixing this

* also updating comment

* updateVersion.sh to not modify templates (#229)

* istio install templates

* fix copy

* fix temp var

* []byte values

* fix linter errors

* comment out unused ca vars

* gofmt kubernetes.go

* fix macros

* fix kubeTest.sh

* move istio-auth-with-cluster-ca.yaml out of templates dir (#334)

* fix broken link (#335)

* fixing #321 (#336)

fixing broken links

* Getting master ready for beta (#322)

0.1.x -> 0.2.x

* Add v1/stable version (#351)

* Add v1/stable version

* Start of a local development directory (#337)

* initial skeleton notes for local dev

* tweaks

* adding the rules.yaml for local dev and updating the scripts

* Fixing English typo

* Also start to address dev getting started

Issue #348

* incorporated most of my noogler notes

* Adding the sample quota

* adding note about -v=5

for debug/verbose output

* Code review comments

* typo fix


will follow up with moving most of mixer/dev/development.md into this

* Moving most of mixer/doc/dev/development.md here (#352)

* Moving most of mixer/doc/dev/development.md here

https://github.com/istio/mixer/blob/master/doc/dev/development.md to
here with updates to make it a bit more generic than just mixer

* Also move conventions.md and performance.md here

* Review comments

And linking the conventions and perf docs

* minor update

* Manager -> pilot rename (#359)

* Manager -> Pilot

 git ls-files | grep -v tests/e2e|grep -v bookinfo| xargs -n 1 sed -i
.bak -e 's/Manager/Pilot/g'

As tests/e2e and bookinfo have other Manager unrelated to pilot

* manager -> pilot

 git ls-files | grep -v tests/e2e|grep -v bookinfo| xargs -n 1 sed -i
.bak -e 's/manager/pilot/g'

* Manual changes in e2e

* MANAGER to PILOT

git ls-files | xargs -n 1 sed -i .bak -e 's/MANAGER/PILOT/g'

and manually excluding some

* Rename yaml file too

* Last few selective renames

Last piece, only remaining ‘manager’ are:
```
ldemailly-macbookpro:istio ldemailly$ git grep -i manager
samples/apps/bookinfo/src/reviews/reviews-wlpcfg/servers/LibertyProjectS
erver/server.xml:    <featureManager>
samples/apps/bookinfo/src/reviews/reviews-wlpcfg/servers/LibertyProjectS
erver/server.xml:    </featureManager>
tests/e2e/README.md:### appManager.go
tests/e2e/README.md:`appManager` gather apps required for test into a
array and deploy them while setup()
tests/e2e/framework/BUILD:        "appManager.go",
tests/e2e/framework/appManager.go:// AppManager organize and deploy apps
tests/e2e/framework/appManager.go:type AppManager struct {
tests/e2e/framework/appManager.go:// NewAppManager create a new
AppManager
tests/e2e/framework/appManager.go:func NewAppManager(tmpDir, namespace
string, istioctl *Istioctl) *AppManager {
tests/e2e/framework/appManager.go:      return &AppManager{
tests/e2e/framework/appManager.go:func (am *AppManager)
generateAppYaml(a *App) error {
tests/e2e/framework/appManager.go:func (am *AppManager) deploy(a *App)
error {
tests/e2e/framework/appManager.go:func (am *AppManager) Setup() error {
tests/e2e/framework/appManager.go:func (am *AppManager) Teardown()
error {
tests/e2e/framework/appManager.go:func (am *AppManager) AddApp(a *App) {
tests/e2e/framework/framework.go:
c.Cleanup.RegisterCleanable(c.Kube.AppManager)
tests/e2e/framework/kubernetes.go:      pilotHub =
flag.String("pilot_hub", os.Getenv(pilotHubEnvVar), "Manager hub")
tests/e2e/framework/kubernetes.go:      pilotTag =
flag.String("pilot_tag", os.Getenv(pilotTagEnvVar), "Manager tag")
tests/e2e/framework/kubernetes.go:              "manager",
tests/e2e/framework/kubernetes.go:      // App Manager
tests/e2e/framework/kubernetes.go:      AppManager *AppManager
tests/e2e/framework/kubernetes.go:      a := NewAppManager(tmpDir,
*namespace, i)
tests/e2e/framework/kubernetes.go:              AppManager:       a,
tests/e2e/framework/kubernetes.go:      case "manager":
tests/e2e/tests/bookinfo/demo_test.go:
tc.Kube.AppManager.AddApp(demoApp)
tests/e2e/tests/mixer/mixer_test.go:
tc.Kube.AppManager.AddApp(demoApp)
```

* Review comment

changed flag from m to p

* make linter happy bin/fmt.sh + review updates

* show in logs url being used (#360)

A bit more info in logs for when download fails

* Update images for Pilot & Unary (#361)

* Update image for Unary

* Fix forgotten renames

* Disabling failing test until #365 is fixed (#366)

* Skip TestDenials

* Update format and linter to skip git files

* Using git ls-files instead of find

* Remove extra buildifier call

* missed manager->pilot rename and use lowercase -c for ca image (#363)

* Make shell utility functions variadic (#377)

This simplifies usage a bit by not requiring user to call fmt.Sprintf
themselves.

* Re-enable TestDenials

* Revert "Update images for Pilot & Unary (#361)"

This reverts commit 2b210ac.

* Revert "Getting master ready for beta (#322)"

This reverts commit 910a025.

* Update to latest version of manager
zenlint pushed a commit to zenlint/istio that referenced this pull request Aug 30, 2017
rshriram pushed a commit that referenced this pull request Oct 30, 2017
mandarjog pushed a commit that referenced this pull request Oct 31, 2017
* Rbac ingress (#320)

* Add ingresses/status to rbac

* fix bash'ism (#325)

* fix bash'ism

we tell people to `curl -L https://git.io/getIstio | sh -` so we can't use bash extentions
I was getting [[ unknown command on line 12, fixing this

* also updating comment

* updateVersion.sh to not modify templates (#229)

* istio install templates

* fix copy

* fix temp var

* []byte values

* fix linter errors

* comment out unused ca vars

* gofmt kubernetes.go

* fix macros

* fix kubeTest.sh

* move istio-auth-with-cluster-ca.yaml out of templates dir (#334)

* fix broken link (#335)

* fixing #321 (#336)

fixing broken links

* Getting master ready for beta (#322)

0.1.x -> 0.2.x

* Add v1/stable version (#351)

* Add v1/stable version

* Start of a local development directory (#337)

* initial skeleton notes for local dev

* tweaks

* adding the rules.yaml for local dev and updating the scripts

* Fixing English typo

* Also start to address dev getting started

Issue #348

* incorporated most of my noogler notes

* Adding the sample quota

* adding note about -v=5

for debug/verbose output

* Code review comments

* typo fix


will follow up with moving most of mixer/dev/development.md into this

* Moving most of mixer/doc/dev/development.md here (#352)

* Moving most of mixer/doc/dev/development.md here

https://github.com/istio/mixer/blob/master/doc/dev/development.md to
here with updates to make it a bit more generic than just mixer

* Also move conventions.md and performance.md here

* Review comments

And linking the conventions and perf docs

* minor update

* Manager -> pilot rename (#359)

* Manager -> Pilot

 git ls-files | grep -v tests/e2e|grep -v bookinfo| xargs -n 1 sed -i
.bak -e 's/Manager/Pilot/g'

As tests/e2e and bookinfo have other Manager unrelated to pilot

* manager -> pilot

 git ls-files | grep -v tests/e2e|grep -v bookinfo| xargs -n 1 sed -i
.bak -e 's/manager/pilot/g'

* Manual changes in e2e

* MANAGER to PILOT

git ls-files | xargs -n 1 sed -i .bak -e 's/MANAGER/PILOT/g'

and manually excluding some

* Rename yaml file too

* Last few selective renames

Last piece, only remaining ‘manager’ are:
```
ldemailly-macbookpro:istio ldemailly$ git grep -i manager
samples/apps/bookinfo/src/reviews/reviews-wlpcfg/servers/LibertyProjectS
erver/server.xml:    <featureManager>
samples/apps/bookinfo/src/reviews/reviews-wlpcfg/servers/LibertyProjectS
erver/server.xml:    </featureManager>
tests/e2e/README.md:### appManager.go
tests/e2e/README.md:`appManager` gather apps required for test into a
array and deploy them while setup()
tests/e2e/framework/BUILD:        "appManager.go",
tests/e2e/framework/appManager.go:// AppManager organize and deploy apps
tests/e2e/framework/appManager.go:type AppManager struct {
tests/e2e/framework/appManager.go:// NewAppManager create a new
AppManager
tests/e2e/framework/appManager.go:func NewAppManager(tmpDir, namespace
string, istioctl *Istioctl) *AppManager {
tests/e2e/framework/appManager.go:      return &AppManager{
tests/e2e/framework/appManager.go:func (am *AppManager)
generateAppYaml(a *App) error {
tests/e2e/framework/appManager.go:func (am *AppManager) deploy(a *App)
error {
tests/e2e/framework/appManager.go:func (am *AppManager) Setup() error {
tests/e2e/framework/appManager.go:func (am *AppManager) Teardown()
error {
tests/e2e/framework/appManager.go:func (am *AppManager) AddApp(a *App) {
tests/e2e/framework/framework.go:
c.Cleanup.RegisterCleanable(c.Kube.AppManager)
tests/e2e/framework/kubernetes.go:      pilotHub =
flag.String("pilot_hub", os.Getenv(pilotHubEnvVar), "Manager hub")
tests/e2e/framework/kubernetes.go:      pilotTag =
flag.String("pilot_tag", os.Getenv(pilotTagEnvVar), "Manager tag")
tests/e2e/framework/kubernetes.go:              "manager",
tests/e2e/framework/kubernetes.go:      // App Manager
tests/e2e/framework/kubernetes.go:      AppManager *AppManager
tests/e2e/framework/kubernetes.go:      a := NewAppManager(tmpDir,
*namespace, i)
tests/e2e/framework/kubernetes.go:              AppManager:       a,
tests/e2e/framework/kubernetes.go:      case "manager":
tests/e2e/tests/bookinfo/demo_test.go:
tc.Kube.AppManager.AddApp(demoApp)
tests/e2e/tests/mixer/mixer_test.go:
tc.Kube.AppManager.AddApp(demoApp)
```

* Review comment

changed flag from m to p

* make linter happy bin/fmt.sh + review updates

* show in logs url being used (#360)

A bit more info in logs for when download fails

* Update images for Pilot & Unary (#361)

* Update image for Unary

* Fix forgotten renames

* Disabling failing test until #365 is fixed (#366)

* Skip TestDenials

* Update format and linter to skip git files

* Using git ls-files instead of find

* Remove extra buildifier call

* missed manager->pilot rename and use lowercase -c for ca image (#363)

* Make shell utility functions variadic (#377)

This simplifies usage a bit by not requiring user to call fmt.Sprintf
themselves.

* Re-enable TestDenials

* Revert "Update images for Pilot & Unary (#361)"

This reverts commit 6362d37 [formerly 2b210ac].

* Revert "Getting master ready for beta (#322)"

This reverts commit 52e8937 [formerly 910a025].

* Update to latest version of manager

Former-commit-id: 6a65da1
mandarjog pushed a commit that referenced this pull request Nov 2, 2017
kyessenov pushed a commit to kyessenov/istio that referenced this pull request Aug 13, 2018
Automatic merge from submit-queue.

[DO NOT MERGE] Auto PR to update dependencies of mixerclient

This PR will be merged automatically once checks are successful.
```release-note
none
```
howardjohn added a commit to howardjohn/istio that referenced this pull request Jan 12, 2020
Fix two minor things:
* Citadel needs permissions for ns
* Tracing typo in image name

Everything else in this PR is just junk from run the targets to regen
config
howardjohn pushed a commit to howardjohn/istio that referenced this pull request Jan 12, 2020
bmangoen pushed a commit to bmangoen/istio that referenced this pull request Apr 18, 2025
When using istio as a pure Gateway API Ingress provider the
CA Bundle is only required where a Gateway exist. Avoid
spreading them out across all namespaces.

A flag has been added to enable the Gateway only behavior which also disables
the Namespace level injection. The new Gateway GA Controller behaves similar to
NamespaceController but watches primarly Gateway objects instead of Namespaces.
dgn pushed a commit to dgn/istio that referenced this pull request Jun 24, 2025
…stio#335)

When using istio as a pure Gateway API Ingress provider the
CA Bundle is only required where a Gateway exist. Avoid
spreading them out across all namespaces.

A flag has been added to enable the Gateway only behavior which also disables
the Namespace level injection. The new Gateway GA Controller behaves similar to
NamespaceController but watches primarly Gateway objects instead of Namespaces.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants