Start of a local development directory #337

ldemailly · 2017-05-27T00:11:16Z

with the scripts I'm using on a raw VM

those are more sample/examples than anything close to production grade but it's a start compared to nothing I think (and let's me have a backup for them)

Edit: now also addressing #348 aka early dev startup guide

ldemailly · 2017-05-27T00:20:19Z

devel/rules.yml

@@ -0,0 +1,57 @@
+subject: namespace:ns


used https://github.com/istio/istio/pull/337/files#diff-ad310135e477fb2632b2043cc24c646fR4
and it same as the one in mixer/testdata minus the attributes

istio-testing · 2017-05-27T00:35:09Z

Jenkins job istio/presubmit passed

istio-testing · 2017-05-27T00:43:23Z

Jenkins job istio/presubmit passed

istio-testing · 2017-05-30T22:07:15Z

Jenkins job istio/presubmit passed

Issue #348

istio-testing · 2017-05-30T22:36:03Z

Jenkins job istio/presubmit passed

for debug/verbose output

istio-testing · 2017-05-31T01:26:24Z

Jenkins job istio/presubmit passed

ldemailly · 2017-05-31T01:26:38Z

devel/update_all

+cd ../proxy
+bazel build src/envoy/mixer:envoy
+cd ../mixer
+bazel build ...


what is a more minimal target ?

For Mixer, you could build

cmd/server

And that'll produce mixs and nothing else.

thanks ! looks like bazel build cmd/server:mixs is the target (without :mixs it tries to build server:server which doesn't exist)

istio-testing · 2017-05-31T01:36:56Z

Jenkins job istio/presubmit passed

istio-testing · 2017-05-31T01:51:26Z

Jenkins job istio/presubmit passed

geeknoid · 2017-05-31T15:17:42Z

devel/README.md

@@ -0,0 +1,54 @@
+# Developing on Istio


geeknoid · 2017-05-31T15:18:03Z

devel/README.md

+See also the [broker](https://github.com/istio/broker/blob/master/doc/dev/development.md) and [mixer](https://github.com/istio/mixer/blob/master/doc/dev/development.md)
+development setup and guidelines
+
+## Collection of scripts and notes for developing on Istio


geeknoid · 2017-05-31T15:19:37Z

devel/README.md

+   wrk http://localhost:9090/echo
+
+   ```
+   Note that this is done for you by [steup_run](setup_run) but to use the correct go environment:


steup -> setup

Forgot this typo...

geeknoid · 2017-05-31T15:20:38Z

devel/README.md

+
+Get GitHub desktop https://desktop.github.com/
+
+If you want to make changes to the [website](https://github.com/istio/istio.github.io), and want to run jekyll locally and natively, without docker):


DO we need this? The docker variation is very stable and avoids dealing with Ruby stuff. I'd rather remove this option from our docs.

well it's much lighter running natively and only 1 paragraph, I had that in my notes and think it may be useful to someone else - I'd like eventually to run everything natively on the mac btw (low pri but still)

geeknoid · 2017-05-31T15:22:04Z

devel/update_all

+cd ../proxy
+bazel build src/envoy/mixer:envoy
+cd ../mixer
+bazel build ...


For Mixer, you could build

cmd/server

And that'll produce mixs and nothing else.

geeknoid · 2017-05-31T15:22:33Z

README.md

@@ -86,6 +86,8 @@ decisions to the mixer.
 See the [contribution guidelines](CONTRIBUTING.md) for information on how to
 participate in the Istio project by submitting pull requests or issues. 

+You can then check out how to be [setup for development](devel/README.md).


to be -> to

geeknoid · 2017-05-31T15:24:19Z

devel/README.md

@@ -0,0 +1,54 @@
+# Developing on Istio
+
+See also the [broker](https://github.com/istio/broker/blob/master/doc/dev/development.md) and [mixer](https://github.com/istio/mixer/blob/master/doc/dev/development.md)


These two files are nearly identical. I just cut & pasted them last week. I think a lot of their content could be moved here and slightly generalized so it applies to all repos. They talk about the GitHub flow for example, which should be the same for all our repos. So I think we should pull common info out of these two docs and pour into here. We can do this in a separate PR or this one, but I think that should be the goal here...

yes I agree - given we can't do cross repo PR let me get this skeleton in first and then I'll move the content?

frankbu

What about manager? Manager needs to be included in these instructions.

ldemailly · 2017-05-31T15:55:14Z

@frankbu my (limited) understanding is that manager sets up files which get pushed locally - when developing locally you don't need it - but if you have instructions on building/using manager locally, I am happy to add them (or maybe in future PR?)

istio-testing · 2017-05-31T16:23:20Z

Jenkins job istio/presubmit passed

geeknoid · 2017-05-31T16:46:16Z

devel/README.md

+   wrk http://localhost:9090/echo
+
+   ```
+   Note that this is done for you by [steup_run](setup_run) but to use the correct go environment:


Forgot this typo...

istio-testing · 2017-05-31T17:33:47Z

Jenkins job istio/presubmit passed

istio-testing · 2017-05-31T18:36:08Z

Jenkins job istio/presubmit passed

* Rbac ingress (#320) * Add ingresses/status to rbac * fix bash'ism (#325) * fix bash'ism we tell people to `curl -L https://git.io/getIstio | sh -` so we can't use bash extentions I was getting [[ unknown command on line 12, fixing this * also updating comment * updateVersion.sh to not modify templates (#229) * istio install templates * fix copy * fix temp var * []byte values * fix linter errors * comment out unused ca vars * gofmt kubernetes.go * fix macros * fix kubeTest.sh * move istio-auth-with-cluster-ca.yaml out of templates dir (#334) * fix broken link (#335) * fixing #321 (#336) fixing broken links * Getting master ready for beta (#322) 0.1.x -> 0.2.x * Add v1/stable version (#351) * Add v1/stable version * Start of a local development directory (#337) * initial skeleton notes for local dev * tweaks * adding the rules.yaml for local dev and updating the scripts * Fixing English typo * Also start to address dev getting started Issue #348 * incorporated most of my noogler notes * Adding the sample quota * adding note about -v=5 for debug/verbose output * Code review comments * typo fix will follow up with moving most of mixer/dev/development.md into this * Moving most of mixer/doc/dev/development.md here (#352) * Moving most of mixer/doc/dev/development.md here https://github.com/istio/mixer/blob/master/doc/dev/development.md to here with updates to make it a bit more generic than just mixer * Also move conventions.md and performance.md here * Review comments And linking the conventions and perf docs * minor update * Manager -> pilot rename (#359) * Manager -> Pilot git ls-files | grep -v tests/e2e|grep -v bookinfo| xargs -n 1 sed -i .bak -e 's/Manager/Pilot/g' As tests/e2e and bookinfo have other Manager unrelated to pilot * manager -> pilot git ls-files | grep -v tests/e2e|grep -v bookinfo| xargs -n 1 sed -i .bak -e 's/manager/pilot/g' * Manual changes in e2e * MANAGER to PILOT git ls-files | xargs -n 1 sed -i .bak -e 's/MANAGER/PILOT/g' and manually excluding some * Rename yaml file too * Last few selective renames Last piece, only remaining ‘manager’ are: ``` ldemailly-macbookpro:istio ldemailly$ git grep -i manager samples/apps/bookinfo/src/reviews/reviews-wlpcfg/servers/LibertyProjectS erver/server.xml: <featureManager> samples/apps/bookinfo/src/reviews/reviews-wlpcfg/servers/LibertyProjectS erver/server.xml: </featureManager> tests/e2e/README.md:### appManager.go tests/e2e/README.md:`appManager` gather apps required for test into a array and deploy them while setup() tests/e2e/framework/BUILD: "appManager.go", tests/e2e/framework/appManager.go:// AppManager organize and deploy apps tests/e2e/framework/appManager.go:type AppManager struct { tests/e2e/framework/appManager.go:// NewAppManager create a new AppManager tests/e2e/framework/appManager.go:func NewAppManager(tmpDir, namespace string, istioctl *Istioctl) *AppManager { tests/e2e/framework/appManager.go: return &AppManager{ tests/e2e/framework/appManager.go:func (am *AppManager) generateAppYaml(a *App) error { tests/e2e/framework/appManager.go:func (am *AppManager) deploy(a *App) error { tests/e2e/framework/appManager.go:func (am *AppManager) Setup() error { tests/e2e/framework/appManager.go:func (am *AppManager) Teardown() error { tests/e2e/framework/appManager.go:func (am *AppManager) AddApp(a *App) { tests/e2e/framework/framework.go: c.Cleanup.RegisterCleanable(c.Kube.AppManager) tests/e2e/framework/kubernetes.go: pilotHub = flag.String("pilot_hub", os.Getenv(pilotHubEnvVar), "Manager hub") tests/e2e/framework/kubernetes.go: pilotTag = flag.String("pilot_tag", os.Getenv(pilotTagEnvVar), "Manager tag") tests/e2e/framework/kubernetes.go: "manager", tests/e2e/framework/kubernetes.go: // App Manager tests/e2e/framework/kubernetes.go: AppManager *AppManager tests/e2e/framework/kubernetes.go: a := NewAppManager(tmpDir, *namespace, i) tests/e2e/framework/kubernetes.go: AppManager: a, tests/e2e/framework/kubernetes.go: case "manager": tests/e2e/tests/bookinfo/demo_test.go: tc.Kube.AppManager.AddApp(demoApp) tests/e2e/tests/mixer/mixer_test.go: tc.Kube.AppManager.AddApp(demoApp) ``` * Review comment changed flag from m to p * make linter happy bin/fmt.sh + review updates * show in logs url being used (#360) A bit more info in logs for when download fails * Update images for Pilot & Unary (#361) * Update image for Unary * Fix forgotten renames * Disabling failing test until #365 is fixed (#366) * Skip TestDenials * Update format and linter to skip git files * Using git ls-files instead of find * Remove extra buildifier call * missed manager->pilot rename and use lowercase -c for ca image (#363) * Make shell utility functions variadic (#377) This simplifies usage a bit by not requiring user to call fmt.Sprintf themselves. * Re-enable TestDenials * Revert "Update images for Pilot & Unary (#361)" This reverts commit 2b210ac. * Revert "Getting master ready for beta (#322)" This reverts commit 910a025. * Update to latest version of manager

… was trying to pop one too many parent directories.

* initial skeleton notes for local dev * tweaks * adding the rules.yaml for local dev and updating the scripts * Fixing English typo * Also start to address dev getting started Issue #348 * incorporated most of my noogler notes * Adding the sample quota * adding note about -v=5 for debug/verbose output * Code review comments * typo fix will follow up with moving most of mixer/dev/development.md into this Former-commit-id: 496821c

* Rbac ingress (#320) * Add ingresses/status to rbac * fix bash'ism (#325) * fix bash'ism we tell people to `curl -L https://git.io/getIstio | sh -` so we can't use bash extentions I was getting [[ unknown command on line 12, fixing this * also updating comment * updateVersion.sh to not modify templates (#229) * istio install templates * fix copy * fix temp var * []byte values * fix linter errors * comment out unused ca vars * gofmt kubernetes.go * fix macros * fix kubeTest.sh * move istio-auth-with-cluster-ca.yaml out of templates dir (#334) * fix broken link (#335) * fixing #321 (#336) fixing broken links * Getting master ready for beta (#322) 0.1.x -> 0.2.x * Add v1/stable version (#351) * Add v1/stable version * Start of a local development directory (#337) * initial skeleton notes for local dev * tweaks * adding the rules.yaml for local dev and updating the scripts * Fixing English typo * Also start to address dev getting started Issue #348 * incorporated most of my noogler notes * Adding the sample quota * adding note about -v=5 for debug/verbose output * Code review comments * typo fix will follow up with moving most of mixer/dev/development.md into this * Moving most of mixer/doc/dev/development.md here (#352) * Moving most of mixer/doc/dev/development.md here https://github.com/istio/mixer/blob/master/doc/dev/development.md to here with updates to make it a bit more generic than just mixer * Also move conventions.md and performance.md here * Review comments And linking the conventions and perf docs * minor update * Manager -> pilot rename (#359) * Manager -> Pilot git ls-files | grep -v tests/e2e|grep -v bookinfo| xargs -n 1 sed -i .bak -e 's/Manager/Pilot/g' As tests/e2e and bookinfo have other Manager unrelated to pilot * manager -> pilot git ls-files | grep -v tests/e2e|grep -v bookinfo| xargs -n 1 sed -i .bak -e 's/manager/pilot/g' * Manual changes in e2e * MANAGER to PILOT git ls-files | xargs -n 1 sed -i .bak -e 's/MANAGER/PILOT/g' and manually excluding some * Rename yaml file too * Last few selective renames Last piece, only remaining ‘manager’ are: ``` ldemailly-macbookpro:istio ldemailly$ git grep -i manager samples/apps/bookinfo/src/reviews/reviews-wlpcfg/servers/LibertyProjectS erver/server.xml: <featureManager> samples/apps/bookinfo/src/reviews/reviews-wlpcfg/servers/LibertyProjectS erver/server.xml: </featureManager> tests/e2e/README.md:### appManager.go tests/e2e/README.md:`appManager` gather apps required for test into a array and deploy them while setup() tests/e2e/framework/BUILD: "appManager.go", tests/e2e/framework/appManager.go:// AppManager organize and deploy apps tests/e2e/framework/appManager.go:type AppManager struct { tests/e2e/framework/appManager.go:// NewAppManager create a new AppManager tests/e2e/framework/appManager.go:func NewAppManager(tmpDir, namespace string, istioctl *Istioctl) *AppManager { tests/e2e/framework/appManager.go: return &AppManager{ tests/e2e/framework/appManager.go:func (am *AppManager) generateAppYaml(a *App) error { tests/e2e/framework/appManager.go:func (am *AppManager) deploy(a *App) error { tests/e2e/framework/appManager.go:func (am *AppManager) Setup() error { tests/e2e/framework/appManager.go:func (am *AppManager) Teardown() error { tests/e2e/framework/appManager.go:func (am *AppManager) AddApp(a *App) { tests/e2e/framework/framework.go: c.Cleanup.RegisterCleanable(c.Kube.AppManager) tests/e2e/framework/kubernetes.go: pilotHub = flag.String("pilot_hub", os.Getenv(pilotHubEnvVar), "Manager hub") tests/e2e/framework/kubernetes.go: pilotTag = flag.String("pilot_tag", os.Getenv(pilotTagEnvVar), "Manager tag") tests/e2e/framework/kubernetes.go: "manager", tests/e2e/framework/kubernetes.go: // App Manager tests/e2e/framework/kubernetes.go: AppManager *AppManager tests/e2e/framework/kubernetes.go: a := NewAppManager(tmpDir, *namespace, i) tests/e2e/framework/kubernetes.go: AppManager: a, tests/e2e/framework/kubernetes.go: case "manager": tests/e2e/tests/bookinfo/demo_test.go: tc.Kube.AppManager.AddApp(demoApp) tests/e2e/tests/mixer/mixer_test.go: tc.Kube.AppManager.AddApp(demoApp) ``` * Review comment changed flag from m to p * make linter happy bin/fmt.sh + review updates * show in logs url being used (#360) A bit more info in logs for when download fails * Update images for Pilot & Unary (#361) * Update image for Unary * Fix forgotten renames * Disabling failing test until #365 is fixed (#366) * Skip TestDenials * Update format and linter to skip git files * Using git ls-files instead of find * Remove extra buildifier call * missed manager->pilot rename and use lowercase -c for ca image (#363) * Make shell utility functions variadic (#377) This simplifies usage a bit by not requiring user to call fmt.Sprintf themselves. * Re-enable TestDenials * Revert "Update images for Pilot & Unary (#361)" This reverts commit 6362d37 [formerly 2b210ac]. * Revert "Getting master ready for beta (#322)" This reverts commit 52e8937 [formerly 910a025]. * Update to latest version of manager Former-commit-id: 6a65da1

* Add postsubmit test run with debug mode * Fix linter * Defer body close always * Update proxy with mixer client race fix * Add an option to skip access log check

* initial skeleton notes for local dev * tweaks * adding the rules.yaml for local dev and updating the scripts * Fixing English typo * Also start to address dev getting started Issue #348 * incorporated most of my noogler notes * Adding the sample quota * adding note about -v=5 for debug/verbose output * Code review comments * typo fix will follow up with moving most of mixer/dev/development.md into this Former-commit-id: 496821c

Fixed a typo.

Automatic merge from submit-queue. [DO NOT MERGE] Auto PR to update dependencies of mixerclient This PR will be merged automatically once checks are successful. ```release-note none ```

It will be primarily invoked by a prow job. Currently it fetches updates from maistra/api only, but can be extended in the future.

ldemailly added 4 commits May 26, 2017 23:27

initial skeleton notes for local dev

b6c1017

tweaks

fb598c0

Merge branch 'master' of github.com:istio/istio into local_dev

8846efa

adding the rules.yaml for local dev and updating the scripts

5a91f17

googlebot added the cla: yes label May 27, 2017

Fixing English typo

a12f129

ldemailly commented May 27, 2017

View reviewed changes

ldemailly requested a review from costinm May 30, 2017 21:18

Merge branch 'master' into local_dev

67d11ba

Also start to address dev getting started

d1fb6d1

Issue #348

ldemailly and others added 2 commits May 30, 2017 18:01

incorporated most of my noogler notes

93eecc8

Adding the sample quota

8a7d419

ldemailly requested a review from geeknoid May 31, 2017 01:10

ldemailly self-assigned this May 31, 2017

adding note about -v=5

fbacf79

for debug/verbose output

ldemailly commented May 31, 2017

View reviewed changes

geeknoid suggested changes May 31, 2017

View reviewed changes

frankbu suggested changes May 31, 2017

View reviewed changes

Code review comments

9c45a11

geeknoid approved these changes May 31, 2017

View reviewed changes

typo fix

6ce77e8

Merge branch 'master' into local_dev

8a04264

ldemailly merged commit 496821c into master May 31, 2017

rshriram deleted the local_dev branch June 2, 2017 02:25

zenlint pushed a commit to zenlint/istio that referenced this pull request Aug 30, 2017

Fix broken link to concept explanation for Mixer (istio#337)

9d93f77

… was trying to pop one too many parent directories.

mandarjog pushed a commit that referenced this pull request Oct 31, 2017

Add postsubmit test run with debug mode (#337)

97d966b

* Add postsubmit test run with debug mode * Fix linter * Defer body close always * Update proxy with mixer client race fix * Add an option to skip access log check

guptasu pushed a commit to guptasu/istio that referenced this pull request Jun 11, 2018

Update STYLE-GUIDE.md (istio#337)

0ed25dc

Fixed a typo.

luksa pushed a commit to luksa/istio that referenced this pull request Jun 30, 2021

MAISTRA-2346: Add script to update maistra deps (istio#337)

53da2dc

It will be primarily invoked by a prow job. Currently it fetches updates from maistra/api only, but can be extended in the future.

luksa pushed a commit to luksa/istio that referenced this pull request Feb 22, 2022

[misc] MAISTRA-2346: Add script to update maistra deps (istio#337)

b41bcc8

It will be primarily invoked by a prow job. Currently it fetches updates from maistra/api only, but can be extended in the future.

luksa pushed a commit to luksa/istio that referenced this pull request Apr 29, 2022

[misc] MAISTRA-2346: Add script to update maistra deps (istio#337)

5c66a94

It will be primarily invoked by a prow job. Currently it fetches updates from maistra/api only, but can be extended in the future.

luksa pushed a commit to luksa/istio that referenced this pull request Sep 15, 2022

[misc] MAISTRA-2346: Add script to update maistra deps (istio#337)

acd7d9e

It will be primarily invoked by a prow job. Currently it fetches updates from maistra/api only, but can be extended in the future.

luksa pushed a commit to luksa/istio that referenced this pull request Apr 11, 2024

[misc] MAISTRA-2346: Add script to update maistra deps (istio#337)

0dbe9de

It will be primarily invoked by a prow job. Currently it fetches updates from maistra/api only, but can be extended in the future.

dgn pushed a commit to dgn/istio that referenced this pull request Jun 13, 2024

MAISTRA-2346: Add script to update maistra deps (istio#337)

ce69488

It will be primarily invoked by a prow job. Currently it fetches updates from maistra/api only, but can be extended in the future.


		Get GitHub desktop https://desktop.github.com/

		If you want to make changes to the [website](https://github.com/istio/istio.github.io), and want to run jekyll locally and natively, without docker):

		@@ -0,0 +1,54 @@
		# Developing on Istio

		See also the [broker](https://github.com/istio/broker/blob/master/doc/dev/development.md) and [mixer](https://github.com/istio/mixer/blob/master/doc/dev/development.md)

Start of a local development directory #337

Start of a local development directory #337

Uh oh!

Conversation

ldemailly commented May 27, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

istio-testing commented May 27, 2017

Uh oh!

istio-testing commented May 27, 2017

Uh oh!

istio-testing commented May 30, 2017

Uh oh!

istio-testing commented May 30, 2017

Uh oh!

istio-testing commented May 31, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

istio-testing commented May 31, 2017

Uh oh!

istio-testing commented May 31, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ldemailly May 31, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

frankbu left a comment

Choose a reason for hiding this comment

Uh oh!

ldemailly commented May 31, 2017

Uh oh!

istio-testing commented May 31, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

istio-testing commented May 31, 2017

Uh oh!

istio-testing commented May 31, 2017

Uh oh!

Uh oh!

ldemailly commented May 27, 2017 •

edited

Loading

ldemailly May 31, 2017 •

edited

Loading