go formating #140
Merged
go formating #140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jenkins job istio/presubmit passed |
|
Jenkins job istio/presubmit passed |
sebastienvas
added a commit
that referenced
this pull request
May 4, 2017
* Initial version * Refactor for better testing * Update framework for testing and added test * Bazelify istio * Simplified interfaces * Refactor code to use Cleanable interface * go formating (#140) * go formating * Updated Jenkinsfile to run tests * Separate TestInfo to another module (#144) * Separete TestInfo to another module Implemented status file creation Implemented log upload to cloud storage Rename SetUp to Setup and TearDown to Teardown * Add more info in TestStatus * Rename InitLogging to InitGlog * Resolving comments * Return skipDir error on err * Adding Code Checks + Fix them (#151) * Not uploading logs_bucket_path flag is unset * Added code checks * Fix linter errors * Update Jenkins to use a goBuildNode * e2e test: Create namespace and deploy istio core and test app (#145) * Create namespace and deploy namespace * Get runtime source path * Correct pr comments, add GetGateWay() * Add default route test * Add version routing tests, fix linter and fix comments on pr * Add fault delay test and fix comments * Add version migration test * Add Hop App + testing (#162) * Implemented echo App * Adding test + refactoring * Added more tests * Resolved review comments * Use slices instead of pointers to slices * Fix formatting * Merge master to e2e (#165) * update version for testing (#147) Also update quota descriptors * Update copyright. * use lowercase zipkin trace headers (#152) * Add support for 1.6 with RBAC and change install to use one file. (#150) * Added RBAC roles and bindings * Script to generate merged configs for 1.5 and 1.6 - the 1.6 works wit rbac on or off. To avoid confusion, auth will be added in separate PR * Update the tag for manager/proxy containers * Port forward manager service and enable istio manager env var Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * Run service port-forward in the background and tidy it up Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * Add yaml template for manager into istio-16.yaml * Remove errant local Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * Add apiserver to istio manager deploy Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * added egress proxy to istio install folder to be referenced by istio.io docs * bug fix * Remove apiserver address Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * Add apiserver and egress * Small doc updates. (#163) * Demo test update + Docker file creation for Hop App (#172) * Renamed default env const * Added support for server update for version * Added a binary for Hop + Docker Image * WIP * Modified kubernetes setup + demo test * Fixed Jenkinsfile * Fix comments * Fix format * Removing app_flag as set directly in template * Fixed resp.close() was called on empty resp * Moved test to their own folder * Fixes e2e.sh * Make e2e.sh more verbose * Merge from istio:master, change install source to istio-install and setup istioctl (#175) * update version for testing (#147) Also update quota descriptors * Update copyright. * use lowercase zipkin trace headers (#152) * Add support for 1.6 with RBAC and change install to use one file. (#150) * Added RBAC roles and bindings * Script to generate merged configs for 1.5 and 1.6 - the 1.6 works wit rbac on or off. To avoid confusion, auth will be added in separate PR * Update the tag for manager/proxy containers * Port forward manager service and enable istio manager env var Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * Run service port-forward in the background and tidy it up Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * Add yaml template for manager into istio-16.yaml * Remove errant local Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * Add apiserver to istio manager deploy Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * added egress proxy to istio install folder to be referenced by istio.io docs * bug fix * Separate Istio CA installation from default. Istio CA should not be installed by default. Created istio-cluster-ca.yaml and istio-namespace-ca.yaml for deploying the per-cluster and per-namespace CAs, so that users do not need to modify the files for different use cases. * Remove apiserver address Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * Add apiserver and egress * Fix Istio CA files to create namespace. * Update one-off auth yaml files. * Small doc updates. (#163) * Improve Istio one-off yaml files for Istio auth. * Fix links. * Up the blanked rl to 5000, so it does not interfere with tests (#167) * Rename istio-ingress-controller to istio-ingress * Changed labels for ingress and ingress * update to rule schema to reflect switch from double to duration (#168) * update to rule schema to reflect switch from double to duration * pointed to my dockerhub * Updating istio version * Regenerate * Change in scripts * Install istio from istio-install, add os x support and add setupIstioctl * fix lineter * Get rule files from demos/apps, istioctl cleanable and comments fix * small change * appManager cleanablization * Merge master to e2e (#181) * update version for testing (#147) Also update quota descriptors * Update copyright. * use lowercase zipkin trace headers (#152) * Add support for 1.6 with RBAC and change install to use one file. (#150) * Added RBAC roles and bindings * Script to generate merged configs for 1.5 and 1.6 - the 1.6 works wit rbac on or off. To avoid confusion, auth will be added in separate PR * Update the tag for manager/proxy containers * Port forward manager service and enable istio manager env var Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * Run service port-forward in the background and tidy it up Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * Add yaml template for manager into istio-16.yaml * Remove errant local Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * Add apiserver to istio manager deploy Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * added egress proxy to istio install folder to be referenced by istio.io docs * bug fix * Separate Istio CA installation from default. Istio CA should not be installed by default. Created istio-cluster-ca.yaml and istio-namespace-ca.yaml for deploying the per-cluster and per-namespace CAs, so that users do not need to modify the files for different use cases. * Remove apiserver address Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * Add apiserver and egress * Fix Istio CA files to create namespace. * Update one-off auth yaml files. * Small doc updates. (#163) * Improve Istio one-off yaml files for Istio auth. * Fix links. * Up the blanked rl to 5000, so it does not interfere with tests (#167) * Rename istio-ingress-controller to istio-ingress * Changed labels for ingress and ingress * update to rule schema to reflect switch from double to duration (#168) * update to rule schema to reflect switch from double to duration * pointed to my dockerhub * Updating istio version * Regenerate * Change in scripts * update to gcr.io/istio-testing versions (#170) 1. Update mixer, manager, proxy versions to include rate limit fixes 2. Remove mixer configmap. The default config is now baked inside mixer. 3. expose mixer metrics and configapi ports thru port forwarding. 4. Add "wrk" for testing. drive traffic and fetch metrics as a setup for full 5. ratelimit integration test. That PR will follow. * Add ingress service for correct status IP * Support for istio-ca in tests/updateVersion.sh (#180) * Update updateVersion.sh to take into account istio-ca * Updates with updateVersion.sh * Create README.md for e2e test framework (#182) * Create README.md for e2e test framework * small change
mandarjog
pushed a commit
to mandarjog/istio
that referenced
this pull request
Oct 30, 2017
* Add logger aspect to the mixer. This adds a basic aspect with a Log([]Entry) interface to be implemented by various adapters. A simple manager is provided for downscoping to an Entry from the attribute.Bag based on the configured Input attributes. Tested with: pkg/aspectsupport/logger$ bazel test ... Test coverage: 90%. * Fix date and log msg caps. * Rename BUILD fule for test and make cosmetic changes (comments). Former-commit-id: f7ad513aad07e4355dce28cbb1e919f401bd7b5e
rshriram
pushed a commit
that referenced
this pull request
Oct 30, 2017
* Initial version * Refactor for better testing * Update framework for testing and added test * Bazelify istio * Simplified interfaces * Refactor code to use Cleanable interface * go formating (#140) * go formating * Updated Jenkinsfile to run tests * Separate TestInfo to another module (#144) * Separete TestInfo to another module Implemented status file creation Implemented log upload to cloud storage Rename SetUp to Setup and TearDown to Teardown * Add more info in TestStatus * Rename InitLogging to InitGlog * Resolving comments * Return skipDir error on err * Adding Code Checks + Fix them (#151) * Not uploading logs_bucket_path flag is unset * Added code checks * Fix linter errors * Update Jenkins to use a goBuildNode * e2e test: Create namespace and deploy istio core and test app (#145) * Create namespace and deploy namespace * Get runtime source path * Correct pr comments, add GetGateWay() * Add default route test * Add version routing tests, fix linter and fix comments on pr * Add fault delay test and fix comments * Add version migration test * Add Hop App + testing (#162) * Implemented echo App * Adding test + refactoring * Added more tests * Resolved review comments * Use slices instead of pointers to slices * Fix formatting * Merge master to e2e (#165) * update version for testing (#147) Also update quota descriptors * Update copyright. * use lowercase zipkin trace headers (#152) * Add support for 1.6 with RBAC and change install to use one file. (#150) * Added RBAC roles and bindings * Script to generate merged configs for 1.5 and 1.6 - the 1.6 works wit rbac on or off. To avoid confusion, auth will be added in separate PR * Update the tag for manager/proxy containers * Port forward manager service and enable istio manager env var Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * Run service port-forward in the background and tidy it up Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * Add yaml template for manager into istio-16.yaml * Remove errant local Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * Add apiserver to istio manager deploy Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * added egress proxy to istio install folder to be referenced by istio.io docs * bug fix * Remove apiserver address Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * Add apiserver and egress * Small doc updates. (#163) * Demo test update + Docker file creation for Hop App (#172) * Renamed default env const * Added support for server update for version * Added a binary for Hop + Docker Image * WIP * Modified kubernetes setup + demo test * Fixed Jenkinsfile * Fix comments * Fix format * Removing app_flag as set directly in template * Fixed resp.close() was called on empty resp * Moved test to their own folder * Fixes e2e.sh * Make e2e.sh more verbose * Merge from istio:master, change install source to istio-install and setup istioctl (#175) * update version for testing (#147) Also update quota descriptors * Update copyright. * use lowercase zipkin trace headers (#152) * Add support for 1.6 with RBAC and change install to use one file. (#150) * Added RBAC roles and bindings * Script to generate merged configs for 1.5 and 1.6 - the 1.6 works wit rbac on or off. To avoid confusion, auth will be added in separate PR * Update the tag for manager/proxy containers * Port forward manager service and enable istio manager env var Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * Run service port-forward in the background and tidy it up Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * Add yaml template for manager into istio-16.yaml * Remove errant local Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * Add apiserver to istio manager deploy Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * added egress proxy to istio install folder to be referenced by istio.io docs * bug fix * Separate Istio CA installation from default. Istio CA should not be installed by default. Created istio-cluster-ca.yaml and istio-namespace-ca.yaml for deploying the per-cluster and per-namespace CAs, so that users do not need to modify the files for different use cases. * Remove apiserver address Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * Add apiserver and egress * Fix Istio CA files to create namespace. * Update one-off auth yaml files. * Small doc updates. (#163) * Improve Istio one-off yaml files for Istio auth. * Fix links. * Up the blanked rl to 5000, so it does not interfere with tests (#167) * Rename istio-ingress-controller to istio-ingress * Changed labels for ingress and ingress * update to rule schema to reflect switch from double to duration (#168) * update to rule schema to reflect switch from double to duration * pointed to my dockerhub * Updating istio version * Regenerate * Change in scripts * Install istio from istio-install, add os x support and add setupIstioctl * fix lineter * Get rule files from demos/apps, istioctl cleanable and comments fix * small change * appManager cleanablization * Merge master to e2e (#181) * update version for testing (#147) Also update quota descriptors * Update copyright. * use lowercase zipkin trace headers (#152) * Add support for 1.6 with RBAC and change install to use one file. (#150) * Added RBAC roles and bindings * Script to generate merged configs for 1.5 and 1.6 - the 1.6 works wit rbac on or off. To avoid confusion, auth will be added in separate PR * Update the tag for manager/proxy containers * Port forward manager service and enable istio manager env var Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * Run service port-forward in the background and tidy it up Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * Add yaml template for manager into istio-16.yaml * Remove errant local Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * Add apiserver to istio manager deploy Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * added egress proxy to istio install folder to be referenced by istio.io docs * bug fix * Separate Istio CA installation from default. Istio CA should not be installed by default. Created istio-cluster-ca.yaml and istio-namespace-ca.yaml for deploying the per-cluster and per-namespace CAs, so that users do not need to modify the files for different use cases. * Remove apiserver address Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * Add apiserver and egress * Fix Istio CA files to create namespace. * Update one-off auth yaml files. * Small doc updates. (#163) * Improve Istio one-off yaml files for Istio auth. * Fix links. * Up the blanked rl to 5000, so it does not interfere with tests (#167) * Rename istio-ingress-controller to istio-ingress * Changed labels for ingress and ingress * update to rule schema to reflect switch from double to duration (#168) * update to rule schema to reflect switch from double to duration * pointed to my dockerhub * Updating istio version * Regenerate * Change in scripts * update to gcr.io/istio-testing versions (#170) 1. Update mixer, manager, proxy versions to include rate limit fixes 2. Remove mixer configmap. The default config is now baked inside mixer. 3. expose mixer metrics and configapi ports thru port forwarding. 4. Add "wrk" for testing. drive traffic and fetch metrics as a setup for full 5. ratelimit integration test. That PR will follow. * Add ingress service for correct status IP * Support for istio-ca in tests/updateVersion.sh (#180) * Update updateVersion.sh to take into account istio-ca * Updates with updateVersion.sh * Create README.md for e2e test framework (#182) * Create README.md for e2e test framework * small change Former-commit-id: 0adf4c4
mandarjog
pushed a commit
that referenced
this pull request
Oct 31, 2017
* Add logger aspect to the mixer. This adds a basic aspect with a Log([]Entry) interface to be implemented by various adapters. A simple manager is provided for downscoping to an Entry from the attribute.Bag based on the configured Input attributes. Tested with: pkg/aspectsupport/logger$ bazel test ... Test coverage: 90%. * Fix date and log msg caps. * Rename BUILD fule for test and make cosmetic changes (comments). Former-commit-id: 35aa582849c4adbee620058d1ec089c6317fd656
mandarjog
pushed a commit
that referenced
this pull request
Oct 31, 2017
* Move bin/e2e.sh logic back into driver.go * run gazelle * update docs and jenkins * Create tagged docker images from layers * lowercase error string
mandarjog
pushed a commit
that referenced
this pull request
Oct 31, 2017
* Revert "Remove e2e.sh and change default tag to <username>_<timestamp> (#140)" This reverts commit 81c09ef688d266520d97b0c84d9f68c293987ed8. * Pass unrecognized test arguments through to driver.go * add special handling for empty strings * remove extra quotes from empty string * quote empty config name in Jenkinsfile * add explicit flag for in-cluster config * Make sure specificy 'tag' explicitly and remove default value
mandarjog
pushed a commit
that referenced
this pull request
Nov 2, 2017
* Initial version * Refactor for better testing * Update framework for testing and added test * Bazelify istio * Simplified interfaces * Refactor code to use Cleanable interface * go formating (#140) * go formating * Updated Jenkinsfile to run tests * Separate TestInfo to another module (#144) * Separete TestInfo to another module Implemented status file creation Implemented log upload to cloud storage Rename SetUp to Setup and TearDown to Teardown * Add more info in TestStatus * Rename InitLogging to InitGlog * Resolving comments * Return skipDir error on err * Adding Code Checks + Fix them (#151) * Not uploading logs_bucket_path flag is unset * Added code checks * Fix linter errors * Update Jenkins to use a goBuildNode * e2e test: Create namespace and deploy istio core and test app (#145) * Create namespace and deploy namespace * Get runtime source path * Correct pr comments, add GetGateWay() * Add default route test * Add version routing tests, fix linter and fix comments on pr * Add fault delay test and fix comments * Add version migration test * Add Hop App + testing (#162) * Implemented echo App * Adding test + refactoring * Added more tests * Resolved review comments * Use slices instead of pointers to slices * Fix formatting * Merge master to e2e (#165) * update version for testing (#147) Also update quota descriptors * Update copyright. * use lowercase zipkin trace headers (#152) * Add support for 1.6 with RBAC and change install to use one file. (#150) * Added RBAC roles and bindings * Script to generate merged configs for 1.5 and 1.6 - the 1.6 works wit rbac on or off. To avoid confusion, auth will be added in separate PR * Update the tag for manager/proxy containers * Port forward manager service and enable istio manager env var Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * Run service port-forward in the background and tidy it up Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * Add yaml template for manager into istio-16.yaml * Remove errant local Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * Add apiserver to istio manager deploy Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * added egress proxy to istio install folder to be referenced by istio.io docs * bug fix * Remove apiserver address Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * Add apiserver and egress * Small doc updates. (#163) * Demo test update + Docker file creation for Hop App (#172) * Renamed default env const * Added support for server update for version * Added a binary for Hop + Docker Image * WIP * Modified kubernetes setup + demo test * Fixed Jenkinsfile * Fix comments * Fix format * Removing app_flag as set directly in template * Fixed resp.close() was called on empty resp * Moved test to their own folder * Fixes e2e.sh * Make e2e.sh more verbose * Merge from istio:master, change install source to istio-install and setup istioctl (#175) * update version for testing (#147) Also update quota descriptors * Update copyright. * use lowercase zipkin trace headers (#152) * Add support for 1.6 with RBAC and change install to use one file. (#150) * Added RBAC roles and bindings * Script to generate merged configs for 1.5 and 1.6 - the 1.6 works wit rbac on or off. To avoid confusion, auth will be added in separate PR * Update the tag for manager/proxy containers * Port forward manager service and enable istio manager env var Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * Run service port-forward in the background and tidy it up Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * Add yaml template for manager into istio-16.yaml * Remove errant local Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * Add apiserver to istio manager deploy Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * added egress proxy to istio install folder to be referenced by istio.io docs * bug fix * Separate Istio CA installation from default. Istio CA should not be installed by default. Created istio-cluster-ca.yaml and istio-namespace-ca.yaml for deploying the per-cluster and per-namespace CAs, so that users do not need to modify the files for different use cases. * Remove apiserver address Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * Add apiserver and egress * Fix Istio CA files to create namespace. * Update one-off auth yaml files. * Small doc updates. (#163) * Improve Istio one-off yaml files for Istio auth. * Fix links. * Up the blanked rl to 5000, so it does not interfere with tests (#167) * Rename istio-ingress-controller to istio-ingress * Changed labels for ingress and ingress * update to rule schema to reflect switch from double to duration (#168) * update to rule schema to reflect switch from double to duration * pointed to my dockerhub * Updating istio version * Regenerate * Change in scripts * Install istio from istio-install, add os x support and add setupIstioctl * fix lineter * Get rule files from demos/apps, istioctl cleanable and comments fix * small change * appManager cleanablization * Merge master to e2e (#181) * update version for testing (#147) Also update quota descriptors * Update copyright. * use lowercase zipkin trace headers (#152) * Add support for 1.6 with RBAC and change install to use one file. (#150) * Added RBAC roles and bindings * Script to generate merged configs for 1.5 and 1.6 - the 1.6 works wit rbac on or off. To avoid confusion, auth will be added in separate PR * Update the tag for manager/proxy containers * Port forward manager service and enable istio manager env var Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * Run service port-forward in the background and tidy it up Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * Add yaml template for manager into istio-16.yaml * Remove errant local Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * Add apiserver to istio manager deploy Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * added egress proxy to istio install folder to be referenced by istio.io docs * bug fix * Separate Istio CA installation from default. Istio CA should not be installed by default. Created istio-cluster-ca.yaml and istio-namespace-ca.yaml for deploying the per-cluster and per-namespace CAs, so that users do not need to modify the files for different use cases. * Remove apiserver address Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * Add apiserver and egress * Fix Istio CA files to create namespace. * Update one-off auth yaml files. * Small doc updates. (#163) * Improve Istio one-off yaml files for Istio auth. * Fix links. * Up the blanked rl to 5000, so it does not interfere with tests (#167) * Rename istio-ingress-controller to istio-ingress * Changed labels for ingress and ingress * update to rule schema to reflect switch from double to duration (#168) * update to rule schema to reflect switch from double to duration * pointed to my dockerhub * Updating istio version * Regenerate * Change in scripts * update to gcr.io/istio-testing versions (#170) 1. Update mixer, manager, proxy versions to include rate limit fixes 2. Remove mixer configmap. The default config is now baked inside mixer. 3. expose mixer metrics and configapi ports thru port forwarding. 4. Add "wrk" for testing. drive traffic and fetch metrics as a setup for full 5. ratelimit integration test. That PR will follow. * Add ingress service for correct status IP * Support for istio-ca in tests/updateVersion.sh (#180) * Update updateVersion.sh to take into account istio-ca * Updates with updateVersion.sh * Create README.md for e2e test framework (#182) * Create README.md for e2e test framework * small change Former-commit-id: 0adf4c4
howardjohn
pushed a commit
to howardjohn/istio
that referenced
this pull request
Jan 12, 2020
* Update hub and tag to master * Update global.yaml
stevenctl
pushed a commit
to stevenctl/istio
that referenced
this pull request
Aug 13, 2022
* uproxygen: use service selector to pick pep chain Change-Id: Ife3cc6476bab466e34c3a63cc66daf75f98f5dd2 * gen Change-Id: I5a7f9e2697fefb3262daa52875d01146577b4dae
antonioberben
pushed a commit
to antonioberben/istio
that referenced
this pull request
Jan 29, 2024
Allow overriding the Cassandra schema job security context
jaellio
added a commit
that referenced
this pull request
Sep 19, 2024
* [release-1.22] Update proxy repo SHA for release-1.22.5 Signed-off-by: Jackie Elliott <jaellio@microsoft.com> * Update SHA Signed-off-by: Jackie Elliott <jaellio@microsoft.com> * Add unit test for setting runtimeValues in Envoy config Signed-off-by: Jackie Elliott <jaellio@microsoft.com> * Run make gen and fix explicit internal address test json Signed-off-by: Jackie Elliott <jaellio@microsoft.com> * Explicitly set internal addresses in http connection manager when PILOT_SIDECAR_USE_REMOTE_ADDRESS is set to true for the sidecar on outbound. Signed-off-by: Jackie Elliott <jaellio@microsoft.com> --------- Signed-off-by: Jackie Elliott <jaellio@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.