e2e test: Create namespace and deploy istio core and test app #145

yutongz · 2017-04-19T20:16:52Z

No description provided.

sebastienvas

I am not sure what are the yaml template used for, but you should be using the yaml files from kubernetes/istio-install.

sebastienvas · 2017-04-19T22:39:24Z

tests/e2e/framework/kubernetes.go

+	hubDefault := "gcr.io/istio-testing"
+	tagDefault := "b121a1e169365865e01a9e6eea066a34a29d9fd1"
+
+	hub := flag.String("hub", hubDefault, "Docker hub")


Move all those flags to var () section at the beginning of file.

sebastienvas · 2017-04-19T22:43:35Z

tests/e2e/framework/testInfo.go

@@ -161,8 +161,10 @@ func (t TestInfo) Teardown() error {

 func generateRunId(t string) (string, error) {
 	u := uuid.New().String()
-	strings.Replace(u, "-", "", -1)
-	strings.Replace(t, "_", "-", -1)
+	glog.Infof("Before: %s|%s", t, u)


Nice catch. PLease remove those log statement

sebastienvas · 2017-04-19T22:48:25Z

tests/e2e/util/commonUtils.go

+func GetTestRuntimePath() string {
+	ex, err := os.Executable()
+	if err != nil {
+			glog.Warning("Cannot get runtime path")


sebastienvas · 2017-04-19T22:49:49Z

tests/e2e/util/commonUtils.go

+}
+
+
+func GetTestRuntimePath() string {


I would change this to help the user.

func getResourcePath(r string) string {
return filepath.Join(...)
}

sebastienvas · 2017-04-19T22:52:24Z

tests/e2e/util/commonUtils.go

+)
+
+const (
+	TEST_RUNFILES_DIR = "go_default_test.runfiles/com_github_istio_istio"


Don't hardcode this.

sebastienvas · 2017-04-19T23:00:27Z

tests/e2e/util/commonUtils.go

+	return string(bytes), nil
+}
+
+func WebDownload(dst string, src string) error {


rename to HttpDownload ?

sebastienvas · 2017-04-19T23:03:57Z

tests/e2e/framework/kubernetes.go

+
+	if injectProxy {
+		injectedYamlFile := k.TmpDir + "/yaml/injected-" + svcName + "-app.yaml"
+		if _, err := util.Shell(fmt.Sprintf("%s kube-inject -f %s -o %s --hub %s --tag %s -n %s", k.IstioCtl, yamlFile, injectedYamlFile, k.ProxyHub, k.ProxyTag, k.Namespace)); err != nil {


Might be useful to create a istioctl library that takes care of downloading the istioctl and etc..

sebastienvas · 2017-04-19T23:07:01Z

tests/e2e/framework/kubernetes.go

+	homeDir := usr.HomeDir
+
+	// Download Istioctl binary
+	util.WebDownload(k.TmpDir+"/istioctl", k.IstioCtlUrl+"/istioctl-linux")


Move this to another library. It is hard to understand why you are doing this here.

sebastienvas · 2017-04-19T23:13:39Z

tests/e2e/framework/kubernetes.go

+			parts := strings.Split(line[7:], "=")
+			switch parts[0] {
+			case "MIXER_HUB":
+				mixerHubDefault = (parts[1])[1:(len(parts[1]) - 1)]


Since you are iterating, it would be better to use a compiled regex:
r := regexp.MustCompile("^export (..*)=(..*)")
for scanner.Scan() {

line := scanner.Text() if m := r.FindStringSubmatch(line); m != nil {

...
}

sebastienvas · 2017-04-19T23:16:32Z

tests/e2e/framework/kubernetes.go

+			case "MIXER_HUB":
+				mixerHubDefault = (parts[1])[1:(len(parts[1]) - 1)]
+			case "MIXER_TAG":
+				mixerTagDefault = (parts[1])[1:(len(parts[1]) - 1)]


What are you trying to do here ? strings.Trim maybe ?

yutongz · 2017-04-21T11:14:12Z

PTAL

sebastienvas · 2017-04-21T17:54:26Z

tests/e2e/framework/kubernetes.go

+	}
+}
+
+func NewKubeInfo(tmpDir, runId string) *KubeInfo {


Since you call this new, you might want to do a copy of it and send the copy.
var k = new(KubeInfo)
*k = kube
and do everything on k

sebastienvas · 2017-04-21T17:59:02Z

tests/e2e/framework/kubernetes.go

+)
+
+var (
+	kube               KubeInfo


This seems redundant to the flag. I don't understand why they are defined twice.

Sorry, not really get your point, which flag(s) you think would be deplicated?

so all the *Default vars are not initialized so your flags default are not initialized. In that case make the flag default expliciit to be nil, and treat your flags as globals.

sebastienvas

Please runs the linters. bin/linters.sh

sebastienvas · 2017-04-21T18:01:11Z

tests/e2e/framework/kubernetes.go

+type KubeInfo struct {
+	Namespace        string
+	NamespaceCreated bool
+	Hub              string


Why do we need this ?

Hub and Tag for app template

Please change the name to make it clear.

sebastienvas · 2017-04-21T18:04:20Z

tests/e2e/framework/kubernetes.go

+	flag.StringVar(&kube.CaImage, "ca", "", "Ca image")
+	flag.StringVar(&kube.ProxyHub, "proxy_hub", managerHubDefault, "proxy hub")
+	flag.StringVar(&kube.ProxyTag, "proxy_tag", managerTagDefault, "proxy tag")
+	flag.StringVar(&kube.IstioctlUrl, "istioctl_url", istioctlUrlDefault, "URL to download istioctl")


your default is not initialized

sebastienvas · 2017-04-21T18:05:19Z

tests/e2e/framework/kubernetes.go

+		k.NamespaceCreated = false
+		glog.Infof("Namespace %s deleted", k.Namespace)
+	}
+	glog.Info("Uploading log remotely")


This is coming from a copy paste ?

Hmm, not really, why?

Remove the glog.Info("Uploading log remotely") since you re not doing it.

sebastienvas · 2017-04-21T18:11:51Z

tests/e2e/util/istioUtils.go

+
+	"github.com/golang/glog"
+)
+


Could you move hte istioctl related flags here and create a struct like
type istioctl struct {
remotePath string
binaryPath string
}

func (i *istioctl) DownloadIstioctl()

func (i *istioctl) KubeInject(yamlFile, svcName, yamlDir, proxyHub, proxyTag, namespace string) (string, error)

sebastienvas

please see

yutongz · 2017-04-25T07:58:50Z

linter failed for three:

Subprocess launching with variable.,HIGH,HIGH (gas)
->run bash command, util.Shell(command)
Expect file permissions to be 0600 or less,MEDIUM,HIGH (gas)
->istioctl require exec right
error strings should not be capitalized or end with punctuation or a newline
-> Create a new error

sebastienvas · 2017-04-26T00:06:44Z

The last one is easy to fix. Just do not used capitalized or punctuation in your error. For the other one you can add
/* #nosec */
just before the line

sebastienvas · 2017-04-26T00:08:16Z

tests/e2e/framework/framework.go

@@ -23,6 +23,10 @@ import (
 	"github.com/golang/glog"
 )

+var (
+	debug = flag.Bool("debug", false, "Debug model, not do clean up")


Please rename to skip_cleanup.

sebastienvas · 2017-04-26T00:08:47Z

tests/e2e/framework/framework.go

@@ -130,6 +144,10 @@ func (t *testCleanup) init() error {
 }

 func (t *testCleanup) cleanup() {
+	if *debug {


please set a property in the struct.

sebastienvas · 2017-04-26T00:13:29Z

tests/e2e/util/commonUtils.go

+	}
+
+	defer func() {
+		if cerr := out.Close(); err == nil && cerr != nil {


defer will not change the value that you return. you should just log an error instead.

sebastienvas

Much better. A few more comments. Let s work together tomorrow.

sebastienvas · 2017-04-26T00:13:43Z

tests/e2e/util/commonUtils.go

+
+	resp, err = http.Get(src)
+	defer func() {
+		if cerr := resp.Body.Close(); err == nil && cerr != nil {


Same comment as before.

sebastienvas · 2017-04-26T00:13:57Z

tests/e2e/util/commonUtils.go

+	if err != nil {
+		return err
+	}
+	defer func() {


Same. Log the error.

sebastienvas · 2017-04-26T00:16:31Z

Jenkinsfile

@@ -32,6 +32,7 @@ def presubmit(gitUtils, bazel, utils) {
      sh('bin/linters.sh')
    }
    stage('Bazel Test') {
+      sh('source istio.VERSION')


Let s create a script for end to end testing in another PR. Just tag the sample test as manual in the BUILD file.

istio-testing · 2017-04-26T18:26:41Z

Jenkins job istio/presubmit passed

yutongz · 2017-04-26T18:27:17Z

PTAL

sebastienvas · 2017-04-26T19:55:48Z

tests/e2e/framework/kubernetes.go

+	appHub       = flag.String("app_hub", appHubDefault, "app hub")
+	appTag       = flag.String("app_tag", appTagDefault, "app tag")
+	namespace    = flag.String("n", "", "Namespace to use for testing (empty to create/delete temporary one)")
+	mixerImage   = flag.String("mixer", os.Getenv(mixerHubDefault)+"/mixer:"+os.Getenv(mixerTagDefault), "Mixer image")


This is inconsistent. Please use hub and tag everywhere.
Note proxyhub and proxytag are the same as manager so you can get rid of them.

istio-testing · 2017-04-26T20:53:14Z

Jenkins job istio/presubmit passed

istio-testing · 2017-04-26T23:38:36Z

Jenkins job istio/presubmit passed

* Initial version * Refactor for better testing * Update framework for testing and added test * Bazelify istio * Simplified interfaces * Refactor code to use Cleanable interface * go formating (#140) * go formating * Updated Jenkinsfile to run tests * Separate TestInfo to another module (#144) * Separete TestInfo to another module Implemented status file creation Implemented log upload to cloud storage Rename SetUp to Setup and TearDown to Teardown * Add more info in TestStatus * Rename InitLogging to InitGlog * Resolving comments * Return skipDir error on err * Adding Code Checks + Fix them (#151) * Not uploading logs_bucket_path flag is unset * Added code checks * Fix linter errors * Update Jenkins to use a goBuildNode * e2e test: Create namespace and deploy istio core and test app (#145) * Create namespace and deploy namespace * Get runtime source path * Correct pr comments, add GetGateWay() * Add default route test * Add version routing tests, fix linter and fix comments on pr * Add fault delay test and fix comments * Add version migration test * Add Hop App + testing (#162) * Implemented echo App * Adding test + refactoring * Added more tests * Resolved review comments * Use slices instead of pointers to slices * Fix formatting * Merge master to e2e (#165) * update version for testing (#147) Also update quota descriptors * Update copyright. * use lowercase zipkin trace headers (#152) * Add support for 1.6 with RBAC and change install to use one file. (#150) * Added RBAC roles and bindings * Script to generate merged configs for 1.5 and 1.6 - the 1.6 works wit rbac on or off. To avoid confusion, auth will be added in separate PR * Update the tag for manager/proxy containers * Port forward manager service and enable istio manager env var Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * Run service port-forward in the background and tidy it up Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * Add yaml template for manager into istio-16.yaml * Remove errant local Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * Add apiserver to istio manager deploy Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * added egress proxy to istio install folder to be referenced by istio.io docs * bug fix * Remove apiserver address Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * Add apiserver and egress * Small doc updates. (#163) * Demo test update + Docker file creation for Hop App (#172) * Renamed default env const * Added support for server update for version * Added a binary for Hop + Docker Image * WIP * Modified kubernetes setup + demo test * Fixed Jenkinsfile * Fix comments * Fix format * Removing app_flag as set directly in template * Fixed resp.close() was called on empty resp * Moved test to their own folder * Fixes e2e.sh * Make e2e.sh more verbose * Merge from istio:master, change install source to istio-install and setup istioctl (#175) * update version for testing (#147) Also update quota descriptors * Update copyright. * use lowercase zipkin trace headers (#152) * Add support for 1.6 with RBAC and change install to use one file. (#150) * Added RBAC roles and bindings * Script to generate merged configs for 1.5 and 1.6 - the 1.6 works wit rbac on or off. To avoid confusion, auth will be added in separate PR * Update the tag for manager/proxy containers * Port forward manager service and enable istio manager env var Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * Run service port-forward in the background and tidy it up Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * Add yaml template for manager into istio-16.yaml * Remove errant local Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * Add apiserver to istio manager deploy Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * added egress proxy to istio install folder to be referenced by istio.io docs * bug fix * Separate Istio CA installation from default. Istio CA should not be installed by default. Created istio-cluster-ca.yaml and istio-namespace-ca.yaml for deploying the per-cluster and per-namespace CAs, so that users do not need to modify the files for different use cases. * Remove apiserver address Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * Add apiserver and egress * Fix Istio CA files to create namespace. * Update one-off auth yaml files. * Small doc updates. (#163) * Improve Istio one-off yaml files for Istio auth. * Fix links. * Up the blanked rl to 5000, so it does not interfere with tests (#167) * Rename istio-ingress-controller to istio-ingress * Changed labels for ingress and ingress * update to rule schema to reflect switch from double to duration (#168) * update to rule schema to reflect switch from double to duration * pointed to my dockerhub * Updating istio version * Regenerate * Change in scripts * Install istio from istio-install, add os x support and add setupIstioctl * fix lineter * Get rule files from demos/apps, istioctl cleanable and comments fix * small change * appManager cleanablization * Merge master to e2e (#181) * update version for testing (#147) Also update quota descriptors * Update copyright. * use lowercase zipkin trace headers (#152) * Add support for 1.6 with RBAC and change install to use one file. (#150) * Added RBAC roles and bindings * Script to generate merged configs for 1.5 and 1.6 - the 1.6 works wit rbac on or off. To avoid confusion, auth will be added in separate PR * Update the tag for manager/proxy containers * Port forward manager service and enable istio manager env var Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * Run service port-forward in the background and tidy it up Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * Add yaml template for manager into istio-16.yaml * Remove errant local Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * Add apiserver to istio manager deploy Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * added egress proxy to istio install folder to be referenced by istio.io docs * bug fix * Separate Istio CA installation from default. Istio CA should not be installed by default. Created istio-cluster-ca.yaml and istio-namespace-ca.yaml for deploying the per-cluster and per-namespace CAs, so that users do not need to modify the files for different use cases. * Remove apiserver address Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * Add apiserver and egress * Fix Istio CA files to create namespace. * Update one-off auth yaml files. * Small doc updates. (#163) * Improve Istio one-off yaml files for Istio auth. * Fix links. * Up the blanked rl to 5000, so it does not interfere with tests (#167) * Rename istio-ingress-controller to istio-ingress * Changed labels for ingress and ingress * update to rule schema to reflect switch from double to duration (#168) * update to rule schema to reflect switch from double to duration * pointed to my dockerhub * Updating istio version * Regenerate * Change in scripts * update to gcr.io/istio-testing versions (#170) 1. Update mixer, manager, proxy versions to include rate limit fixes 2. Remove mixer configmap. The default config is now baked inside mixer. 3. expose mixer metrics and configapi ports thru port forwarding. 4. Add "wrk" for testing. drive traffic and fetch metrics as a setup for full 5. ratelimit integration test. That PR will follow. * Add ingress service for correct status IP * Support for istio-ca in tests/updateVersion.sh (#180) * Update updateVersion.sh to take into account istio-ca * Updates with updateVersion.sh * Create README.md for e2e test framework (#182) * Create README.md for e2e test framework * small change

* Remove config and mixer from titles of docs * attrgen -> attributes

* Initial version * Refactor for better testing * Update framework for testing and added test * Bazelify istio * Simplified interfaces * Refactor code to use Cleanable interface * go formating (#140) * go formating * Updated Jenkinsfile to run tests * Separate TestInfo to another module (#144) * Separete TestInfo to another module Implemented status file creation Implemented log upload to cloud storage Rename SetUp to Setup and TearDown to Teardown * Add more info in TestStatus * Rename InitLogging to InitGlog * Resolving comments * Return skipDir error on err * Adding Code Checks + Fix them (#151) * Not uploading logs_bucket_path flag is unset * Added code checks * Fix linter errors * Update Jenkins to use a goBuildNode * e2e test: Create namespace and deploy istio core and test app (#145) * Create namespace and deploy namespace * Get runtime source path * Correct pr comments, add GetGateWay() * Add default route test * Add version routing tests, fix linter and fix comments on pr * Add fault delay test and fix comments * Add version migration test * Add Hop App + testing (#162) * Implemented echo App * Adding test + refactoring * Added more tests * Resolved review comments * Use slices instead of pointers to slices * Fix formatting * Merge master to e2e (#165) * update version for testing (#147) Also update quota descriptors * Update copyright. * use lowercase zipkin trace headers (#152) * Add support for 1.6 with RBAC and change install to use one file. (#150) * Added RBAC roles and bindings * Script to generate merged configs for 1.5 and 1.6 - the 1.6 works wit rbac on or off. To avoid confusion, auth will be added in separate PR * Update the tag for manager/proxy containers * Port forward manager service and enable istio manager env var Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * Run service port-forward in the background and tidy it up Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * Add yaml template for manager into istio-16.yaml * Remove errant local Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * Add apiserver to istio manager deploy Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * added egress proxy to istio install folder to be referenced by istio.io docs * bug fix * Remove apiserver address Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * Add apiserver and egress * Small doc updates. (#163) * Demo test update + Docker file creation for Hop App (#172) * Renamed default env const * Added support for server update for version * Added a binary for Hop + Docker Image * WIP * Modified kubernetes setup + demo test * Fixed Jenkinsfile * Fix comments * Fix format * Removing app_flag as set directly in template * Fixed resp.close() was called on empty resp * Moved test to their own folder * Fixes e2e.sh * Make e2e.sh more verbose * Merge from istio:master, change install source to istio-install and setup istioctl (#175) * update version for testing (#147) Also update quota descriptors * Update copyright. * use lowercase zipkin trace headers (#152) * Add support for 1.6 with RBAC and change install to use one file. (#150) * Added RBAC roles and bindings * Script to generate merged configs for 1.5 and 1.6 - the 1.6 works wit rbac on or off. To avoid confusion, auth will be added in separate PR * Update the tag for manager/proxy containers * Port forward manager service and enable istio manager env var Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * Run service port-forward in the background and tidy it up Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * Add yaml template for manager into istio-16.yaml * Remove errant local Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * Add apiserver to istio manager deploy Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * added egress proxy to istio install folder to be referenced by istio.io docs * bug fix * Separate Istio CA installation from default. Istio CA should not be installed by default. Created istio-cluster-ca.yaml and istio-namespace-ca.yaml for deploying the per-cluster and per-namespace CAs, so that users do not need to modify the files for different use cases. * Remove apiserver address Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * Add apiserver and egress * Fix Istio CA files to create namespace. * Update one-off auth yaml files. * Small doc updates. (#163) * Improve Istio one-off yaml files for Istio auth. * Fix links. * Up the blanked rl to 5000, so it does not interfere with tests (#167) * Rename istio-ingress-controller to istio-ingress * Changed labels for ingress and ingress * update to rule schema to reflect switch from double to duration (#168) * update to rule schema to reflect switch from double to duration * pointed to my dockerhub * Updating istio version * Regenerate * Change in scripts * Install istio from istio-install, add os x support and add setupIstioctl * fix lineter * Get rule files from demos/apps, istioctl cleanable and comments fix * small change * appManager cleanablization * Merge master to e2e (#181) * update version for testing (#147) Also update quota descriptors * Update copyright. * use lowercase zipkin trace headers (#152) * Add support for 1.6 with RBAC and change install to use one file. (#150) * Added RBAC roles and bindings * Script to generate merged configs for 1.5 and 1.6 - the 1.6 works wit rbac on or off. To avoid confusion, auth will be added in separate PR * Update the tag for manager/proxy containers * Port forward manager service and enable istio manager env var Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * Run service port-forward in the background and tidy it up Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * Add yaml template for manager into istio-16.yaml * Remove errant local Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * Add apiserver to istio manager deploy Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * added egress proxy to istio install folder to be referenced by istio.io docs * bug fix * Separate Istio CA installation from default. Istio CA should not be installed by default. Created istio-cluster-ca.yaml and istio-namespace-ca.yaml for deploying the per-cluster and per-namespace CAs, so that users do not need to modify the files for different use cases. * Remove apiserver address Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * Add apiserver and egress * Fix Istio CA files to create namespace. * Update one-off auth yaml files. * Small doc updates. (#163) * Improve Istio one-off yaml files for Istio auth. * Fix links. * Up the blanked rl to 5000, so it does not interfere with tests (#167) * Rename istio-ingress-controller to istio-ingress * Changed labels for ingress and ingress * update to rule schema to reflect switch from double to duration (#168) * update to rule schema to reflect switch from double to duration * pointed to my dockerhub * Updating istio version * Regenerate * Change in scripts * update to gcr.io/istio-testing versions (#170) 1. Update mixer, manager, proxy versions to include rate limit fixes 2. Remove mixer configmap. The default config is now baked inside mixer. 3. expose mixer metrics and configapi ports thru port forwarding. 4. Add "wrk" for testing. drive traffic and fetch metrics as a setup for full 5. ratelimit integration test. That PR will follow. * Add ingress service for correct status IP * Support for istio-ca in tests/updateVersion.sh (#180) * Update updateVersion.sh to take into account istio-ca * Updates with updateVersion.sh * Create README.md for e2e test framework (#182) * Create README.md for e2e test framework * small change Former-commit-id: 0adf4c4

Secure naming is handled by the discovery service of #istio/pilot

* Disable routing test until it stops being flaky * dislike bash

* Initial version * Refactor for better testing * Update framework for testing and added test * Bazelify istio * Simplified interfaces * Refactor code to use Cleanable interface * go formating (#140) * go formating * Updated Jenkinsfile to run tests * Separate TestInfo to another module (#144) * Separete TestInfo to another module Implemented status file creation Implemented log upload to cloud storage Rename SetUp to Setup and TearDown to Teardown * Add more info in TestStatus * Rename InitLogging to InitGlog * Resolving comments * Return skipDir error on err * Adding Code Checks + Fix them (#151) * Not uploading logs_bucket_path flag is unset * Added code checks * Fix linter errors * Update Jenkins to use a goBuildNode * e2e test: Create namespace and deploy istio core and test app (#145) * Create namespace and deploy namespace * Get runtime source path * Correct pr comments, add GetGateWay() * Add default route test * Add version routing tests, fix linter and fix comments on pr * Add fault delay test and fix comments * Add version migration test * Add Hop App + testing (#162) * Implemented echo App * Adding test + refactoring * Added more tests * Resolved review comments * Use slices instead of pointers to slices * Fix formatting * Merge master to e2e (#165) * update version for testing (#147) Also update quota descriptors * Update copyright. * use lowercase zipkin trace headers (#152) * Add support for 1.6 with RBAC and change install to use one file. (#150) * Added RBAC roles and bindings * Script to generate merged configs for 1.5 and 1.6 - the 1.6 works wit rbac on or off. To avoid confusion, auth will be added in separate PR * Update the tag for manager/proxy containers * Port forward manager service and enable istio manager env var Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * Run service port-forward in the background and tidy it up Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * Add yaml template for manager into istio-16.yaml * Remove errant local Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * Add apiserver to istio manager deploy Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * added egress proxy to istio install folder to be referenced by istio.io docs * bug fix * Remove apiserver address Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * Add apiserver and egress * Small doc updates. (#163) * Demo test update + Docker file creation for Hop App (#172) * Renamed default env const * Added support for server update for version * Added a binary for Hop + Docker Image * WIP * Modified kubernetes setup + demo test * Fixed Jenkinsfile * Fix comments * Fix format * Removing app_flag as set directly in template * Fixed resp.close() was called on empty resp * Moved test to their own folder * Fixes e2e.sh * Make e2e.sh more verbose * Merge from istio:master, change install source to istio-install and setup istioctl (#175) * update version for testing (#147) Also update quota descriptors * Update copyright. * use lowercase zipkin trace headers (#152) * Add support for 1.6 with RBAC and change install to use one file. (#150) * Added RBAC roles and bindings * Script to generate merged configs for 1.5 and 1.6 - the 1.6 works wit rbac on or off. To avoid confusion, auth will be added in separate PR * Update the tag for manager/proxy containers * Port forward manager service and enable istio manager env var Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * Run service port-forward in the background and tidy it up Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * Add yaml template for manager into istio-16.yaml * Remove errant local Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * Add apiserver to istio manager deploy Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * added egress proxy to istio install folder to be referenced by istio.io docs * bug fix * Separate Istio CA installation from default. Istio CA should not be installed by default. Created istio-cluster-ca.yaml and istio-namespace-ca.yaml for deploying the per-cluster and per-namespace CAs, so that users do not need to modify the files for different use cases. * Remove apiserver address Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * Add apiserver and egress * Fix Istio CA files to create namespace. * Update one-off auth yaml files. * Small doc updates. (#163) * Improve Istio one-off yaml files for Istio auth. * Fix links. * Up the blanked rl to 5000, so it does not interfere with tests (#167) * Rename istio-ingress-controller to istio-ingress * Changed labels for ingress and ingress * update to rule schema to reflect switch from double to duration (#168) * update to rule schema to reflect switch from double to duration * pointed to my dockerhub * Updating istio version * Regenerate * Change in scripts * Install istio from istio-install, add os x support and add setupIstioctl * fix lineter * Get rule files from demos/apps, istioctl cleanable and comments fix * small change * appManager cleanablization * Merge master to e2e (#181) * update version for testing (#147) Also update quota descriptors * Update copyright. * use lowercase zipkin trace headers (#152) * Add support for 1.6 with RBAC and change install to use one file. (#150) * Added RBAC roles and bindings * Script to generate merged configs for 1.5 and 1.6 - the 1.6 works wit rbac on or off. To avoid confusion, auth will be added in separate PR * Update the tag for manager/proxy containers * Port forward manager service and enable istio manager env var Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * Run service port-forward in the background and tidy it up Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * Add yaml template for manager into istio-16.yaml * Remove errant local Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * Add apiserver to istio manager deploy Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * added egress proxy to istio install folder to be referenced by istio.io docs * bug fix * Separate Istio CA installation from default. Istio CA should not be installed by default. Created istio-cluster-ca.yaml and istio-namespace-ca.yaml for deploying the per-cluster and per-namespace CAs, so that users do not need to modify the files for different use cases. * Remove apiserver address Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * Add apiserver and egress * Fix Istio CA files to create namespace. * Update one-off auth yaml files. * Small doc updates. (#163) * Improve Istio one-off yaml files for Istio auth. * Fix links. * Up the blanked rl to 5000, so it does not interfere with tests (#167) * Rename istio-ingress-controller to istio-ingress * Changed labels for ingress and ingress * update to rule schema to reflect switch from double to duration (#168) * update to rule schema to reflect switch from double to duration * pointed to my dockerhub * Updating istio version * Regenerate * Change in scripts * update to gcr.io/istio-testing versions (#170) 1. Update mixer, manager, proxy versions to include rate limit fixes 2. Remove mixer configmap. The default config is now baked inside mixer. 3. expose mixer metrics and configapi ports thru port forwarding. 4. Add "wrk" for testing. drive traffic and fetch metrics as a setup for full 5. ratelimit integration test. That PR will follow. * Add ingress service for correct status IP * Support for istio-ca in tests/updateVersion.sh (#180) * Update updateVersion.sh to take into account istio-ca * Updates with updateVersion.sh * Create README.md for e2e test framework (#182) * Create README.md for e2e test framework * small change Former-commit-id: 0adf4c4

Secure naming is handled by the discovery service of #istio/pilot

…ss GW deployment template (istio#145)

…ter-merge_upstream_istio_master-6253864e Automator: merge upstream changes to openshift-service-mesh/istio@master

yutongz added 2 commits April 19, 2017 04:34

Create namespace and deploy namespace

f89c4df

Get runtime source path

40c2e37

googlebot added the cla: yes label Apr 19, 2017

yutongz changed the title ~~e2e test: Create namespace and deploy istio core and test app~~ [WIP] e2e test: Create namespace and deploy istio core and test app Apr 19, 2017

Merge from istio:e2e e3af417

7280188

sebastienvas suggested changes Apr 19, 2017

View reviewed changes

yutongz added 2 commits April 20, 2017 20:32

Correct pr comments, add GetGateWay()

2e8cc7b

Add default route test

5850020

sebastienvas reviewed Apr 21, 2017

View reviewed changes

sebastienvas suggested changes Apr 21, 2017

View reviewed changes

sebastienvas reviewed Apr 23, 2017

View reviewed changes

yutongz added 2 commits April 25, 2017 03:30

Merge istio/e2e : e15e450

5e84a00

Add version routing tests, fix linter and fix comments on pr

7eb7e00

sebastienvas reviewed Apr 26, 2017

View reviewed changes

sebastienvas suggested changes Apr 26, 2017

View reviewed changes

sebastienvas approved these changes Apr 26, 2017

View reviewed changes

Add fault delay test and fix comments

6989370

yutongz changed the title ~~[WIP] e2e test: Create namespace and deploy istio core and test app~~ e2e test: Create namespace and deploy istio core and test app Apr 26, 2017

Add version migration test

e4431c8

sebastienvas merged commit a7db6a1 into istio:e2e Apr 27, 2017

zenlint pushed a commit to zenlint/istio that referenced this pull request Aug 30, 2017

Remove config and mixer from titles of docs (istio#145)

45fd2a2

* Remove config and mixer from titles of docs * attrgen -> attributes

mandarjog pushed a commit that referenced this pull request Oct 31, 2017

Remove secure naming (#145)

8088d17

Secure naming is handled by the discovery service of #istio/pilot

mandarjog pushed a commit that referenced this pull request Oct 31, 2017

Disable routing test until it stops being flaky (#145)

231f166

* Disable routing test until it stops being flaky * dislike bash

mandarjog pushed a commit that referenced this pull request Nov 2, 2017

Remove secure naming (#145)

cc5b6d9

Secure naming is handled by the discovery service of #istio/pilot

guptasu pushed a commit to guptasu/istio that referenced this pull request Jun 11, 2018

add context.time (istio#145)

c4acc01

rajusharma pushed a commit to rajusharma/istio that referenced this pull request Jul 2, 2019

Update CI to use Golang 1.12 and edge kind (istio#145)

5629800

howardjohn pushed a commit to howardjohn/istio that referenced this pull request Jan 12, 2020

Fix return code of manifest-diff (istio#145)

ce834c5

l8huang pushed a commit to l8huang/istio that referenced this pull request Jun 16, 2022

setting logrotater imagePullPolicy default to 'IfNotPresent' in ingre…

9b1ec24

…ss GW deployment template (istio#145)

luksa pushed a commit to luksa/istio that referenced this pull request Oct 14, 2024

Merge pull request istio#145 from openshift-service-mesh-bot/none-mas…

2994ec4

…ter-merge_upstream_istio_master-6253864e Automator: merge upstream changes to openshift-service-mesh/istio@master

e2e test: Create namespace and deploy istio core and test app #145

e2e test: Create namespace and deploy istio core and test app #145

Uh oh!

Conversation

yutongz commented Apr 19, 2017

Uh oh!

sebastienvas left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yutongz commented Apr 21, 2017

Uh oh!

sebastienvas Apr 21, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sebastienvas left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sebastienvas left a comment

Choose a reason for hiding this comment

Uh oh!

yutongz commented Apr 25, 2017

Uh oh!

sebastienvas commented Apr 26, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sebastienvas left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sebastienvas Apr 21, 2017 •

edited

Loading