-
Notifications
You must be signed in to change notification settings - Fork 10.9k
[Ruby] add aarch64 linux build #33079
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Ruby] add aarch64 linux build #33079
Conversation
@alto-ruby I pushed the new docker image. FWIW, the script for pushing the digest editing the current version file to look like this:
|
Using the provided image and sha256 give me the following error:
I can pull the image but docker inspect outputs a different hash
I replaced the hash in another commit and the distribution test passes. (Portability Tests Windows failure is unrelated) @apolcyn can you double confirm the sha265 I should use? |
@alto-ruby the tag and sha256 that you have here matches what I see in the published image. I'm not sure why my run of the script gave a different output, but I think that was wrong and what you have here seems to be right. |
tested with built aarch64 linux gem, gcs link
|
This merge resulted in #33549 and similar PRs to any PRs created after it was merged. |
I'm going to get #33546 merged to fix the problem this caused. |
This adds pre-built library for aarch64 linux, will help improve the install speed and avoid building environment issues at customer side. @apolcyn @jtattermusch Can you help build and push the new rake compiler image? Will update the tag and hash after the image is available Manually tested locally: ``` uname -a Linux u20 5.15.49-linuxkit #1 SMP PREEMPT Tue Sep 13 07:51:32 UTC 2022 aarch64 aarch64 aarch64 GNU/Linux ``` ``` time gem install /work/ruby/grpc/pkg/grpc-1.56.0.dev-aarch64-linux.gem Successfully installed grpc-1.56.0.dev-aarch64-linux Parsing documentation for grpc-1.56.0.dev-aarch64-linux Installing ri documentation for grpc-1.56.0.dev-aarch64-linux Done installing documentation for grpc after 0 seconds 1 gem installed real 0m22.794s user 0m17.268s sys 0m5.156s ``` ``` ruby greeter_server.rb & [1] 319 ruby greeter_client.rb "Greeting: Hello world" ``` Fixes: grpc#31855 grpc#29489
Can anyone shed light on what happened to this as to grpc releases? 1.57.0 has just been released but this doesn’t seem to have made it in. (no platform specific binaries at https://rubygems.org/gems/grpc/versions ) Did it get partially reverted (or release held off) somewhere along the line which I have missed? |
I can't tell how it's published in general, I don't see a workflow doing it, is it possible there's a human responsible for it? |
Yeah, I am not sure. I've been also trying to work out what happened to the I also note someone has asked something similar on the dev list: https://groups.google.com/g/grpc-io/c/HfNJnEwEijY |
There are some manual steps publishing the built gems to rubygems.org. @apolcyn I have verified arm artifacts from #34008 works on arm MacOS and Linux, it's safe to publish them. |
Thanks @alto-ruby . Perhaps worth noting that based on #25992 (comment) there may still be some challenges with the signatures for arm64-darwin. Haven't yet tested myself just yet. But that's great news for aarch64-linux, all the same! |
Signature issue should have been resolved with #33641 where we removed the manual strip step. It would be great if you can double test the artifacts in the above comment. |
Hi everyone, is there any eta for when the aarch64-linux binaries will be published? Or will they be release only from version 1.58? |
I'm not sure if anyone is waiting on volunteers to sanity test, but I personally have not had a chance to sanity test the gems shared earlier, but perhaps if you have a chance @alevalentz that might help the collective effort :-) |
When running the aarch-64 binary on Fargate ARM64 I'm seeing a segfault
|
@Don-CA I wonder if it is reasonable to expect these to work on Does the same happen with a non-Alpine container? |
For what it's worth @alto-ruby - I did a basic sanity test using the gems from 1.58.0.dev here. They installed and seemed to work perfectly fine for me on both aarch64 linux and MacOS. Linux
Darwin/MacOS
|
@alto-ruby is there any other help needed here? How do we best get some Googler help to get the linux and darwin Gem variants pushed to Rubygems, either for Should I/we perhaps open a specific issue to get these released, and link to the earlier closed Github issues/PRs for your work? |
This adds pre-built library for aarch64 linux, will help improve the install speed and avoid building environment issues at customer side.
@apolcyn @jtattermusch Can you help build and push the new rake compiler image?
Will update the tag and hash after the image is available
Manually tested locally:
Fixes: #31855
Fixes: #29489
Fixes: #26391