Add pluggable auth support for external account creds #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aeitzman
reviewed
Jul 13, 2023
| @@ -0,0 +1,130 @@ | |||
|
|
|||
| // | |||
| // Copyright 2020 gRPC authors. | |||
| #include "src/core/lib/json/json_reader.h" | ||
| #include "src/core/lib/json/json_writer.h" | ||
| #include "src/core/lib/security/credentials/credentials.h" | ||
| #include "src/core/lib/uri/uri_parser.h" |
There was a problem hiding this comment.
nit: Do we need all these includes? Wondering about the uri_parser in particular
There was a problem hiding this comment.
We need not worry about includes as the "include what you use" iwyu tool will show us the unused and missed includes during build.
I've modified the includes for now by running iwyu locally, which isn't that reliable.
| if (executable_it != executable_json.object().end()) { | ||
| if (!absl::SimpleAtoi(executable_it->second.string(), | ||
| &executable_timeout_ms_)) { | ||
| *error = GRPC_ERROR_CREATE("timeout_millis field must be a number"); |
There was a problem hiding this comment.
nit: add period at the end of the error message
mario-vimal
pushed a commit
that referenced
this pull request
Jul 13, 2023
This adds pre-built library for aarch64 linux, will help improve the install speed and avoid building environment issues at customer side. @apolcyn @jtattermusch Can you help build and push the new rake compiler image? Will update the tag and hash after the image is available Manually tested locally: ``` uname -a Linux u20 5.15.49-linuxkit #1 SMP PREEMPT Tue Sep 13 07:51:32 UTC 2022 aarch64 aarch64 aarch64 GNU/Linux ``` ``` time gem install /work/ruby/grpc/pkg/grpc-1.56.0.dev-aarch64-linux.gem Successfully installed grpc-1.56.0.dev-aarch64-linux Parsing documentation for grpc-1.56.0.dev-aarch64-linux Installing ri documentation for grpc-1.56.0.dev-aarch64-linux Done installing documentation for grpc after 0 seconds 1 gem installed real 0m22.794s user 0m17.268s sys 0m5.156s ``` ``` ruby greeter_server.rb & [1] 319 ruby greeter_client.rb "Greeting: Hello world" ``` Fixes: grpc#31855 grpc#29489
mario-vimal
pushed a commit
that referenced
this pull request
Jul 13, 2023
This adds pre-built library for aarch64 linux, will help improve the install speed and avoid building environment issues at customer side. @apolcyn @jtattermusch Can you help build and push the new rake compiler image? Will update the tag and hash after the image is available Manually tested locally: ``` uname -a Linux u20 5.15.49-linuxkit #1 SMP PREEMPT Tue Sep 13 07:51:32 UTC 2022 aarch64 aarch64 aarch64 GNU/Linux ``` ``` time gem install /work/ruby/grpc/pkg/grpc-1.56.0.dev-aarch64-linux.gem Successfully installed grpc-1.56.0.dev-aarch64-linux Parsing documentation for grpc-1.56.0.dev-aarch64-linux Installing ri documentation for grpc-1.56.0.dev-aarch64-linux Done installing documentation for grpc after 0 seconds 1 gem installed real 0m22.794s user 0m17.268s sys 0m5.156s ``` ``` ruby greeter_server.rb & [1] 319 ruby greeter_client.rb "Greeting: Hello world" ``` Fixes: grpc#31855 grpc#29489
815c8eb to
803d60c
Compare
aeitzman
approved these changes
Jul 14, 2023
|
|
||
| TEST( | ||
| CredentialsTest, | ||
| TestPluggableAuthExternalAccountCredentialsCreateFailureExecutableTimeoutLessThanMin) { |
mario-vimal
added a commit
that referenced
this pull request
Jul 27, 2023
* Add pluggable auth support for external account creds * Add tests for pluggable auth - ADC * Update test name - credentials_test.cc
mario-vimal
added a commit
that referenced
this pull request
Jul 27, 2023
* Add pluggable auth support for external account creds * Add tests for pluggable auth - ADC * Update test name - credentials_test.cc
mario-vimal
added a commit
that referenced
this pull request
Jul 27, 2023
* Add pluggable auth support for external account creds * Add tests for pluggable auth - ADC * Update test name - credentials_test.cc
mario-vimal
added a commit
that referenced
this pull request
Jul 27, 2023
* Add pluggable auth support for external account creds * Add tests for pluggable auth - ADC * Update test name - credentials_test.cc
mario-vimal
added a commit
that referenced
this pull request
Jul 27, 2023
* Add pluggable auth support for external account creds * Add tests for pluggable auth - ADC * Update test name - credentials_test.cc
mario-vimal
added a commit
that referenced
this pull request
Aug 2, 2023
* Add pluggable auth support for external account creds * Add tests for pluggable auth - ADC * Update test name - credentials_test.cc
mario-vimal
added a commit
that referenced
this pull request
Aug 2, 2023
* Add pluggable auth support for external account creds * Add tests for pluggable auth - ADC * Update test name - credentials_test.cc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.