[Ruby] remove manual strip in ruby ext conf #33641
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
de22278 to
f37c483
Compare
f37c483 to
f2378b6
Compare
HannahShiSFB
approved these changes
Jul 17, 2023
|
Are we certain that the gem binary size didn't change? (especially on linux x86_64) |
|
Yes, there is the artifact link in the PR summary, the sizes are comparable to the build prior to this PR or the release packages in rubygems.org. |
mario-vimal
pushed a commit
to mario-vimal/grpc
that referenced
this pull request
Jul 27, 2023
Custom strip invalidates the signature, caused the arm64-darwin gem failed to run on M1 macs. Error in mac console: `Exception Type: EXC_BAD_ACCESS (SIGKILL (Code Signature Invalid))` Warning in gem build log: ``` # linking shared-object grpc/grpc_c.bundle # Stripping grpc_c.bundle # /opt/osxcross/target/bin/aarch64-apple-darwin20.2-strip: warning: changes being made to the file will invalidate the code signature in: /Users/jeff/work/ruby/grpc/tmp/arm64-darwin/grpc_c/3.2.0/grpc_c.bundle ``` Custom stripping is not really needed (any more), this diff removes it from `src/ruby/ext/grpc/extconf.rb`, the [gem artifact](https://console.cloud.google.com/storage/browser/grpc-testing-kokoro-prod/test_result_public/prod/grpc/core/pull_request/linux/grpc_distribtests_ruby/19833/20230708-181642/github/grpc/artifacts?pageState=(%22StorageObjectListTable%22:(%22f%22:%22%255B%255D%22))&prefix=&forceOnObjectsSortingFiltering=false) size didn't change and arm64-darwin gem runs fine on M1 mac. fixes: grpc#28631 fixes: grpc#29100
|
Please note that I'm in the process of fixing stripping upstream in rake-compiler-dock ... rake-compiler/rake-compiler-dock#104 I could have fixed it sooner if someone had filed an issue! 🤷 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Custom strip invalidates the signature, caused the arm64-darwin gem failed to run on M1 macs.
Error in mac console:
Exception Type: EXC_BAD_ACCESS (SIGKILL (Code Signature Invalid))Warning in gem build log:
Custom stripping is not really needed (any more), this diff removes it from
src/ruby/ext/grpc/extconf.rb, the gem artifact size didn't change and arm64-darwin gem runs fine on M1 mac.fixes: #28631
fixes: #29100