Fix NPD on click API call
#4845
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
345b865 to
5b7d491
Compare
inancgumus
reviewed
Jun 11, 2025
inancgumus
previously approved these changes
Jun 11, 2025
joanlopez
previously approved these changes
Jun 13, 2025
This works with the utility context which might help avoid the NPDs we see when working with the current approach -- cdppage.GetLayoutMetrics.
93af43c to
38ae96e
Compare
joanlopez
approved these changes
Jun 16, 2025
mstoykov
approved these changes
Jun 16, 2025
ankur22
added a commit
that referenced
this pull request
Jun 17, 2025
joanlopez
added a commit
that referenced
this pull request
Jun 25, 2025
* Base release notes for v1.1.0 * Add release notes for dependabot PRs * Add #4809 and #4831 into the v1.1.0 release note * Add #4845 to the v1.1.0 release notes * Add example for locator.count * Remove await on expect in count example * Add section for nth, first and count in v1.1.0... ... release notes. * Update examples to work with latest test library This also updates the nth, first and last example. * Add some PRs from the beginning of the cycle into release notes * Add external PRs, among others, to release notes * Clean up stuff from release notes template * Add remaining PRs into release notes * Add #4862 to the v1.1.0 release note * Apply suggestions from code review Co-authored-by: Mihail Stoykov <312246+mstoykov@users.noreply.github.com> * Add #4864 to v1.1.0 release notes * Remove #4862 from v1.1.0 * Apply suggestions from code review Co-authored-by: İnanç Gümüş <inanc.gumus@grafana.com> * web/crypto updates * Update release notes/v1.1.0.md Co-authored-by: Mihail Stoykov <312246+mstoykov@users.noreply.github.com> * docs: document v1.1.0 forward roadmap * Refine experimental modules notes --------- Co-authored-by: ankur22 <ankur.agarwal@grafana.com> Co-authored-by: Mihail Stoykov <312246+mstoykov@users.noreply.github.com> Co-authored-by: İnanç Gümüş <inanc.gumus@grafana.com> Co-authored-by: oleiade <theo@crevon.me> Co-authored-by: Ivan <2103732+codebien@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
We're swapping out the use of working with
cdppage.GetLayoutMetricsto working with a manual workaround that retrieves the current frame's width and height from the utility context.Why?
This should avoid NPDs that we sometimes see. More context can be found here in Playwright's PR for a similar issue: microsoft/playwright#2669.
Checklist
make check) and all pass.Checklist: Documentation (only for k6 maintainers and if relevant)
Please do not merge this PR until the following items are filled out.
Related PR(s)/Issue(s)
Issue: #4123
Comment: #4123 (comment)