Fix fill method in injection script #4809

ankur22 · 2025-05-22T22:54:22Z

What?

Preventing an early exit in the fill method in the injection script to actually allow the keyboard to enter the value into the input element.

Why?

This fill function was failing to fill the input text field. It would seem that it was returning to early, when it should have continued onto the end of the function and returned "needsinput".

Test script

Without the fix this script was unable to enter the username in the input element. After the fix it does:

import { browser } from 'k6/browser';

export const options = {
  scenarios: {
    ui: {
      executor: 'shared-iterations',
      options: {
        browser: {
          type: "chromium",
        },
      },
    },
  }
}

export default async function() {
  const context = await browser.newContext();
  const page = await context.newPage();

  await page.goto('https://grafana.com/auth/sign-in');
  
  await page.locator('input[name="login"]').fill('my-username');

  await page.waitForTimeout(5000);
}

Checklist

I have performed a self-review of my code.
I have commented on my code, particularly in hard-to-understand areas.
I have added tests for my changes.
I have run linter and tests locally (make check) and all pass.

Checklist: Documentation (only for k6 maintainers and if relevant)

Please do not merge this PR until the following items are filled out.

I have added the correct milestone and labels to the PR.
I have updated the release notes: 451213a
I have updated or added an issue to the k6-documentation: grafana/k6-docs#NUMBER if applicable
I have updated or added an issue to the TypeScript definitions: grafana/k6-DefinitelyTyped#NUMBER if applicable

Related PR(s)/Issue(s)

joanlopez · 2025-05-23T10:12:44Z

Is this something that can be tested? Like, with a unit test, I mean 🤔

ankur22 · 2025-05-23T10:35:25Z

Is this something that can be tested? Like, with a unit test, I mean 🤔

I did try, and i wasn't able to get it to not work before the fix! Very strange. I'll give it another go though 👍

ankur22 · 2025-05-23T20:21:21Z

@joanlopez I've added an integration test in 9a35675. It fails without the fix and passes with the fix. Turned out to be an issue due how react works.

mstoykov · 2025-05-25T09:10:13Z

internal/js/modules/k6/browser/tests/static/react_input.html

+  <script crossorigin src="https://unpkg.com/react@18/umd/react.development.js"></script>
+  <script crossorigin src="https://unpkg.com/react-dom@18/umd/react-dom.development.js"></script>


In general it is not great when our test depends on other services being up and running and we have tried to remove those.

#464 #2302

I guess a "quick-win" could be copy-pasting these files locally, right? 🤔 So, this way we don't rely on an external server, to be available. Reproducing the issue (if React-specific) with a subset of the library might more challenging, tho.

Yeah, that makes sense. I tried to isolate the changes from the react dependency files, but the work that needs to go into doing that outweighs the benefits IMO. I've just added the files that are needed as static files. The commit is 16a4550

Instead of saving these scripts in the repository and bloating it, why don't we download them only once, right before the test starts, if the files don't exist?

That would still depend on a network connection, i guess we want to avoid that where possible. We're already vendoring our Go dependency, so i feel like this is good enough for now. Preferably it would be nice to only include the areas of the code that the test actually uses from the react library -- i tried manually (and using AI) to do this but it was taking too long so i abandoned it.

I wouldn't worry much about the network connection for one-time-download assets, especially if we put it onto one of our servers, like S3 or jslib.k6.io. Getting Go modules always involves a network anyway. That said, I'm fine with the current solution as well 🤗

mstoykov

LGTM, but it will be nice if we do not have to import 2 react dependancies from a third party to test this.

This fill function was failing to fill the input text field. It would seem that it was returning to early, when it should have continued onto the end of the function and returned "needsinput".

It relies on a react based website.

network issues.

* Base release notes for v1.1.0 * Add release notes for dependabot PRs * Add #4809 and #4831 into the v1.1.0 release note * Add #4845 to the v1.1.0 release notes * Add example for locator.count * Remove await on expect in count example * Add section for nth, first and count in v1.1.0... ... release notes. * Update examples to work with latest test library This also updates the nth, first and last example. * Add some PRs from the beginning of the cycle into release notes * Add external PRs, among others, to release notes * Clean up stuff from release notes template * Add remaining PRs into release notes * Add #4862 to the v1.1.0 release note * Apply suggestions from code review Co-authored-by: Mihail Stoykov <312246+mstoykov@users.noreply.github.com> * Add #4864 to v1.1.0 release notes * Remove #4862 from v1.1.0 * Apply suggestions from code review Co-authored-by: İnanç Gümüş <inanc.gumus@grafana.com> * web/crypto updates * Update release notes/v1.1.0.md Co-authored-by: Mihail Stoykov <312246+mstoykov@users.noreply.github.com> * docs: document v1.1.0 forward roadmap * Refine experimental modules notes --------- Co-authored-by: ankur22 <ankur.agarwal@grafana.com> Co-authored-by: Mihail Stoykov <312246+mstoykov@users.noreply.github.com> Co-authored-by: İnanç Gümüş <inanc.gumus@grafana.com> Co-authored-by: oleiade <theo@crevon.me> Co-authored-by: Ivan <2103732+codebien@users.noreply.github.com>

ankur22 requested a review from a team as a code owner May 22, 2025 22:54

ankur22 requested review from mstoykov and joanlopez and removed request for a team May 22, 2025 22:54

ankur22 force-pushed the fix/browser-input-fill branch from 9a35675 to 8700afc Compare May 23, 2025 20:23

mstoykov reviewed May 25, 2025

View reviewed changes

mstoykov previously approved these changes May 25, 2025

View reviewed changes

ankur22 dismissed mstoykov’s stale review via 16a4550 June 4, 2025 10:16

ankur22 force-pushed the fix/browser-input-fill branch from 16a4550 to b0f443e Compare June 4, 2025 10:30

ankur22 requested a review from inancgumus June 4, 2025 11:05

inancgumus previously approved these changes Jun 4, 2025

View reviewed changes

ankur22 requested a review from mstoykov June 5, 2025 08:11

ankur22 added this to the v1.1.0 milestone Jun 5, 2025

joanlopez previously approved these changes Jun 9, 2025

View reviewed changes

ankur22 dismissed stale reviews from joanlopez and inancgumus via 3c30e1f June 9, 2025 14:28

ankur22 requested review from joanlopez and inancgumus June 9, 2025 14:30

joanlopez approved these changes Jun 9, 2025

View reviewed changes

inancgumus approved these changes Jun 9, 2025

View reviewed changes

ankur22 added 3 commits June 9, 2025 22:26

Fix fill method in injection script

db70ac6

This fill function was failing to fill the input text field. It would seem that it was returning to early, when it should have continued onto the end of the function and returned "needsinput".

Add a test for the Fill fix

7635d18

It relies on a react based website.

Add react js files to avoid flaky tests due to...

a58835e

network issues.

ankur22 force-pushed the fix/browser-input-fill branch from 3c30e1f to a58835e Compare June 9, 2025 21:27

ankur22 merged commit c5b88f4 into master Jun 9, 2025
31 of 32 checks passed

ankur22 deleted the fix/browser-input-fill branch June 9, 2025 21:42

ankur22 added a commit that referenced this pull request Jun 17, 2025

Add #4809 and #4831 into the v1.1.0 release note

451213a

BrewTestBot mentioned this pull request Jun 25, 2025

k6 1.1.0 Homebrew/homebrew-core#228117

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix fill method in injection script #4809

Fix fill method in injection script #4809

Uh oh!

ankur22 commented May 22, 2025 •

edited

Loading

Uh oh!

joanlopez commented May 23, 2025

Uh oh!

ankur22 commented May 23, 2025

Uh oh!

ankur22 commented May 23, 2025 •

edited

Loading

Uh oh!

mstoykov May 25, 2025

Uh oh!

joanlopez May 26, 2025 •

edited

Loading

Uh oh!

ankur22 Jun 4, 2025

Uh oh!

inancgumus Jun 4, 2025 •

edited

Loading

Uh oh!

ankur22 Jun 5, 2025

Uh oh!

inancgumus Jun 5, 2025

Uh oh!

mstoykov left a comment

Uh oh!

Uh oh!

Uh oh!

		<script crossorigin src="https://unpkg.com/react@18/umd/react.development.js"></script>
		<script crossorigin src="https://unpkg.com/react-dom@18/umd/react-dom.development.js"></script>

Fix fill method in injection script #4809

Fix fill method in injection script #4809

Uh oh!

Conversation

ankur22 commented May 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What?

Why?

Test script

Checklist

Checklist: Documentation (only for k6 maintainers and if relevant)

Related PR(s)/Issue(s)

Uh oh!

joanlopez commented May 23, 2025

Uh oh!

ankur22 commented May 23, 2025

Uh oh!

ankur22 commented May 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mstoykov May 25, 2025

Choose a reason for hiding this comment

Uh oh!

joanlopez May 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ankur22 Jun 4, 2025

Choose a reason for hiding this comment

Uh oh!

inancgumus Jun 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ankur22 Jun 5, 2025

Choose a reason for hiding this comment

Uh oh!

inancgumus Jun 5, 2025

Choose a reason for hiding this comment

Uh oh!

mstoykov left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ankur22 commented May 22, 2025 •

edited

Loading

ankur22 commented May 23, 2025 •

edited

Loading

joanlopez May 26, 2025 •

edited

Loading

inancgumus Jun 4, 2025 •

edited

Loading