Skip to content

feat(grouped_by): Allow pricing_group_keys on all charge models #3790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 17, 2025
Merged

feat(grouped_by): Allow pricing_group_keys on all charge models #3790

merged 4 commits into from
Jun 17, 2025

Conversation

vincent-pochet
Copy link
Collaborator

Context

This PR follows #3666, #3681 and #3789 as part of the epic to add grouped_by feature on all charge models and not only on the standard one like today.

Description

This PR removes the restriction on charge model to allow pricing_group_keys on every charge model

@vincent-pochet vincent-pochet force-pushed the feat-enable-pricing-group-keys branch 2 times, most recently from c0bc4dd to a24fd47 Compare June 5, 2025 15:32
@vincent-pochet vincent-pochet mentioned this pull request Jun 6, 2025
Merged
@vincent-pochet vincent-pochet force-pushed the feat-enable-pricing-group-keys branch from a24fd47 to 62e062b Compare June 6, 2025 07:38
This was referenced Jun 6, 2025
Merged
Merged
@vincent-pochet vincent-pochet force-pushed the feat-enable-pricing-group-keys branch from 62e062b to 8c6aae4 Compare June 6, 2025 13:16
@ansmonjol ansmonjol force-pushed the feat-enable-pricing-group-keys branch from 8c6aae4 to 6bd61ef Compare June 11, 2025 14:36
@vincent-pochet vincent-pochet force-pushed the feat-enable-pricing-group-keys branch from 6bd61ef to 8acf0a2 Compare June 13, 2025 15:02
@vincent-pochet vincent-pochet force-pushed the feat-enable-pricing-group-keys branch from 8d82ab5 to 1362284 Compare June 17, 2025 09:44
@vincent-pochet vincent-pochet merged commit 50ede46 into main Jun 17, 2025
14 checks passed
@vincent-pochet vincent-pochet deleted the feat-enable-pricing-group-keys branch June 17, 2025 09:48
diegocharles pushed a commit that referenced this pull request Jul 11, 2025
@vincent-pochet @diegocharles
feat(grouped_by): Allow pricing_group_keys on all charge models (#3790)
49be3fb 
## Context

This PR follows #3666,
#3681 and
#3789 as part of the epic to add
grouped_by feature on all charge models and not only on the standard one
like today.

## Description

This PR removes the restriction on charge model to allow
`pricing_group_keys` on every charge model
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienbourdeau julienbourdeau julienbourdeau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vincent-pochet @julienbourdeau