feat(pricing_group_keys): Add new pricing_group_keys API attribute
#3681
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5acfc30 to
b47dba0
Compare
pricing_group_keys API attribute
b47dba0 to
e5dff3b
Compare
annvelents
approved these changes
May 27, 2025
julienbourdeau
approved these changes
May 27, 2025
5e016f8 to
d397bff
Compare
d397bff to
f355a32
Compare
This was referenced Jun 5, 2025
vincent-pochet
added a commit
that referenced
this pull request
Jun 6, 2025
…ions (#3789) ## Context This PR follows #3666 and #3681 as part of the epic to add grouped_by feature on all charge models and not only on the standard one like today. ## Description This PR is the second step: - Adds the ability to inject a set of grouped_by values when fetching events in an event store implementation (with_grouped_by_values) - Takes advantage of this ability to change the implementation of all "per event" aggregation logic making sure it always targets the right pricing_group. For now the grouped aggregation remains remains whitelisted only on the standard and dynamic charge model. This will change in the next step of this feature.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This PR follows #3666 and is part of an epic to add grouped_by feature on all charge models and not only on the standard one like today.
Description
This PR is the second step:
pricing_group_keysattributegrouped_byattribute is still accepted and returnedpricing_group_keysor thegrouped_byattributesFor now the grouped aggregation remains remains whitelisted only on the standard and dynamic charge model. This will remain like this until the logic is applied to all charge model