Skip to content

feat(pricing_group_keys): Add grouped_by logic for per event aggregations #3789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 6, 2025
Merged

feat(pricing_group_keys): Add grouped_by logic for per event aggregations #3789

merged 2 commits into from
Jun 6, 2025

Conversation

vincent-pochet
Copy link
Collaborator

@vincent-pochet vincent-pochet commented Jun 5, 2025 •
edited
Loading

Context

This PR follows #3666 and #3681 as part of the epic to add grouped_by feature on all charge models and not only on the standard one like today.

Description

This PR is the second step:

  • Adds the ability to inject a set of grouped_by values when fetching events in an event store implementation (with_grouped_by_values)
  • Takes advantage of this ability to change the implementation of all "per event" aggregation logic making sure it always targets the right pricing_group.

For now the grouped aggregation remains remains whitelisted only on the standard and dynamic charge model. This will change in the next step of this feature.

@vincent-pochet vincent-pochet force-pushed the feat-events-grouped-by branch 3 times, most recently from e7f0845 to b31e613 Compare June 5, 2025 15:03
@vincent-pochet vincent-pochet mentioned this pull request Jun 5, 2025
Merged
@vincent-pochet vincent-pochet force-pushed the feat-events-grouped-by branch from b31e613 to 11d89b0 Compare June 6, 2025 13:09
@vincent-pochet vincent-pochet merged commit e269eae into main Jun 6, 2025
14 checks passed
@vincent-pochet vincent-pochet deleted the feat-events-grouped-by branch June 6, 2025 13:14
vincent-pochet added a commit that referenced this pull request Jun 17, 2025
@vincent-pochet
feat(grouped_by): Allow pricing_group_keys on all charge models (#3790)
50ede46 
## Context

This PR follows #3666,
#3681 and
#3789 as part of the epic to add
grouped_by feature on all charge models and not only on the standard one
like today.

## Description

This PR removes the restriction on charge model to allow
`pricing_group_keys` on every charge model
diegocharles pushed a commit that referenced this pull request Jul 11, 2025
@vincent-pochet @diegocharles
feat(grouped_by): Allow pricing_group_keys on all charge models (#3790)
49be3fb 
## Context

This PR follows #3666,
#3681 and
#3789 as part of the epic to add
grouped_by feature on all charge models and not only on the standard one
like today.

## Description

This PR removes the restriction on charge model to allow
`pricing_group_keys` on every charge model
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienbourdeau julienbourdeau julienbourdeau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vincent-pochet @julienbourdeau