Skip to content

Revert Add in advance charge consumer, to replace sidekiq hack #3325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 12, 2025
Merged

Revert Add in advance charge consumer, to replace sidekiq hack #3325

merged 1 commit into from
Mar 12, 2025

Conversation

ivannovosad
Copy link
Contributor

This reverts commit ff8e739

@ivannovosad ivannovosad requested a review from jdenquin March 12, 2025 13:15
@ivannovosad ivannovosad merged commit bd2391e into main Mar 12, 2025
6 checks passed
@ivannovosad ivannovosad deleted the revert/feat-kafka-in-advance-consumer branch March 12, 2025 13:32
vincent-pochet added a commit that referenced this pull request Mar 13, 2025
@vincent-pochet
Revert "Revert Add in advance charge consumer, to replace sidekiq hack (
0c66627 
#3325)"

This reverts commit bd2391e.
vincent-pochet added a commit that referenced this pull request Mar 13, 2025
@vincent-pochet
Reapply: Add in advance charge consumer, to replace sidekiq hack (#3325)
17b012f 
This reverts commit bd2391e.
vincent-pochet added a commit that referenced this pull request Mar 13, 2025
@vincent-pochet
Reapply: Add in advance charge consumer, to replace sidekiq hack (#3325)
5d63c0b 
This reverts commit bd2391e.
vincent-pochet added a commit that referenced this pull request Mar 13, 2025
@vincent-pochet
Reapply: Add in advance charge consumer, to replace sidekiq hack (#3325)
dbd5f9b 
This reverts commit bd2391e.
vincent-pochet added a commit that referenced this pull request Mar 13, 2025
@vincent-pochet
Reapply: Add in advance charge consumer, to replace sidekiq hack (#3325…
b0146f4 
…) (#3331)

This reverts commit bd2391e and reapply
ff8e739
with fixes

The `Karafka::Web.enable!` was called for every application, no matter
the presence of the correct configuration. This PR ensures it is turned
on only when expected
annvelents pushed a commit that referenced this pull request Mar 17, 2025
@ivannovosad @annvelents
Revert Add in advance charge consumer, to replace sidekiq hack (#3325)
592836d 
This reverts commit ff8e739
annvelents pushed a commit that referenced this pull request Mar 17, 2025
@vincent-pochet @annvelents
Reapply: Add in advance charge consumer, to replace sidekiq hack (#3325…
68d2fe9 
…) (#3331)

This reverts commit bd2391e and reapply
ff8e739
with fixes

The `Karafka::Web.enable!` was called for every application, no matter
the presence of the correct configuration. This PR ensures it is turned
on only when expected
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienbourdeau julienbourdeau julienbourdeau approved these changes

@jdenquin jdenquin Awaiting requested review from jdenquin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ivannovosad @julienbourdeau