feat(kafka): Add in advance charge consumer, to replace sidekiq hack #3291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cc2bc55 to
aa2d06e
Compare
aa2d06e to
fee89ad
Compare
jdenquin
approved these changes
Mar 11, 2025
annvelents
pushed a commit
that referenced
this pull request
Mar 17, 2025
…3291) ## Context This PR is related to getlago/lago#474 ## Description The main goal is to add a Kafka consumer responsible for handling events charged in advance. It replace the the "hacky" approach used in the current post-processor implementation that is pushing Sidekiq jobs from the go service. The consumer relies on the Karafka gem, making it easy to add new consumer in the future. For now the `EventsChargedInAdvanceConsumer` will only enqueue a `Events::PayInAdvanceJob` for every message received in the topic, making it easy to keep the simple setup without kafka/clickhouse
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This PR is related to getlago/lago#474
Description
The main goal is to add a Kafka consumer responsible for handling events charged in advance. It replace the the "hacky" approach used in the current post-processor implementation that is pushing Sidekiq jobs from the go service.
The consumer relies on the Karafka gem, making it easy to add new consumer in the future.
For now the
EventsChargedInAdvanceConsumerwill only enqueue aEvents::PayInAdvanceJobfor every message received in the topic, making it easy to keep the simple setup without kafka/clickhouse