Reapply: Add in advance charge consumer, to replace sidekiq hack (#3325) #3331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit bd2391e.
5d63c0b to
dbd5f9b
Compare
julienbourdeau
approved these changes
Mar 13, 2025
vincent-pochet
added a commit
that referenced
this pull request
Aug 28, 2025
## Description This PR removes the `Events::PayInAdvanceKafkaJob` job class. It's a legacy job that was enqueued before from the event processor. The need for this job was removed with introduction of the event pay in advance consumer in #3331
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit bd2391e and reapply ff8e739 with fixes
The
Karafka::Web.enable!was called for every application, no matter the presence of the correct configuration. This PR ensures it is turned on only when expected