enterText to move the caret to the end
#79506
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Dependent on #79489 |
|
Gold has detected about 3 untriaged digest(s) on patchset 3. |
enterText to have trailing caretenterText to move the caret to the end
LongCatIsLooong
commented
Apr 1, 2021
| @@ -848,18 +848,24 @@ void main() { | |||
| ); | |||
|
|
|||
| testWidgets('cursor layout has correct width', (WidgetTester tester) async { | |||
| final TextEditingController controller = TextEditingController.fromValue( | |||
There was a problem hiding this comment.
These golden tests were drawing the caret for position -1.
|
If you can land this without breaking the world then I am supportive, LGTM. Amusingly it'll conflict with two separate PRs I'm writing right now but luckily it won't do so in a complicated way and those two PRs are already conflicting with each other so whatever. ;-) |
Hixie
approved these changes
Apr 1, 2021
justinmc
approved these changes
Apr 1, 2021
| /// Give the text input widget specified by [finder] the focus and | ||
| /// enter [text] as if it been provided by the onscreen keyboard. | ||
| /// Give the text input widget specified by [finder] the focus, replace its | ||
| /// content with [text], as if it been provided by the onscreen keyboard. |
There was a problem hiding this comment.
Nit:
- focus, replace its content with [text], as if it been
+ focus and replace its content with [text], as if it had been
LongCatIsLooong
added a commit
that referenced
this pull request
Apr 2, 2021
LongCatIsLooong
added a commit
that referenced
this pull request
Apr 2, 2021
LongCatIsLooong
added a commit
to LongCatIsLooong/flutter
that referenced
this pull request
Apr 2, 2021
…verted in (flutter#79654) This reverts commit bf6e38d.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #79494. Running TGP to see how breaking this is. result(internal link).
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.