Skip to content

Fix length formatter typo #79489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 1, 2021
Merged

Fix length formatter typo #79489

merged 1 commit into from
Apr 1, 2021

Conversation

LongCatIsLooong
Copy link
Contributor

@LongCatIsLooong LongCatIsLooong commented Mar 31, 2021 •
edited
Loading

Currently the "max-out" mechanism only kicks in when the selection is (-1, -1).

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Mar 31, 2021
@google-cla google-cla bot added the cla: yes label Mar 31, 2021
@LongCatIsLooong LongCatIsLooong mentioned this pull request Apr 1, 2021
Merged
8 tasks
AlexV525
AlexV525 approved these changes Apr 1, 2021
View reviewed changes
Copy link
Member

@AlexV525 AlexV525 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM. Didn't expect that a "typo" would break the update method entirely.

@fluttergithubbot fluttergithubbot merged commit 7de099b into flutter:master Apr 1, 2021
@LongCatIsLooong LongCatIsLooong deleted the length-formatter-minor-fix branch April 1, 2021 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexV525 AlexV525 AlexV525 approved these changes

@justinmc justinmc Awaiting requested review from justinmc

Assignees
No one assigned
Labels
f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LongCatIsLooong @AlexV525 @fluttergithubbot