Skip to content

Revert "enterText to move the caret to the end" #79654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 2, 2021
Merged

Revert "enterText to move the caret to the end" #79654

merged 1 commit into from
Apr 2, 2021

Conversation

LongCatIsLooong
Copy link
Contributor

Reverts #79506

Looks like it broke some integration tests

@flutter-dashboard flutter-dashboard bot added a: tests "flutter test", flutter_test, or one of our tests f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Apr 2, 2021
@google-cla google-cla bot added the cla: yes label Apr 2, 2021
gspencergoog
gspencergoog approved these changes Apr 2, 2021
View reviewed changes
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

@LongCatIsLooong LongCatIsLooong merged commit bf6e38d into master Apr 2, 2021
@LongCatIsLooong LongCatIsLooong deleted the revert-79506-enter-text-to-have-trailing-caret branch April 2, 2021 17:57
LongCatIsLooong added a commit to LongCatIsLooong/flutter that referenced this pull request Apr 2, 2021
@LongCatIsLooong
Reland "enterText to move the caret to the end (flutter#79506)", re…
bd1b5e6 
…verted in (flutter#79654)

This reverts commit bf6e38d.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gspencergoog gspencergoog gspencergoog approved these changes

Assignees
No one assigned
Labels
a: tests "flutter test", flutter_test, or one of our tests f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LongCatIsLooong @gspencergoog