[Python] No longer scan datetime.datetime.max as infinity
#9848
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ate as infinity/-infinity in some situations
Mytherin
reviewed
Nov 29, 2023
d0dbf80 to
1c42009
Compare
'infinity' and '-infinity' when scanning TIMESTAMP and DATE columnsdatetime.datetime.max as infinity
|
Thanks! LGTM |
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Dec 14, 2023
Merge pull request duckdb/duckdb#9868 from Mytherin/tsanfix Merge pull request duckdb/duckdb#9846 from samansmink/fix-s3fs-close-issue Merge pull request duckdb/duckdb#9830 from carlopi/reworkcmakewasm Merge pull request duckdb/duckdb#9848 from Tishj/python_remove_infinity_scan Merge pull request duckdb/duckdb#9860 from chrisiou/fix-empty-box
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relates to #8143 and fixes #9520
To fix the issue mentioned we added support for outputting infinity as
datetime.datetime.max, to be able to roundtrip this, we also scanneddatetime.datetime.maxas infinity.This caused issues in other places.
To fix both issues, we now output the string
'infinity'instead.Also fixed some issues found while working on this, related to NaT and NA not being properly recognized as NULL