Fix s3fs close issue #9846
Merged
Fix s3fs close issue #9846
+7
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mytherin
approved these changes
Nov 29, 2023
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Dec 14, 2023
Merge pull request duckdb/duckdb#9868 from Mytherin/tsanfix Merge pull request duckdb/duckdb#9846 from samansmink/fix-s3fs-close-issue Merge pull request duckdb/duckdb#9830 from carlopi/reworkcmakewasm Merge pull request duckdb/duckdb#9848 from Tishj/python_remove_infinity_scan Merge pull request duckdb/duckdb#9860 from chrisiou/fix-empty-box
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes two CI issues.
The first one arose due to a failure to properly initialize the upload variables for the s3filehandle. This is now solved.
The second due to duckdb's increased memory usage failing the test/sql/copy/s3/upload_large_file.test_slow test. I solved this by slightly bumping the memory. I did not find anything the would point to a memory leak so we just use slightly more memory now. If this would need even more bumping in the future we should probably do more in depth investigation.