Skip to content

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jul 2, 2025

#3039 updates s2s_soil_moisture:0-1 which changes the output
Created by @georgemccabe

georgemccabe and others added 15 commits May 28, 2025 15:33
* per #2998, update instructions for updating truth data to note that the latest develop branch run needs to finish running. also cleaned up some out-of-date info

* add note to delete the temporary branch generated for updating develop-ref
* enhance pytest fixture so it will work with wrappers that don't have class variable WRAPPER_ENV_VAR_KEYS

* per #2980, add test to recreate bug when building a 3 year accumulation using 1 year accums

* clean up tests

* Per #2980, fix bug in determining accumulation seconds used to find last valid time to check for an accumulation -- The search time minus the output accumulation is used as the reference time to compute the number of seconds of the input accumulation. The input accumulation is subtracted from this time to determine the number of seconds, which depending on the time can cross over a leap year when the actual accumulation calculations do not. This fix adds the input accumulation to the 'first' time to ensure that it is correctly calculated
* Per 2857, added information about the team drive where data is uploaded to and labelling for organization or institution.

* Per #2857, resolved duplicate explicit target name warning.
* Per #2921, adding documentation for setting up a sphinx environment using MacPorts

* Per #2921, adding context to explain why a developer may need to run these commands.
* per #2577, add use case files

* turn off use case that shouldn't be on

* fix path to data and scripts

* fix path to plotting scripts

* added scripts to create wrf_plot conda env that contains the METplus Analysis requirements and the wrf package. change use case to use that env and obtain METdataio and METplotpy

* fix name of wrf python package

* override input and output directories in WRF plotting script

* clean up script re: SonarQube

* renaming variables for SonarQube

* turn off 100-m wind speed plot because zlev files are not included in the input data

* added missing closing single quote

* add version of package that was obtained for reproducibility

* refactor WRF plotting script to split logic into functions to reduce cognitive complexity

* try creating output directory before running reformatter

* METdataio reformatter does not accept environment variables in its config file, so attempting to change directory to output directory and find input data relative to that directory

* change approach to reference plot directory

* add WRF and MADIS file types to quick search keywords and start doc for new use case

* fix formatting for output file lists and correct info about output directories (use case path are added for automated tests, but are relative to {OUTPUT_BASE} if run by a user)

* write log file to logs directory and rename it to include .log extension

* add more information for use case doc

* turn off use case for PR

* refactor map functions script to reduce cognitive complexity for SonarQube

* update scientific objective with input from @jaredalee
* added config and docs. Added use case to testing files. Still needs img, testing

* updated config with file_type, use case img

* Small grammar change

---------

Co-authored-by: Christina Kalb <kalb@seneca.rap.ucar.edu>
… periodically to fix any security vulnerabilities in upstream images
* Adding graphic

* Updating python embedding script location

* Updating environment

* Updating environment

* Removing bad path

* Adding CI override

* Updating documentation

* Updating documenttion again

* Take 3

* Another documentation update

* Updating use case

* Updating the order of processes

* Updating documentation

* Cleaning up unused variables

* Updating documentation

* Adding climatology.  Testing will fail b/c haven't uploaded data

* Adding Series Analysis climatology and updating documentation

* Another doc update

* Fixing valid_beg

* fixing time

* Fixing documentation typo

* Fixed another typo

* Fixing log verbosity and block size

* Updating some code

* Fixing typo

* Testing removal of file_type

* Removing file type

* Setting tests to false for pull requests

* minor grammar, spelling updates

* Fixing increment

* Fixing Log level

* Update GridStat_fcstSFSGSL_obsERA5Land_SoilMoisture.conf

* editing plot title

---------

Co-authored-by: Christina Kalb <kalb@seneca.rap.ucar.edu>
Co-authored-by: j-opatz <59586397+j-opatz@users.noreply.github.com>
Co-authored-by: George McCabe <23407799+georgemccabe@users.noreply.github.com>
@georgemccabe georgemccabe added this to the METplus-6.1.0 milestone Jul 2, 2025
@github-project-automation github-project-automation bot moved this to 🩺 Needs Triage in METplus-6.1 Development Jul 2, 2025
@georgemccabe georgemccabe moved this from 🩺 Needs Triage to 🔎 In review in METplus-6.1 Development Jul 2, 2025
@georgemccabe georgemccabe merged commit ed2f52a into main_v6.1-ref Jul 2, 2025
1 check passed
@github-project-automation github-project-automation bot moved this from 🔎 In review to 🏁 Done in METplus-6.1 Development Jul 2, 2025
@georgemccabe georgemccabe deleted the update_main_v6.1_c812d4f0 branch July 2, 2025 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: 🏁 Done
Development

Successfully merging this pull request may close these issues.

5 participants