Skip to content

Conversation

CPKalb
Copy link
Contributor

@CPKalb CPKalb commented Jun 30, 2025

  • Adding graphic

  • Updating python embedding script location

  • Updating environment

  • Updating environment

  • Removing bad path

  • Adding CI override

  • Updating documentation

  • Updating documenttion again

  • Take 3

  • Another documentation update

  • Updating use case

  • Updating the order of processes

  • Updating documentation

  • Cleaning up unused variables

  • Updating documentation

  • Adding climatology. Testing will fail b/c haven't uploaded data

  • Adding Series Analysis climatology and updating documentation

  • Another doc update

  • Fixing valid_beg

  • fixing time

  • Fixing documentation typo

  • Fixed another typo

  • Fixing log verbosity and block size

  • Updating some code

  • Fixing typo

  • Testing removal of file_type

  • Removing file type

  • Setting tests to false for pull requests

  • minor grammar, spelling updates

  • Fixing increment

  • Fixing Log level

  • Update GridStat_fcstSFSGSL_obsERA5Land_SoilMoisture.conf

  • editing plot title


Pull Request Testing

  • Describe testing already performed for these changes:

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes or No]

  • Do these changes include sufficient testing updates? [Yes or No]

  • Will this PR result in changes to the test suite? [Yes or No]

    If yes, describe the new output and/or changes to the existing output:

  • Do these changes introduce new SonarQube findings? [Yes or No]

    If yes, please describe:

  • Please complete this pull request review by [Fill in date].

Pull Request Checklist

See the METplus Workflow for details.

  • Add any new Python packages to the METplus Components Python Requirements table.
  • For any new datasets, an entry to the METplus Verification Datasets Guide.
  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the version that will include these changes
    Select: Coordinated METplus-X.Y Support project for bugfix releases or METplus-Wrappers-X.Y.Z Development project for official releases
  • After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

* Adding graphic

* Updating python embedding script location

* Updating environment

* Updating environment

* Removing bad path

* Adding CI override

* Updating documentation

* Updating documenttion again

* Take 3

* Another documentation update

* Updating use case

* Updating the order of processes

* Updating documentation

* Cleaning up unused variables

* Updating documentation

* Adding climatology.  Testing will fail b/c haven't uploaded data

* Adding Series Analysis climatology and updating documentation

* Another doc update

* Fixing valid_beg

* fixing time

* Fixing documentation typo

* Fixed another typo

* Fixing log verbosity and block size

* Updating some code

* Fixing typo

* Testing removal of file_type

* Removing file type

* Setting tests to false for pull requests

* minor grammar, spelling updates

* Fixing increment

* Fixing Log level

* Update GridStat_fcstSFSGSL_obsERA5Land_SoilMoisture.conf

* editing plot title

---------

Co-authored-by: Christina Kalb <kalb@seneca.rap.ucar.edu>
Co-authored-by: j-opatz <59586397+j-opatz@users.noreply.github.com>
Co-authored-by: George McCabe <23407799+georgemccabe@users.noreply.github.com>
@CPKalb CPKalb requested a review from j-opatz June 30, 2025 21:51
@georgemccabe georgemccabe added this to the METplus-6.1.0 milestone Jul 2, 2025
@github-project-automation github-project-automation bot moved this to 🩺 Needs Triage in METplus-6.1 Development Jul 2, 2025
@georgemccabe georgemccabe moved this from 🩺 Needs Triage to 🔎 In review in METplus-6.1 Development Jul 2, 2025
@georgemccabe georgemccabe merged commit 6bdd080 into main_v6.1 Jul 2, 2025
81 of 84 checks passed
@github-project-automation github-project-automation bot moved this from 🔎 In review to 🏁 Done in METplus-6.1 Development Jul 2, 2025
@georgemccabe georgemccabe deleted the feature_3014_main_v6.1_SFS_updates branch July 2, 2025 14:20
georgemccabe pushed a commit that referenced this pull request Jul 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: 🏁 Done
Development

Successfully merging this pull request may close these issues.

Enhancement: Add additional processing to the GridStat_fcstSFSFGSL_obsERA5Land_SoilMoisture use case
2 participants