Skip to content

Feature 2723 use case sep climates #3030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 27, 2025
Merged

Feature 2723 use case sep climates #3030

merged 3 commits into from
Jun 27, 2025

Conversation

j-opatz
Copy link
Contributor

@j-opatz j-opatz commented Jun 18, 2025 •
edited by CPKalb
Loading

Pull Request Testing

  • Describe testing already performed for these changes:
    Use case was checked for running, docs were also checked for logical content.

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
    Review the documentation here.
    Also review the GHA results; they should only consist of "new" data found. If desired, I can point you to the data on Seneca to manually run the use case (very simplistic, no additional envs needed/no Python).

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]

  • Do these changes include sufficient testing updates? [Yes]

  • Will this PR result in changes to the test suite? [Yes]

    If yes, describe the new output and/or changes to the existing output:
    new use case == new truth data from the results

  • Do these changes introduce new SonarQube findings? [No]

    If yes, please describe:

  • Please complete this pull request review by 6/30.

Pull Request Checklist

See the METplus Workflow for details.

  • Add any new Python packages to the METplus Components Python Requirements table.
  • For any new datasets, an entry to the METplus Verification Datasets Guide.
  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the version that will include these changes
    Select: Coordinated METplus-X.Y Support project for bugfix releases or METplus-Wrappers-X.Y.Z Development project for official releases
  • After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@j-opatz j-opatz added this to the METplus-6.1.0 milestone Jun 18, 2025
@j-opatz j-opatz requested a review from CPKalb June 18, 2025 22:08
@github-project-automation github-project-automation bot moved this to 🩺 Needs Triage in METplus-6.1 Development Jun 18, 2025
@j-opatz j-opatz moved this from 🩺 Needs Triage to 🔎 In review in METplus-6.1 Development Jun 18, 2025
@j-opatz j-opatz linked an issue Jun 18, 2025 that may be closed by this pull request
New Use Case: GridStat: Apply separate climatologies for forecast and observations #2723
Closed
26 tasks
@CPKalb
Copy link
Contributor

CPKalb commented Jun 26, 2025

@j-opatz, I see some missing files in actions for this use case. Is this expected?

@j-opatz
Copy link
Contributor Author

j-opatz commented Jun 26, 2025

@j-opatz, I see some missing files in actions for this use case. Is this expected?

Great catch, Tina! It's definitely not expected; I'm not even sure how that unrelated use case suddenly has changes to its output AND it's recording that change under my use case's testing scheme. I wonder if it has something to do with the file type update for climo...

Either way, it seems likely that I'll need to pull in George for a review of this behavior.

@CPKalb
Copy link
Contributor

CPKalb commented Jun 26, 2025

Everything else looks good to me, so once we get these weird missing files figured out, I'll be ready to approve.

@georgemccabe
Copy link
Collaborator

@j-opatz , @CPKalb , my guess is the other use case was previously saved at s2s:6 at some point, so there is an existing output data volume on DockerHub that contains the other use case's output. I think you can go ahead and update the truth data to overwrite that one after this PR is merged.

@georgemccabe
Copy link
Collaborator

Yup, the existing output was created 1 year ago: https://hub.docker.com/repository/docker/dtcenter/metplus-data-dev/tags/output-develop-s2s_6/sha256:2591fff59a0185e246fafdfc916bd095c0e333a774bfd374436545f420a2a1ab
This was from before we split up s2s into multiple use case categories. You can ignore the missing files in the diffs.

CPKalb
CPKalb approved these changes Jun 26, 2025
View reviewed changes
Copy link
Contributor

@CPKalb CPKalb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation looks good. The missing files in GHA are due to a use case that was moved. Otherwise, the only errors are due to new data.

@CPKalb CPKalb self-requested a review June 27, 2025 20:40
CPKalb
CPKalb approved these changes Jun 27, 2025
View reviewed changes
Copy link
Contributor

@CPKalb CPKalb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving

@j-opatz j-opatz merged commit a55b1a4 into develop Jun 27, 2025
74 of 75 checks passed
@github-project-automation github-project-automation bot moved this from 🔎 In review to 🏁 Done in METplus-6.1 Development Jun 27, 2025
j-opatz added a commit that referenced this pull request Jun 30, 2025
@j-opatz
Feature 2723 use case sep climates (#3030)
28d56c0 
* added config and docs. Added use case to testing files. Still needs img, testing

* updated config with file_type, use case img

* Small grammar change

---------

Co-authored-by: Christina Kalb <kalb@seneca.rap.ucar.edu>
metplus-bot added a commit that referenced this pull request Jun 30, 2025
@metplus-bot
added entry to update truth change log: develop #2981, #3020, #3030
5229dd2
@github-actions github-actions bot mentioned this pull request Jun 30, 2025
Merged
georgemccabe pushed a commit that referenced this pull request Jun 30, 2025
@github-actions
Update develop-ref after #2981, #3020, #3030 (#3038)
a5f9e4c
j-opatz added a commit that referenced this pull request Jul 1, 2025
@j-opatz
Feature 2723 use case sep climates (#3030) (#3037)
4a6f65f 
* added config and docs. Added use case to testing files. Still needs img, testing

* updated config with file_type, use case img

* Small grammar change

---------

Co-authored-by: Christina Kalb <kalb@seneca.rap.ucar.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CPKalb CPKalb CPKalb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
METplus-6.1 Development
Status: 🏁 Done
Milestone
METplus-6.1.0
Development

Successfully merging this pull request may close these issues.

New Use Case: GridStat: Apply separate climatologies for forecast and observations
3 participants
@j-opatz @CPKalb @georgemccabe