Feature 2857 main v6.1 support #3013
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed to and labelling for organization or institution.
23 tasks
georgemccabe
approved these changes
Jun 5, 2025
georgemccabe
added a commit
that referenced
this pull request
Jun 9, 2025
* Feature #2998 main_v6.1 - updating truth data instructions (#3002) * per #2998, update instructions for updating truth data to note that the latest develop branch run needs to finish running. also cleaned up some out-of-date info * add note to delete the temporary branch generated for updating develop-ref * Per #2953, updating existing builds page. (#3003) * Bugfix #2980 main_v6.1 - PCPCombine 3 year accum bug (#3006) * enhance pytest fixture so it will work with wrappers that don't have class variable WRAPPER_ENV_VAR_KEYS * per #2980, add test to recreate bug when building a 3 year accumulation using 1 year accums * clean up tests * Per #2980, fix bug in determining accumulation seconds used to find last valid time to check for an accumulation -- The search time minus the output accumulation is used as the reference time to compute the number of seconds of the input accumulation. The input accumulation is subtracted from this time to determine the number of seconds, which depending on the time can cross over a leap year when the actual accumulation calculations do not. This fix adds the input accumulation to the 'first' time to ensure that it is correctly calculated * Feature 2857 main v6.1 support (#3013) * Per 2857, added information about the team drive where data is uploaded to and labelling for organization or institution. * Per #2857, resolved duplicate explicit target name warning. * added entry to update truth change log: main_v6.1 dtcenter/METdataio#384 --------- Co-authored-by: George McCabe <23407799+georgemccabe@users.noreply.github.com> Co-authored-by: Julie Prestopnik <jpresto@ucar.edu> Co-authored-by: metplus-bot <97135045+metplus-bot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notable changes include:
Note that there are separate pull requests in:
METplotpy:
develop: dtcenter/METplotpy#513
main_v3.1: dtcenter/METplotpy#512
METcalcpy:
develop: dtcenter/METcalcpy#442
main_v3.1: dtcenter/METcalcpy#443
METdataio:
develop: dtcenter/METdataio#382
main_v3.1: dtcenter/METdataio#381
METviewer:
develop: dtcenter/METviewer#581
main_v6.1: dtcenter/METviewer#582
which are also involved in completing this task.
Pull Request Testing
Describe testing already performed for these changes:
Reviewed changes in Read The Docs here and here.
Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
Please review documentation changes and ensure all tests pass.
Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]
Do these changes include sufficient testing updates? [Yes]
Will this PR result in changes to the test suite? [No]
If yes, describe the new output and/or changes to the existing output:
Do these changes introduce new SonarQube findings? [No]
If yes, please describe:
Please complete this pull request review by [20250616].
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s) and Development issue
Select: Milestone as the version that will include these changes
Select: Coordinated METplus-X.Y Support project for bugfix releases or METplus-Wrappers-X.Y.Z Development project for official releases