Skip to content

protobuf: bump patch versions #21592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 11, 2023
Merged

protobuf: bump patch versions #21592

merged 1 commit into from
Dec 11, 2023

Conversation

valgur
Copy link
Contributor

@valgur valgur commented Dec 4, 2023

No description provided.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2023

🤖 Beep Boop! This pull request is making changes to 'recipes/protobuf//'.

👋 @Hopobcn you might be interested. 😉

@ghost
Copy link

ghost commented Dec 4, 2023 •
edited by ghost
Loading

I detected other pull requests that are modifying protobuf/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

This was referenced Dec 4, 2023
Closed
Merged
@prince-chrismc prince-chrismc mentioned this pull request Dec 4, 2023
Open
@conan-center-bot

This comment has been minimized.

Sign in to view
@ericLemanissier ericLemanissier mentioned this pull request Dec 5, 2023
Closed
coryan
coryan reviewed Dec 5, 2023
View reviewed changes
Copy link
Contributor

@coryan coryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Starting with 3.25.x µpb development was moved to the Protobuf repository:

https://protobuf.dev/news/2023-09-15/

This adds a number of new libraries that need to be represented as components. Note that this is not Protobuf "vendoring" µpb, the same team creates both and plan to only continue development in the Protobuf repository.

Likewise, utf8 is now part of the Protobuf repository:

https://github.com/protocolbuffers/protobuf/blame/main/third_party/utf8_range/CMakeLists.txt

HTH

recipes/protobuf/all/conandata.yml Outdated
Comment on lines 2 to 4
"3.25.1":
url: "https://github.com/protocolbuffers/protobuf/archive/refs/tags/v3.25.1.tar.gz"
sha256: "1a2affa2fbad568b9895b72e3c7cb1f72a14bf2501fba056c724dc68c249cd0f"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Protobuf versioning is complicated:

https://protobuf.dev/news/2022-05-06/

The major version for C++ changed with v22:

https://protobuf.dev/news/2022-08-03/

Suggested change
"3.25.1":
url: "https://github.com/protocolbuffers/protobuf/archive/refs/tags/v3.25.1.tar.gz"
sha256: "1a2affa2fbad568b9895b72e3c7cb1f72a14bf2501fba056c724dc68c249cd0f"
"4.25.1":
url: "https://github.com/protocolbuffers/protobuf/archive/refs/tags/v4.25.1.tar.gz"
sha256: "e5b6dac700b6b319fd3329a84ed1594477d645591d7a484657c84cc8f28e28d8"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This will require quite a bit more work than I anticipated. My only real goal was to get the latest version of gRPC to build.
I noticed that #16098 already includes some of the required changes you mention. I'll revert the changes here and create a separate PR based on them.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done: #21622

@ghost ghost mentioned this pull request Dec 5, 2023
Closed
@conan-center-bot
Copy link
Contributor

Conan v1 pipeline ✔️

All green in build 2 (2877874d94338a314688b6b8809d5905742b13de):

  • protobuf/3.18.3:
    All packages built successfully! (All logs)

  • protobuf/3.20.3:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 2 (2877874d94338a314688b6b8809d5905742b13de):

  • protobuf/3.20.3:
    All packages built successfully! (All logs)

  • protobuf/3.18.3:
    All packages built successfully! (All logs)

uilianries
uilianries approved these changes Dec 7, 2023
View reviewed changes
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, checking current recipes in master, no affected package.

find recipes -name conanfile.py -exec grep protobuf {} +

@uilianries uilianries self-assigned this Dec 7, 2023
@conan-center-bot conan-center-bot merged commit 7ba21bc into conan-io:master Dec 11, 2023
hoyhoy pushed a commit to hoyhoy/conan-center-index that referenced this pull request Dec 18, 2023
@valgur
(conan-io#21592) protobuf: bump patch versions
f11a481
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uilianries uilianries uilianries approved these changes

+2 more reviewers

@coryan coryan coryan left review comments

@toge toge toge approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@uilianries uilianries

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@valgur @conan-center-bot @toge @uilianries @coryan