Skip to content

Conversation

luizfeldmann
Copy link
Contributor

Specify library name and version: protobuf/3.5.1

This is an older version of the library but it's important to have it here because it's the last one to support C++98.


@github-actions
Copy link
Contributor

🤖 Beep Boop! This pull request is making changes to 'recipes/protobuf//'.

👋 @Hopobcn you might be interested. 😉

@ghost
Copy link

ghost commented Oct 17, 2023

I detected other pull requests that are modifying protobuf/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@conan-center-bot

This comment has been minimized.

@github-actions
Copy link
Contributor

Hooks produced the following warnings for commit 9282bed
protobuf/3.5.1@#f37d6348284a821cc983ab08f2c29d61
post_package(): WARN: [APPLE RELOCATABLE SHARED LIBS (KB-H077)] install_name dir of these shared libs is not @rpath: libprotoc.dylib, libprotobuf.dylib

@luizfeldmann
Copy link
Contributor Author

[help wanted]
@lucaskdc @jcbecker @Hopobcn

@lucaskdc
Copy link
Contributor

lucaskdc commented Oct 26, 2023

Regarding the macOS build failure. It happens because there is no patch to the GID fields for 3.5.1 in the test_package for this version. Other versions of protobuf received those patches (see the PR #16453). That bug is officially fixed since 3.22.0, and probably can be easily be backported to 3.7.1 (using the port_def.inc and port_undef.inc mechanism).

The reason the mentioned PR give to backport this bugfix to 3.21.12 is to allow the googleapis to use it. See googleapis conanfile.

I suggest to change the test_package to let this bug pass in 3.5.1. @jcar87 any opinion on this?

@conan-center-bot

This comment has been minimized.

@github-actions
Copy link
Contributor

Hooks produced the following warnings for commit 0f88ca2
protobuf/3.5.1@#a604aeda29284b002b2a1d2041c5c399
post_package(): WARN: [APPLE RELOCATABLE SHARED LIBS (KB-H077)] install_name dir of these shared libs is not @rpath: libprotocd.dylib, libprotobufd.dylib

@uilianries
Copy link
Member

Saudações @luizfeldmann and @lucaskdc I don't recommend skipping the test package, it's important to keep reproducibility and validate the generated package. Instead, I would ask to backport patch if possible. You see, without the test package we can't confirm if that package is really working when distributed.

@uilianries uilianries self-assigned this Oct 27, 2023
@luizfeldmann
Copy link
Contributor Author

luizfeldmann commented Oct 29, 2023

Running the command conan create -s build_type=Debug -o protobuf:shared=True -tf test_v1_package . protobuf/3.5.1@ --build=missing I was able to reproduce the error:

dyld[13117]: Library not loaded: 'libprotocd.dylib'
  Referenced from: '/Users/jenkins/w/prod-v1/bsr@3/36213/dccff/.conan/data/protobuf/3.5.1/_/_/package/6ba6920b22b03a7cda05599853afac26e7fdfce2/bin/protoc'
  Reason: tried: 'libprotocd.dylib' (no such file), '/usr/local/lib/libprotocd.dylib' (no such file), '/usr/lib/libprotocd.dylib' (no such file), '/Users/jenkins/w/prod-v1/bsr@3/cci-a6bfc911/recipes/protobuf/all/test_v1_package/build/9be9c4d74b252db4497c80d51dbbc27e25fa4789/test_package/libprotocd.dylib'

As I'm not familiar with macOS, I'm assuming it's related to @rpath warning produced by the hook.

* CMake: osx use @rpath/ as target's install name (CMP0042)

On MacoS library should use @rpath/ as prefix path instead of absolute build path
e.g. otool -L libprotobuf.dylib
libprotobuf.dylib:
  @rpath/libprotobuf.dylib (...)
  ...

* CMake: add rpath to target for LINUX and APPLE
@luizfeldmann
Copy link
Contributor Author

This PR seems to address this issue.

@conan-center-bot

This comment has been minimized.

@luizfeldmann
Copy link
Contributor Author

New issue related to source file generated at build-time, see:
protocolbuffers/protobuf#4694
protocolbuffers/protobuf#4704

The build process generates a custom executable js_embed which in turn generates the file src/google/protobuf/compiler/js/well_known_types_embed.cc before the build can continue.

This method seems to break cross-compilations and because the host cannot run this executable (which is built for the cross compilation target and not for the host architecture).

This PR later resolved the issues by completely removing this step and instead having this file being part of the source instead of auto-generated.

@conan-center-bot
Copy link
Contributor

Conan v1 pipeline ✔️

All green in build 6 (8ed216b06e1e8c78c2b24d16c7ddd12ba5ab7cf6):

  • protobuf/3.21.12:
    All packages built successfully! (All logs)

  • protobuf/3.21.4:
    All packages built successfully! (All logs)

  • protobuf/3.17.1:
    All packages built successfully! (All logs)

  • protobuf/3.21.9:
    All packages built successfully! (All logs)

  • protobuf/3.20.0:
    All packages built successfully! (All logs)

  • protobuf/3.19.4:
    All packages built successfully! (All logs)

  • protobuf/3.19.6:
    All packages built successfully! (All logs)

  • protobuf/3.18.1:
    All packages built successfully! (All logs)

  • protobuf/3.5.1:
    All packages built successfully! (All logs)


Conan v2 pipeline ❌

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping @conan-io/barbarians on the PR and we will help you.

See details:

Failure in build 6 (8ed216b06e1e8c78c2b24d16c7ddd12ba5ab7cf6):

  • protobuf/3.21.12:
    All packages built successfully! (All logs)

  • protobuf/3.21.4:
    All packages built successfully! (All logs)

  • protobuf/3.19.4:
    All packages built successfully! (All logs)

  • protobuf/3.17.1:
    All packages built successfully! (All logs)

  • protobuf/3.20.0:
    All packages built successfully! (All logs)

  • protobuf/3.21.9:
    All packages built successfully! (All logs)

  • protobuf/3.19.6:
    All packages built successfully! (All logs)

  • protobuf/3.18.1:
    All packages built successfully! (All logs)

  • protobuf/3.5.1:
    CI failed to create some packages (All logs)

    Logs for packageID cea0268b76c1bf488a11fff7944a4d94534ae7c9:
    [settings]
    arch=x86_64
    build_type=Release
    compiler=msvc
    compiler.cppstd=14
    compiler.runtime=dynamic
    compiler.runtime_type=Release
    compiler.version=193
    os=Windows
    [options]
    */*:shared=False
    
    [...]
      strutil.cc
    C:\J2\w\prod-v2\bsr\30172\caade\p\b\protodbe86560baa54\b\src\src\google/protobuf/stubs/hash.h(255,14): error C2039: 'hash_compare': is not a member of 'std' (compiling source file C:\J2\w\prod-v2\bsr\30172\caade\p\b\protodbe86560baa54\b\src\src\google\protobuf\stubs\statusor.cc) [C:\J2\w\prod-v2\bsr\30172\caade\p\b\protodbe86560baa54\b\build\libprotobuf-lite.vcxproj]
    C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.36.32532\include\unordered_set(24,1): message : see declaration of 'std' (compiling source file C:\J2\w\prod-v2\bsr\30172\caade\p\b\protodbe86560baa54\b\src\src\google\protobuf\stubs\statusor.cc) [C:\J2\w\prod-v2\bsr\30172\caade\p\b\protodbe86560baa54\b\build\libprotobuf-lite.vcxproj]
    C:\J2\w\prod-v2\bsr\30172\caade\p\b\protodbe86560baa54\b\src\src\google/protobuf/stubs/hash.h(255): error C2504: 'hash_compare': base class undefined (compiling source file C:\J2\w\prod-v2\bsr\30172\caade\p\b\protodbe86560baa54\b\src\src\google\protobuf\stubs\statusor.cc) [C:\J2\w\prod-v2\bsr\30172\caade\p\b\protodbe86560baa54\b\build\libprotobuf-lite.vcxproj]
    C:\J2\w\prod-v2\bsr\30172\caade\p\b\protodbe86560baa54\b\src\src\google/protobuf/stubs/hash.h(255,42): error C2143: syntax error: missing ',' before '<' (compiling source file C:\J2\w\prod-v2\bsr\30172\caade\p\b\protodbe86560baa54\b\src\src\google\protobuf\stubs\statusor.cc) [C:\J2\w\prod-v2\bsr\30172\caade\p\b\protodbe86560baa54\b\build\libprotobuf-lite.vcxproj]
    C:\J2\w\prod-v2\bsr\30172\caade\p\b\protodbe86560baa54\b\src\src\google/protobuf/stubs/hash.h(400,29): error C2064: term does not evaluate to a function taking 1 arguments (compiling source file C:\J2\w\prod-v2\bsr\30172\caade\p\b\protodbe86560baa54\b\src\src\google\protobuf\stubs\statusor.cc) [C:\J2\w\prod-v2\bsr\30172\caade\p\b\protodbe86560baa54\b\build\libprotobuf-lite.vcxproj]
      time.cc
    C:\J2\w\prod-v2\bsr\30172\caade\p\b\protodbe86560baa54\b\src\src\google/protobuf/stubs/hash.h(241,50): error C2143: syntax error: missing ',' before '<' (compiling source file C:\J2\w\prod-v2\bsr\30172\caade\p\b\protodbe86560baa54\b\src\src\google\protobuf\stubs\stringpiece.cc) [C:\J2\w\prod-v2\bsr\30172\caade\p\b\protodbe86560baa54\b\build\libprotobuf-lite.vcxproj]
    C:\J2\w\prod-v2\bsr\30172\caade\p\b\protodbe86560baa54\b\src\src\google/protobuf/stubs/hash.h(242,2): message : see reference to class template instantiation 'google::protobuf::hash<Key>' being compiled (compiling source file C:\J2\w\prod-v2\bsr\30172\caade\p\b\protodbe86560baa54\b\src\src\google\protobuf\stubs\stringpiece.cc) [C:\J2\w\prod-v2\bsr\30172\caade\p\b\protodbe86560baa54\b\build\libprotobuf-lite.vcxproj]
    C:\J2\w\prod-v2\bsr\30172\caade\p\b\protodbe86560baa54\b\src\src\google/protobuf/stubs/hash.h(255,14): error C2039: 'hash_compare': is not a member of 'std' (compiling source file C:\J2\w\prod-v2\bsr\30172\caade\p\b\protodbe86560baa54\b\src\src\google\protobuf\stubs\stringpiece.cc) [C:\J2\w\prod-v2\bsr\30172\caade\p\b\protodbe86560baa54\b\build\libprotobuf-lite.vcxproj]
    C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.36.32532\include\unordered_set(24,1): message : see declaration of 'std' (compiling source file C:\J2\w\prod-v2\bsr\30172\caade\p\b\protodbe86560baa54\b\src\src\google\protobuf\stubs\stringpiece.cc) [C:\J2\w\prod-v2\bsr\30172\caade\p\b\protodbe86560baa54\b\build\libprotobuf-lite.vcxproj]
      wire_format_lite.cc
    C:\J2\w\prod-v2\bsr\30172\caade\p\b\protodbe86560baa54\b\src\src\google/protobuf/stubs/hash.h(255): error C2504: 'hash_compare': base class undefined (compiling source file C:\J2\w\prod-v2\bsr\30172\caade\p\b\protodbe86560baa54\b\src\src\google\protobuf\stubs\stringpiece.cc) [C:\J2\w\prod-v2\bsr\30172\caade\p\b\protodbe86560baa54\b\build\libprotobuf-lite.vcxproj]
    C:\J2\w\prod-v2\bsr\30172\caade\p\b\protodbe86560baa54\b\src\src\google/protobuf/stubs/hash.h(255,42): error C2143: syntax error: missing ',' before '<' (compiling source file C:\J2\w\prod-v2\bsr\30172\caade\p\b\protodbe86560baa54\b\src\src\google\protobuf\stubs\stringpiece.cc) [C:\J2\w\prod-v2\bsr\30172\caade\p\b\protodbe86560baa54\b\build\libprotobuf-lite.vcxproj]
    C:\J2\w\prod-v2\bsr\30172\caade\p\b\protodbe86560baa54\b\src\src\google/protobuf/stubs/hash.h(400,29): error C2064: term does not evaluate to a function taking 1 arguments (compiling source file C:\J2\w\prod-v2\bsr\30172\caade\p\b\protodbe86560baa54\b\src\src\google\protobuf\stubs\stringpiece.cc) [C:\J2\w\prod-v2\bsr\30172\caade\p\b\protodbe86560baa54\b\build\libprotobuf-lite.vcxproj]
    C:\J2\w\prod-v2\bsr\30172\caade\p\b\protodbe86560baa54\b\src\src\google/protobuf/stubs/hash.h(241,50): error C2143: syntax error: missing ',' before '<' (compiling source file C:\J2\w\prod-v2\bsr\30172\caade\p\b\protodbe86560baa54\b\src\src\google\protobuf\stubs\structurally_valid.cc) [C:\J2\w\prod-v2\bsr\30172\caade\p\b\protodbe86560baa54\b\build\libprotobuf-lite.vcxproj]
    C:\J2\w\prod-v2\bsr\30172\caade\p\b\protodbe86560baa54\b\src\src\google/protobuf/stubs/hash.h(242,2): message : see reference to class template instantiation 'google::protobuf::hash<Key>' being compiled (compiling source file C:\J2\w\prod-v2\bsr\30172\caade\p\b\protodbe86560baa54\b\src\src\google\protobuf\stubs\structurally_valid.cc) [C:\J2\w\prod-v2\bsr\30172\caade\p\b\protodbe86560baa54\b\build\libprotobuf-lite.vcxproj]
    C:\J2\w\prod-v2\bsr\30172\caade\p\b\protodbe86560baa54\b\src\src\google/protobuf/stubs/hash.h(255,14): error C2039: 'hash_compare': is not a member of 'std' (compiling source file C:\J2\w\prod-v2\bsr\30172\caade\p\b\protodbe86560baa54\b\src\src\google\protobuf\stubs\structurally_valid.cc) [C:\J2\w\prod-v2\bsr\30172\caade\p\b\protodbe86560baa54\b\build\libprotobuf-lite.vcxproj]
    C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.36.32532\include\unordered_set(24,1): message : see declaration of 'std' (compiling source file C:\J2\w\prod-v2\bsr\30172\caade\p\b\protodbe86560baa54\b\src\src\google\protobuf\stubs\structurally_valid.cc) [C:\J2\w\prod-v2\bsr\30172\caade\p\b\protodbe86560baa54\b\build\libprotobuf-lite.vcxproj]
    C:\J2\w\prod-v2\bsr\30172\caade\p\b\protodbe86560baa54\b\src\src\google/protobuf/stubs/hash.h(255): error C2504: 'hash_compare': base class undefined (compiling source file C:\J2\w\prod-v2\bsr\30172\caade\p\b\protodbe86560baa54\b\src\src\google\protobuf\stubs\structurally_valid.cc) [C:\J2\w\prod-v2\bsr\30172\caade\p\b\protodbe86560baa54\b\build\libprotobuf-lite.vcxproj]
    C:\J2\w\prod-v2\bsr\30172\caade\p\b\protodbe86560baa54\b\src\src\google/protobuf/stubs/hash.h(255,42): error C2143: syntax error: missing ',' before '<' (compiling source file C:\J2\w\prod-v2\bsr\30172\caade\p\b\protodbe86560baa54\b\src\src\google\protobuf\stubs\structurally_valid.cc) [C:\J2\w\prod-v2\bsr\30172\caade\p\b\protodbe86560baa54\b\build\libprotobuf-lite.vcxproj]
    C:\J2\w\prod-v2\bsr\30172\caade\p\b\protodbe86560baa54\b\src\src\google/protobuf/stubs/hash.h(400,29): error C2064: term does not evaluate to a function taking 1 arguments (compiling source file C:\J2\w\prod-v2\bsr\30172\caade\p\b\protodbe86560baa54\b\src\src\google\protobuf\stubs\structurally_valid.cc) [C:\J2\w\prod-v2\bsr\30172\caade\p\b\protodbe86560baa54\b\build\libprotobuf-lite.vcxproj]
    C:\J2\w\prod-v2\bsr\30172\caade\p\b\protodbe86560baa54\b\src\src\google/protobuf/stubs/hash.h(241,50): error C2143: syntax error: missing ',' before '<' (compiling source file C:\J2\w\prod-v2\bsr\30172\caade\p\b\protodbe86560baa54\b\src\src\google\protobuf\stubs\strutil.cc) [C:\J2\w\prod-v2\bsr\30172\caade\p\b\protodbe86560baa54\b\build\libprotobuf-lite.vcxproj]
    C:\J2\w\prod-v2\bsr\30172\caade\p\b\protodbe86560baa54\b\src\src\google/protobuf/stubs/hash.h(242,2): message : see reference to class template instantiation 'google::protobuf::hash<Key>' being compiled (compiling source file C:\J2\w\prod-v2\bsr\30172\caade\p\b\protodbe86560baa54\b\src\src\google\protobuf\stubs\strutil.cc) [C:\J2\w\prod-v2\bsr\30172\caade\p\b\protodbe86560baa54\b\build\libprotobuf-lite.vcxproj]
    C:\J2\w\prod-v2\bsr\30172\caade\p\b\protodbe86560baa54\b\src\src\google/protobuf/stubs/hash.h(255,14): error C2039: 'hash_compare': is not a member of 'std' (compiling source file C:\J2\w\prod-v2\bsr\30172\caade\p\b\protodbe86560baa54\b\src\src\google\protobuf\stubs\strutil.cc) [C:\J2\w\prod-v2\bsr\30172\caade\p\b\protodbe86560baa54\b\build\libprotobuf-lite.vcxproj]
    C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.36.32532\include\unordered_set(24,1): message : see declaration of 'std' (compiling source file C:\J2\w\prod-v2\bsr\30172\caade\p\b\protodbe86560baa54\b\src\src\google\protobuf\stubs\strutil.cc) [C:\J2\w\prod-v2\bsr\30172\caade\p\b\protodbe86560baa54\b\build\libprotobuf-lite.vcxproj]
    C:\J2\w\prod-v2\bsr\30172\caade\p\b\protodbe86560baa54\b\src\src\google/protobuf/stubs/hash.h(255): error C2504: 'hash_compare': base class undefined (compiling source file C:\J2\w\prod-v2\bsr\30172\caade\p\b\protodbe86560baa54\b\src\src\google\protobuf\stubs\strutil.cc) [C:\J2\w\prod-v2\bsr\30172\caade\p\b\protodbe86560baa54\b\build\libprotobuf-lite.vcxproj]
    C:\J2\w\prod-v2\bsr\30172\caade\p\b\protodbe86560baa54\b\src\src\google/protobuf/stubs/hash.h(255,42): error C2143: syntax error: missing ',' before '<' (compiling source file C:\J2\w\prod-v2\bsr\30172\caade\p\b\protodbe86560baa54\b\src\src\google\protobuf\stubs\strutil.cc) [C:\J2\w\prod-v2\bsr\30172\caade\p\b\protodbe86560baa54\b\build\libprotobuf-lite.vcxproj]
    C:\J2\w\prod-v2\bsr\30172\caade\p\b\protodbe86560baa54\b\src\src\google/protobuf/stubs/hash.h(400,29): error C2064: term does not evaluate to a function taking 1 arguments (compiling source file C:\J2\w\prod-v2\bsr\30172\caade\p\b\protodbe86560baa54\b\src\src\google\protobuf\stubs\strutil.cc) [C:\J2\w\prod-v2\bsr\30172\caade\p\b\protodbe86560baa54\b\build\libprotobuf-lite.vcxproj]
    C:\J2\w\prod-v2\bsr\30172\caade\p\b\protodbe86560baa54\b\src\src\google/protobuf/stubs/hash.h(241,50): error C2143: syntax error: missing ',' before '<' (compiling source file C:\J2\w\prod-v2\bsr\30172\caade\p\b\protodbe86560baa54\b\src\src\google\protobuf\stubs\time.cc) [C:\J2\w\prod-v2\bsr\30172\caade\p\b\protodbe86560baa54\b\build\libprotobuf-lite.vcxproj]
    C:\J2\w\prod-v2\bsr\30172\caade\p\b\protodbe86560baa54\b\src\src\google/protobuf/stubs/hash.h(242,2): message : see reference to class template instantiation 'google::protobuf::hash<Key>' being compiled (compiling source file C:\J2\w\prod-v2\bsr\30172\caade\p\b\protodbe86560baa54\b\src\src\google\protobuf\stubs\time.cc) [C:\J2\w\prod-v2\bsr\30172\caade\p\b\protodbe86560baa54\b\build\libprotobuf-lite.vcxproj]
    C:\J2\w\prod-v2\bsr\30172\caade\p\b\protodbe86560baa54\b\src\src\google/protobuf/stubs/hash.h(255,14): error C2039: 'hash_compare': is not a member of 'std' (compiling source file C:\J2\w\prod-v2\bsr\30172\caade\p\b\protodbe86560baa54\b\src\src\google\protobuf\stubs\time.cc) [C:\J2\w\prod-v2\bsr\30172\caade\p\b\protodbe86560baa54\b\build\libprotobuf-lite.vcxproj]
    C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.36.32532\include\unordered_set(24,1): message : see declaration of 'std' (compiling source file C:\J2\w\prod-v2\bsr\30172\caade\p\b\protodbe86560baa54\b\src\src\google\protobuf\stubs\time.cc) [C:\J2\w\prod-v2\bsr\30172\caade\p\b\protodbe86560baa54\b\build\libprotobuf-lite.vcxproj]
    C:\J2\w\prod-v2\bsr\30172\caade\p\b\protodbe86560baa54\b\src\src\google/protobuf/stubs/hash.h(255): error C2504: 'hash_compare': base class undefined (compiling source file C:\J2\w\prod-v2\bsr\30172\caade\p\b\protodbe86560baa54\b\src\src\google\protobuf\stubs\time.cc) [C:\J2\w\prod-v2\bsr\30172\caade\p\b\protodbe86560baa54\b\build\libprotobuf-lite.vcxproj]
    C:\J2\w\prod-v2\bsr\30172\caade\p\b\protodbe86560baa54\b\src\src\google/protobuf/stubs/hash.h(255,42): error C2143: syntax error: missing ',' before '<' (compiling source file C:\J2\w\prod-v2\bsr\30172\caade\p\b\protodbe86560baa54\b\src\src\google\protobuf\stubs\time.cc) [C:\J2\w\prod-v2\bsr\30172\caade\p\b\protodbe86560baa54\b\build\libprotobuf-lite.vcxproj]
    C:\J2\w\prod-v2\bsr\30172\caade\p\b\protodbe86560baa54\b\src\src\google/protobuf/stubs/hash.h(400,29): error C2064: term does not evaluate to a function taking 1 arguments (compiling source file C:\J2\w\prod-v2\bsr\30172\caade\p\b\protodbe86560baa54\b\src\src\google\protobuf\stubs\time.cc) [C:\J2\w\prod-v2\bsr\30172\caade\p\b\protodbe86560baa54\b\build\libprotobuf-lite.vcxproj]
    
    protobuf/3.5.1: ERROR: 
    Package 'cea0268b76c1bf488a11fff7944a4d94534ae7c9' build failed
    protobuf/3.5.1: WARN: Build folder C:\J2\w\prod-v2\bsr\30172\caade\p\b\protodbe86560baa54\b\build
    *********************************************************
    Recipe 'protobuf/3.5.1' cannot build its binary
    It is possible that this recipe is not Conan 2.0 ready
    If the recipe comes from ConanCenter, report it at https://github.com/conan-io/conan-center-index/issues
    If it is your recipe, check if it is updated to 2.0
    *********************************************************
    
    ERROR: protobuf/3.5.1: Error in build() method, line 184
    	cmake.build()
    	ConanException: Error 1 while executing
    

Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

@luizfeldmann
Copy link
Contributor Author

Let's try to backport these patches into the upstream:
protocolbuffers/protobuf#14644
protocolbuffers/protobuf#14641

@ghost ghost mentioned this pull request Nov 17, 2023
3 tasks
@ghost ghost mentioned this pull request Feb 6, 2024
3 tasks
@ghost ghost mentioned this pull request Mar 14, 2024
3 tasks
@ghost ghost mentioned this pull request Apr 16, 2024
@ghost ghost mentioned this pull request May 29, 2024
@jcar87
Copy link
Contributor

jcar87 commented May 29, 2024

Hi @luizfeldmann - thank you for your contribution.

unforunately as you have seen - this is too old a version (2017) and keeping it working for newer systems and compilers is too much effort - this wouldn't be 3.5.1, this would be 3.5.1 with a series of backports. It's also telling that protobuf themselves have not paid protocolbuffers/protobuf#14644 or protocolbuffers/protobuf#14641 much attention.

Accepting this would impose too high a maintenance burden for us.

I appreciate this is a common use case that in certain users need to stay on too-old versions of certification purposes - that is why we have a variety of strategies for users to maintain their own versions of recipes:

@jcar87 jcar87 closed this May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants