-
Notifications
You must be signed in to change notification settings - Fork 2k
Adding protobuf/3.5.1 #20627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding protobuf/3.5.1 #20627
Conversation
🤖 Beep Boop! This pull request is making changes to 'recipes/protobuf//'. 👋 @Hopobcn you might be interested. 😉 |
I detected other pull requests that are modifying protobuf/all recipe:
This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit 9282bedprotobuf/3.5.1@#f37d6348284a821cc983ab08f2c29d61
|
Regarding the macOS build failure. It happens because there is no patch to the GID fields for 3.5.1 in the test_package for this version. Other versions of protobuf received those patches (see the PR #16453). That bug is officially fixed since 3.22.0, and probably can be easily be backported to 3.7.1 (using the port_def.inc and port_undef.inc mechanism). The reason the mentioned PR give to backport this bugfix to 3.21.12 is to allow the googleapis to use it. See googleapis conanfile. I suggest to change the test_package to let this bug pass in 3.5.1. @jcar87 any opinion on this? |
…cOS's syslimits header from defining GID_MAX or UID_MAX
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit 0f88ca2protobuf/3.5.1@#a604aeda29284b002b2a1d2041c5c399
|
Saudações @luizfeldmann and @lucaskdc I don't recommend skipping the test package, it's important to keep reproducibility and validate the generated package. Instead, I would ask to backport patch if possible. You see, without the test package we can't confirm if that package is really working when distributed. |
Running the command
As I'm not familiar with macOS, I'm assuming it's related to |
* CMake: osx use @rpath/ as target's install name (CMP0042) On MacoS library should use @rpath/ as prefix path instead of absolute build path e.g. otool -L libprotobuf.dylib libprotobuf.dylib: @rpath/libprotobuf.dylib (...) ... * CMake: add rpath to target for LINUX and APPLE
This PR seems to address this issue. |
This comment has been minimized.
This comment has been minimized.
New issue related to source file generated at build-time, see: The build process generates a custom executable This method seems to break cross-compilations and because the host cannot run this executable (which is built for the cross compilation target and not for the host architecture). This PR later resolved the issues by completely removing this step and instead having this file being part of the source instead of auto-generated. |
Conan v1 pipeline ✔️All green in build 6 (
Conan v2 pipeline ❌
The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping See details:Failure in build 6 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. |
Let's try to backport these patches into the upstream: |
Hi @luizfeldmann - thank you for your contribution. unforunately as you have seen - this is too old a version (2017) and keeping it working for newer systems and compilers is too much effort - this wouldn't be Accepting this would impose too high a maintenance burden for us. I appreciate this is a common use case that in certain users need to stay on too-old versions of certification purposes - that is why we have a variety of strategies for users to maintain their own versions of recipes: |
Specify library name and version: protobuf/3.5.1
This is an older version of the library but it's important to have it here because it's the last one to support C++98.