-
Notifications
You must be signed in to change notification settings - Fork 9.6k
V3 Node Schema Definition - initial #8656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… out code made during exploration
…es' execute function
…rmeasures to avoid state leaks, ready ability to add extra params to clean class type clone
…other than 'required'/'optional' in the long run
…change formatting (need to change execution.py to recognize it as v3 as well)
…ng to edit execution.py code
…ew convention, make v1 test node have xyz be optional
…mplify defining basic types
…o longer necessary
…ls.hidden will only have values given for corresponding entries in the schema's hidden entry, fixed v3 node check in execution.get_input_data, some cleanup of whitespace and commented out code
…tiType.Input io_types renamed to types
V3 update - Removed v3 extras nodes, will live in v3-nodes branch until needed
Removed v3 resources - needs more time to cook
V3 update - move ExecutionBlocker to graph_utils.py to avoid CI torch import too soon
`ComfyExtension` Example (PR to v3-definition)
…tempted to be loaded in nodes.py
V3 update - fixed ComfyExtension, removed v3/v1 test nodes from loading
import av | ||
import numpy as np | ||
import torch | ||
import torchaudio |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unchecked torchaudio import breaks comfy for anyone running torchaudio-incompatible torch (torchaudio is deprecated and mostly only compatible with nvidia)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, will fix today!
Creating a draft pr to help visibility on GitHub and not just have discussion on discord.
Remaining work before ready for 'real' review and merge:
_io.py
and_ui.py
may be changed at any time. Fine to keep in its current state until further refactors happen.