Skip to content

Conversation

Kosinkadink
Copy link
Collaborator

@Kosinkadink Kosinkadink commented Jun 25, 2025

Creating a draft pr to help visibility on GitHub and not just have discussion on discord.

Remaining work before ready for 'real' review and merge:

  • Refactor v3/io.py and v3/ui.py to live on the new versioned Core API that will be merged soon: ComfyAPI Core v0.0.2 #8962
  • Remove V3/V1 test nodes; should not actually be added to core. Maybe move them to some test directory?
  • Decide if cls.resources should exist in the initial version - don't have a clear list of what should be exposed there right now.
    • Removing for now, as this is part of the model/input/output management refactor
  • Review some of the syntactic sugar added to ui.py
    • Schema is under construction even after gets merged, so anything in _io.py and _ui.py may be changed at any time. Fine to keep in its current state until further refactors happen.
  • Add notes about current stable (or unstable lol) API version

…rmeasures to avoid state leaks, ready ability to add extra params to clean class type clone
…other than 'required'/'optional' in the long run
…change formatting (need to change execution.py to recognize it as v3 as well)
…ew convention, make v1 test node have xyz be optional
…ls.hidden will only have values given for corresponding entries in the schema's hidden entry, fixed v3 node check in execution.get_input_data, some cleanup of whitespace and commented out code
@Kosinkadink Kosinkadink changed the title V3 Node Schema Definition (still a massive work in progress) V3 Node Schema Definition - initial Jul 31, 2025
@comfyanonymous comfyanonymous merged commit 4887743 into master Jul 31, 2025
7 checks passed
@github-project-automation github-project-automation bot moved this from In progress to Done in V3 ComfyUI Jul 31, 2025
import av
import numpy as np
import torch
import torchaudio
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unchecked torchaudio import breaks comfy for anyone running torchaudio-incompatible torch (torchaudio is deprecated and mostly only compatible with nvidia)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, will fix today!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

7 participants