Skip to content

Conversation

guill
Copy link
Collaborator

@guill guill commented Jul 18, 2025

Adds the framework for the initial version of the backward-compatible Core API in ComfyUI

@Kosinkadink
Copy link
Collaborator

From my brief review, looks good - I am in the process of refactoring v3-definition so that it can live on the Core API as well.

I haven't tested any of the async_to_sync code. Does it seem to 'just work' so far?

@robinjhuang robinjhuang added the v3 label Jul 24, 2025
@robinjhuang robinjhuang moved this to In progress in V3 ComfyUI Jul 24, 2025
@guill
Copy link
Collaborator Author

guill commented Jul 25, 2025

Additional feedback from @Kosinkadink in a call:
Currently, we aren't exporting the input types from v0_0_2 (or the like). I'm going to add an Inputs class to do that, similar to what he's doing for IO in the Schema v3 PR.

guill added 5 commits July 25, 2025 14:00
The input types, input impls, and utility types are now all available in
the versioned API. See the change in `comfy_extras/nodes_video.py` for
an example of their usage.
@comfyanonymous comfyanonymous merged commit 0a3d062 into master Jul 30, 2025
13 checks passed
@github-project-automation github-project-automation bot moved this from In progress to Done in V3 ComfyUI Jul 30, 2025
@comfyanonymous comfyanonymous deleted the js/core-api-framework branch July 30, 2025 02:17
Vander-Bilt pushed a commit to Vander-Bilt/ComfyUI that referenced this pull request Aug 26, 2025
* ComfyAPI Core v0.0.2

* Respond to PR feedback

* Fix Python 3.9 errors

* Fix missing backward compatibility proxy

* Reorganize types a bit

The input types, input impls, and utility types are now all available in
the versioned API. See the change in `comfy_extras/nodes_video.py` for
an example of their usage.

* Remove the need for `--generate-api-stubs`

* Fix generated stubs differing by Python version

* Fix ruff formatting issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants