ComfyExtension Example (PR to v3-definition)
#9103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For extension.get_node_list(), should we make that support both sync and async as well (iscoroutine check)? |
|
I'm leaning away from doing that check everywhere. Every implementation that would work with The only reason I'm doing the check with |
|
Oh, also realized I'm missing the |
|
mergin |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is meant to be a minimal example of how we would introduce the concept of
a
ComfyExtensionin a way that would allow us to add additional extension points inthe future without either breaking old functionality or introducing an ever-growing
list of 'magic keywords' that people just have to know about.